mirror of
https://github.com/libsdl-org/SDL.git
synced 2026-05-16 14:17:42 +08:00
surface: cannot set a palette to a non-indexed surface
This fixes a UBSAN warning later in this function where it calculates (1 << SDL_BITSPERPIXEL(surface->format)). The bpp might be >= 32 and out of range for a bit shift.
This commit is contained in:
committed by
Sam Lantinga
parent
6b26332785
commit
d5af35e3fb
@@ -423,7 +423,7 @@ SDL_Palette *SDL_CreateSurfacePalette(SDL_Surface *surface)
|
||||
|
||||
bool SDL_SetSurfacePalette(SDL_Surface *surface, SDL_Palette *palette)
|
||||
{
|
||||
CHECK_PARAM(!SDL_SurfaceValid(surface)) {
|
||||
CHECK_PARAM(!SDL_SurfaceValid(surface) || !SDL_ISPIXELFORMAT_INDEXED(surface->format)) {
|
||||
return SDL_InvalidParamError("surface");
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user