mirror of
https://github.com/PX4/PX4-Autopilot.git
synced 2026-10-06 09:02:52 +08:00
3309f497d8
* fix(macos.sh): trust brew taps before tapping them Recent Homebrew validates every formula of a tap while tapping it. On Homebrew 6.0+ loading a formula from an untrusted tap is refused, so `brew tap osx-cross/arm` and `brew tap PX4/px4` now fail with "Cannot tap ...: invalid syntax in tap!" because `brew trust` only ran afterwards. Without the PX4/px4 tap, `brew install` aborts on `fastdds` before pouring any package, ccache included, and the macOS CI job dies with `ccache: command not found`. main has been red since 2026-09-14. Run `brew trust` before `brew tap`; it accepts taps that are not installed yet. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(macos.sh): trust osrf/simulation tap before tapping it Same ordering problem as the toolchain taps: with Homebrew 6.0+ tapping an untrusted tap fails, so there is no tap clone to apply the gz-tap-pin.txt pin to. The later install of osrf/simulation/gz-harmonic then taps it implicitly at HEAD, silently skipping the pin and risking Gazebo building from source. Assisted-by: Claude:claude-opus-5 Signed-off-by: Julian Oes <julian@oes.ch> * fix(macos.sh): set -e to abort on first failure The script kept going after a failed `brew tap` or `brew install`, so the macOS CI job only failed much later with `ccache: command not found`, far away from the actual cause. Add `set -e`. Commands that are allowed to fail (`brew uninstall flock` on a machine without it, `brew doctor` warnings, fetching the gz tap pin whose failure is already handled by the following checkout) get an explicit `|| true`. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> --------- Signed-off-by: Julian Oes <julian@oes.ch> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Julian Oes <julian@oes.ch>