Backport cherry-embedded/CherryUSB@41f5796:
https://github.com/cherry-embedded/CherryUSB/commit/41f57964cc442145099250f0190eb71e9d1d9d5a
The fix is already merged in CherryUSB upstream but is not included in
the v1.6.1 copy integrated in RT-Thread. The EHCI port cleans qTD/QH
descriptors and the transfer buffer for DMA, but not the SETUP packet,
so on a non-coherent platform the controller can read a stale packet and
a device may never enumerate.
Apply the upstream change: clean the SETUP buffer in ehci_qh_add_head()
before the QH is linked into the asynchronous or periodic list.
* fix(libcpu/arm): correct format specifiers in GIC dump functions
Fix -Wformat warnings in arm_gic_dump_type() and arm_gic_dump() for
both GICv2 (gic.c) and GICv3 (gicv3.c):
- %p with rt_uint32_t physical address -> 0x%08x (non-pointer passed to
%p is undefined behavior)
- %d with unsigned int / unsigned long -> %u (signed/unsigned mismatch)
- Add explicit (unsigned int) cast for GIC version extracted with 0xfUL
These warnings appear when compiling Cortex-A BSPs with -Wall -Wformat.
* style: format code with clang-format
* style: format code with clang-format
* [libcpu][arm] Fix undefined signed shift in GIC RWP macros
---------
Co-authored-by: Rbb666 <zhangbingru@rt-thread.com>
* drivers/spi: add QEMU virtual SPI loopback bus for utest (#11972)
Register a pure-software SPI bus (default name spi2) with memcpy
loopback xfer so components.drivers.spi.loopback passes on
qemu-vexpress-a9 without a PL022 model. Fix utest include/CPPPATH
and align Kconfig/rtconfig bus name.
Verified: scons + qemu utest_run components.drivers.spi.loopback PASSED.
Fixes#11972 (SPI/QEMU checklist item).
* drivers/spi: fix clang-format violations in spi_virt_bus.c
Fix the 'Check File Format and License' CI job failure:
- put the spi_virt_ops initializer brace on the assignment line
- add the missing newline at end of file
No functional change.
* drivers/spi: separate virt bus Kconfig from loopback utest (#11972)
Add a dedicated, default-off RT_UTEST_SPI_VIRT_BUS switch (default name
spi_virt) so enabling RT_UTEST_SPI_LOOPBACK no longer compiles or
registers a software SPI bus. Hardware loopback now always runs on the
real controller named by RT_UTEST_SPI_LOOPBACK_BUS_NAME, while QEMU/CI
targets opt in to the virtual bus explicitly.
Also move the utest enablement out of the qemu-vexpress-a9 BSP defaults
and into ci.attachconfig as peripheral.SPI_VIRT_LOOPBACK.
* cla: empty commit to retrigger license/cla check (#11979)
* ci(utest): add A9 SPI loopback virt bus config (#11979)
* [drivers][spi] gate virtual SPI bus utest on !RT_USING_DM
RT_UTEST_SPI_VIRT_BUS compiles spi_virt_bus.c, which registers a software
loopback bus with rt_spi_bus_register(). That path needs no device tree
node, so on a BSP that enables RT_USING_DM and RT_USING_OFW the
registration fails with -RT_EINVAL when no matching DT node exists.
Add "depends on !RT_USING_DM" to the option and document in help that it
is only available without the device model and must stay disabled on DM
based BSPs. spi_virt_bus.c is already fully wrapped in
#ifdef RT_UTEST_SPI_VIRT_BUS, so no C change is needed.
The A9 utest config (bsp/qemu-vexpress-a9) has RT_USING_DM disabled, and
.github/utest/configs/components/spi.cfg still enables both the virt bus
and the loopback test with bus name "spi_virt", so CI coverage is kept.
Refs #11972
timerfd_do_settime() and timerfd_do_gettime() used vnode->data from any
file descriptor as struct rt_timerfd. Validate that the descriptor's file
operations are timerfd_fops before dereferencing the private data, using
df->fops under DFS v2 and vnode->fops under DFS v1.
timer_gettime() and timer_settime() indexed _g_timerid[] with the raw
timer_t value, unlike timer_delete(). Reject ids >= TIMER_ID_MAX before
the lookup to keep the table access in bounds.
picolibc declares the buffer as char[restrict static 26], so the pointer
form warns with -Warray-parameter and the NULL check with -Wnonnull-compare.
Other C libraries keep the pointer form.
Signed-off-by: Parthiban Nallathambi <parthiban@linumiz.com>
Compile the user-time accounting branch only for RT_USING_SMART, so non-SMART threads contribute system or idle time. Preserve existing SMART accounting behavior.
Signed-off-by: Rbb666 <zhangbingru@rt-thread.com>
* [utest][can] Add CAN send and receive tests
* [utest][can] Fix external CAN FD receive timeout
Check the no-progress timeout after duplicate or unmatched frames, and
only wait on the receive semaphore when no complete frame is available.
Exit immediately once all expected patterns have been received.
Format the test with the current mainline configuration and clang-format
22.1.8.
Validation: reproduced the original duplicate/unmatched-frame hang with
a 50-tick timeout and a 1000-tick watchdog. All 22 host-stub scenarios pass,
including timeout renewal, tick wraparound, empty reads, error propagation,
and successful reception. The mainline formatting check also passes.
No full BSP build or hardware test was performed.
* [UTEST][SDIO] Add block device read and write test
* [UTEST][SDIO] Fix change log author
* [utest][sdio] Format block read and write test
Align macros and continuation indentation using the current mainline
configuration and clang-format 22.1.8.
Validation: the mainline formatting check and git diff --check pass.
Verified that all changes are whitespace-only.
- Implement RT-Thread Input Capture devices using STM32 HAL TIM1-TIM4, with configurable channels, filters and initial capture polarity.
- Add STM32F1 and STM32H7 configuration headers and integrate the driver into Kconfig and SConscript.
- Handle APB timer clock multipliers, TIMPRE and 32-bit counter capabilities using HAL feature macros.
- Clear pending capture and overcapture flags before restarting a capture channel.
* dfs/posix: enforce bounds check and clean unregister in signalfd
Validate array bounds on signalfd notification registration and remove
the unsafe global index counter.
Tie the registered process lifetime to the registration: each slot in
sfd->lwp[] holds an LWP reference, and the listener node carries a detach
hook that the process exit path runs under LWP_LOCK to unlink the node,
clear the slot and drop the reference. Final close therefore never walks
a freed process, and a child that registered through an inherited
descriptor is unregistered when it exits.
Move every change of lwp->signalfd_notify_head behind lwp_signal_notify_*
helpers in the lwp core, which take LWP_LOCK, the lock lwp_signal_notify()
traverses the list under. The lock order is LWP_LOCK -> sfd->lock, the
same order the signal path already uses; sfd->lock is never held while
taking LWP_LOCK, and a node is only unlinked under LWP_LOCK, so no
in-flight notification can be inside it when it is freed.
Tear down the vnode, context and mutex before fd_release() when the
initial registration fails, and return instead of falling through to
freed objects. Propagate registration failures: read returns the error
and poll reports POLLERR before anything is added to the poll queue.
Fixes: #11933
Signed-off-by: Adil Alperen Ciftci <adilalperenciftci@users.noreply.github.com>
* dfs/posix: state the signalfd context lifetime and tighten close
State the lifetime assumption of the signalfd context explicitly: the
descriptor the caller operates on pins the context for the whole read,
poll and registration, and a concurrent close of that same descriptor by
another thread is not supported, which is what the existing read and poll
paths already rely on. The post-registration slot re-check therefore does
not add a new requirement.
Clear all registration slots in one pass under sfd->lock in close and run
the per-process unlink and reference drop outside the lock afterwards, so
the "clear first, unlink later" invariant is one block instead of a lock
round-trip per slot.
Rename SIGNALFD_SHART_MAX to SIGNALFD_SHARE_MAX while the macro block is
being touched.
Signed-off-by: Adil Alperen Ciftci <adilalperenciftci@users.noreply.github.com>
* dfs/posix: keep the LWP lock out of signalfd close and make registration atomic
dfs_file_close() calls the signalfd close callback under the global DFS
file lock, and the process exit path takes that same lock while it already
holds LWP_LOCK (__exit_files() under _resr_cleanup()). Unlinking the
listeners from close() through lwp_signal_notify_remove_queue() therefore
took the two locks in the opposite order to process exit, and a parent
closing a shared signalfd while a registered child exits could block each
side on the other's lock.
Close no longer takes any LWP lock. It marks the context closing, detaches
it from the vnode and submits a release work item to the system workqueue.
The work takes the slots over under sfd->lock, unlinks the listeners under
each process's own LWP_LOCK with no other lock held, drops the references
the slots owned, and frees the context. A process that exits before the
work runs has already cleared its slot and dropped its reference through
the exit hook, so the work only sees slots that are still live.
Registration now does the lookup, the slot assignment and the listener
insertion in one critical section under LWP_LOCK(self) -> sfd->lock, the
same order the exit hook already uses. A slot is never visible without its
listener, so a second thread cannot observe a registration whose listener
is still missing, and the lookup cannot go stale between the check and the
assignment. lwp_signal_notify_add() accordingly expects the caller to hold
LWP_LOCK; the single-node unlink helper that the post-registration
re-check used is gone with that re-check. A registration that races with
close finds the closing flag and fails with EBADF instead of taking a slot
the release work will not see.
Signed-off-by: Adil Alperen Ciftci <adilalperenciftci@users.noreply.github.com>
* dfs/posix: do not allocate for an existing signalfd registration
signalfd_add_notify() allocated the listener node before looking the
calling process up, so read and poll on an already registered descriptor
failed with ENOMEM or POLLERR under memory pressure even though no node
was needed and a signal may already have been queued.
Look the process up first, under LWP_LOCK(self) -> sfd->lock, and return
from there when it is registered or the context is closing. Only when a
new registration is needed drop the locks, allocate the node, take the
locks again and repeat the lookup unconditionally: the closing flag, an
existing registration and the free slot are all re-evaluated before the
slot is assigned and the listener is linked in the same critical section.
A node left over because another thread registered the process meanwhile
is freed after the locks are released.
Signed-off-by: Adil Alperen Ciftci <adilalperenciftci@users.noreply.github.com>
* dfs/posix: align signalfd context member comments for clang-format
Signed-off-by: Adil Alperen Ciftci <adilalperenciftci@users.noreply.github.com>
---------
Signed-off-by: Adil Alperen Ciftci <adilalperenciftci@users.noreply.github.com>
Co-authored-by: Adil Alperen Ciftci <adilalperenciftci@users.noreply.github.com>
* [smart] lwp: enforce user buffer validation and copyin/copyout in terminal ioctl
In the RT-Smart terminal subsystem, userspace ioctl commands (such as TIOCGWINSZ, TIOCSWINSZ, TIOCGPGRP, TIOCGSID, FIONREAD, and TIOCGPTN) were previously passed directly to underlying FreeBSD ioctl handlers as raw user pointers without kernel staging or copy validation.
This patch addresses the user pointer dereference sinks:
1. In lwp_tty_ioctl_adapter(), stage arguments in kernel stack buffers and use _copy_from_user() / _copy_to_user() (lwp_get_from_user / lwp_put_to_user) for TIOCGWINSZ, TIOCSWINSZ, TIOCGPGRP, TIOCSPGRP, TIOCGSID, TIOCSTI, TIOCOUTQ, FIONREAD, and modem commands.
2. In ptm_fops_ioctl(), safely buffer arguments for TIOCGPTN, TIOCPKT, TIOCSIG, TIOCGPGRP, TIOCGSID, FIONREAD, TIOCOUTQ, TIOCGWINSZ, TIOCSWINSZ, and termios settings, returning -ENOTTY on unrecognized commands.
3. In tty_generic_ioctl(), add defense-in-depth boundary checks using lwp_in_user_space() to safeguard kernel memory from arbitrary pointer dereferences.
Signed-off-by: Adil Alperen Çiftci <adilalperenciftci@users.noreply.github.com>
* [smart] lwp: make the tty ioctl adapters the single uaccess boundary
lwp_tty_ioctl_adapter() and ptm_fops_ioctl() (through
lwp_ptmx_ioctl_forward()) already stage every user argument into a kernel
buffer before entering the BSD tty layer, so tty_generic_ioctl() only ever
sees kernel pointers on the syscall path. Drop the lwp_in_user_space()
branches that were added there, and the older one on TIOCSPGRP, so the
trust boundary is in exactly one place per entry point and the switch no
longer mixes two models.
Zero the staging union in lwp_ptmx_ioctl_forward() before the backend
runs: an *_OUT command copies it back to the caller, and a backend that
returns 0 without filling it would otherwise hand out stack contents.
Add the BSD termios commands TIOCGETA, TIOCSETA, TIOCSETAW and TIOCSETAF
to the /dev/ptmx argument table so they keep reaching the tty layer as
they did before the table existed. The termio-based TCGETA family is not
handled by the BSD layer on this path and stays ENOTTY, as before.
Rename lwp_ptmx_ioctl_arg_type() to lwp_ptmx_ioctl_arg_type_get() so the
function no longer shares its name with the enum tag, rename the test
case to testcases.lwp.tty_ptmx.regression since it covers more than the
buffer bounds, and add the terminal directory to the utest CPPPATH
instead of a relative include.
Signed-off-by: Adil Alperen Ciftci <adilalperenciftci@users.noreply.github.com>
* [smart] lwp: drop duplicate termios cases from the ptmx ioctl table
In this port TIOCGETA and TIOCSETA/TIOCSETAW/TIOCSETAF are defined to the
same values as TCGETS and TCSETS/TCSETSW/TCSETSF, so listing both sets
makes the switch fail to compile with duplicate case values. The TCGETS
family entries already cover the BSD names; the test asserts for the BSD
spellings stay valid through the aliases.
Signed-off-by: Adil Alperen Ciftci <adilalperenciftci@users.noreply.github.com>
---------
Signed-off-by: Adil Alperen Çiftci <adilalperenciftci@users.noreply.github.com>
Signed-off-by: Adil Alperen Ciftci <adilalperenciftci@users.noreply.github.com>
Co-authored-by: Adil Alperen Çiftci <adilalperenciftci@users.noreply.github.com>
Co-authored-by: Rbb666 <zhangbingru@rt-thread.com>
Add components.drivers.watchdog.smoke covering device find/open and
timeout set/get. Optional start/keepalive/stop stays off by default
to avoid board reset when STOP is unsupported.
Co-Authored-By: Grok <seteiro@mail.grokbot.com>
* [DM/PCI] Validate MSI-X table BIR and offset against BAR
BIR and the table offset in the MSI-X capability are controlled by the
device. msix_table_remap() used BIR directly as an index into
pdev->resource[] and never checked the table against the BAR size, so a
malicious device could make the kernel map and write to an arbitrary
physical address during probe.
Reject out-of-range BIR values, unassigned or zero-sized BARs, and
tables that do not fit completely inside the assigned BAR. Also verify
that the requested vector count does not exceed the table size read
from the MSI-X control register.
Fixes#11985
* [DM/PCI] Fix cppcheck warnings in MSI-X code
- Restore the default IRQ only when an MSI descriptor exists, avoiding
a potential NULL pointer dereference in rt_pci_msi_shutdown
- Initialize the error code in msix_setup_msi_descs so that an empty
vector list returns a defined value
is_pte_valid() accepted a GPT entry as long as both LBAs were inside the
disk, so a crafted image could set ending_lba < starting_lba. The size
computed in efi_partition() then underflowed to a huge value and was
registered as the logical partition size.
Reject entries whose end LBA is below the start LBA, and compute the
partition start/size only after the entry passed validation. This avoids
evaluating the underflow at all and reuses the validated start value for
the size calculation.
FixesRT-Thread/rt-thread#11271.
Co-authored-by: DeepSeek 4.1 Flash <noreply@deepseek.com>