Mirrors_Framework/SDL
1
0
Fork 0
mirror of https://github.com/libsdl-org/SDL.git synced 2026-02-06 10:22:17 +08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

event: Only consider topmost windows when generating SDL_QUIT
Some checks failed
Build (All) / Create test plan (push) Has been cancelled
Details
Build (All) / level1 (push) Has been cancelled
Details
Build (All) / level2 (push) Has been cancelled
Details

Browse Source 
Otherwise, the quit event can be sent prematurely. The topmost status must be queried and cached before sending the close request event, as the window may be destroyed in an event handler.
This commit is contained in:
Frank Praznik
2026-01-17 15:43:04 -05:00
parent 56e121f6e3
commit 34b620c3f8
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/events/SDL_windowevents.c
View File

@@ -228,6 +228,9 @@ bool SDL_SendWindowEvent(SDL_Window *window, SDL_EventType windowevent, int data
post_event = false;
}
// The window might be destroyed in an event handler, so cache the topmost status first.
const bool window_is_topmost = !window->parent;
// Post the event, if desired
SDL_Event event;
event.type = windowevent;
@@ -301,7 +304,7 @@ bool SDL_SendWindowEvent(SDL_Window *window, SDL_EventType windowevent, int data
}
}
if (windowevent == SDL_EVENT_WINDOW_CLOSE_REQUESTED && !SDL_HasActiveTrays()) {
if (windowevent == SDL_EVENT_WINDOW_CLOSE_REQUESTED && window_is_topmost && !SDL_HasActiveTrays()) {
int count = window ? 0 : 1;
for (SDL_Window *n = _this->windows; n; n = n->next) {
if (!n->parent && !(n->flags & SDL_WINDOW_HIDDEN)) {