mirror of
https://github.com/PX4/PX4-Autopilot.git
synced 2026-05-20 11:23:06 +08:00
Ramon Roche
b142342c3a
* ci(claude): add review-pr skill for domain-aware PR reviews Add a Claude Code skill that reviews pull requests with checks tailored to the domains touched (estimation, control, drivers, simulation, system, CI/build, messages, board additions). Built from analysis of 800+ PR reviews across 8 PX4 maintainers. Includes merge strategy recommendation, interactive dialog for submitting reviews, and human-sounding PR comment formatting. Signed-off-by: Ramon Roche <mrpollo@gmail.com> * ci(copilot): add domain-scoped review instructions for GitHub Copilot Add .github/instructions/ files that give GitHub Copilot PR reviews the same domain-aware context as the Claude Code review-pr skill. Each file is scoped via applyTo to the relevant source paths: core review, estimation, control, drivers/CAN, simulation, system, CI/build, messages/protocol, and board additions. Signed-off-by: Ramon Roche <mrpollo@gmail.com> * fix(claude): address Copilot review feedback - Fix step reference in review-pr skill (step 8 -> step 9) - Capitalize CMake consistently in skill and Copilot instructions Signed-off-by: Ramon Roche <mrpollo@gmail.com> --------- Signed-off-by: Ramon Roche <mrpollo@gmail.com>
14 lines
488 B
Markdown
14 lines
488 B
Markdown
---
|
|
applyTo: "src/drivers/**,src/modules/cyphal/**"
|
|
---
|
|
|
|
# Drivers/CAN Review Guidelines
|
|
|
|
In addition to the core code review guidelines:
|
|
|
|
- CAN bus devices behave differently from serial/SPI; check driver assumptions
|
|
- ESC index mapping: telemetry index != channel when motors are disabled
|
|
- ESC hardware quirks: 4-in-1 ESCs may report current on only one channel
|
|
- Verify device_id correctness and I2CSPIDriver patterns
|
|
- Time representation: prefer `hrt_abstime` over iteration counts
|