pwm_out: check PWM_OUT_MAX_INSTANCES with conditional

- PWM_OUT_MAX_INSTANCES is a constant (static constexpr) not available to the preprocessor
This commit is contained in:
Daniel Agar
2021-03-23 22:13:18 -04:00
committed by GitHub
parent 3983f0b833
commit b2faea7f43
2 changed files with 10 additions and 14 deletions
-2
View File
@@ -34,8 +34,6 @@ px4_add_module(
MODULE drivers__pwm_out
MAIN pwm_out
COMPILE_FLAGS
-Wno-unused-but-set-variable # TODO
-Wno-unused-variable # TODO
SRCS
PWMOut.cpp
PWMOut.hpp
+10 -12
View File
@@ -1743,24 +1743,22 @@ int PWMOut::fmu_new_mode(PortMode new_mode)
return -1;
}
#if PWM_OUT_MAX_INSTANCES > 0
PWMOut *pwm0 = _objects[0].load(); // TODO: get_instance();
if (PWM_OUT_MAX_INSTANCES > 0) {
PWMOut *pwm0 = _objects[0].load(); // TODO: get_instance();
if (pwm0 && pwm_mode0 != pwm0->get_mode()) {
pwm0->request_mode(pwm_mode0);
if (pwm0 && pwm_mode0 != pwm0->get_mode()) {
pwm0->request_mode(pwm_mode0);
}
}
#endif
if (PWM_OUT_MAX_INSTANCES > 1) {
PWMOut *pwm1 = _objects[1].load(); // TODO: get_instance();
#if PWM_OUT_MAX_INSTANCES > 1
PWMOut *pwm1 = _objects[1].load(); // TODO: get_instance();
if (pwm1 && pwm_mode1 != pwm1->get_mode()) {
pwm1->request_mode(pwm_mode1);
if (pwm1 && pwm_mode1 != pwm1->get_mode()) {
pwm1->request_mode(pwm_mode1);
}
}
#endif
return OK;
}