Mirrors_Framework/PX4-Autopilot
1
0
Fork 0
mirror of https://github.com/PX4/PX4-Autopilot.git synced 2026-05-21 21:55:34 +08:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

test_dataman: remove invalid item tests

Browse Source 
They caused ASAN failures. And since the dm_item_t is an enum, I don't
think it needs a test.
This commit is contained in:
Beat Küng
2025-06-16 15:49:12 +02:00
parent fd2ded08e4
commit 8370ae1701
1 changed files with 0 additions and 132 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/systemcmds/tests/test_dataman.cpp
-132
View File
@@ -134,22 +134,6 @@ DatamanTest::DatamanTest()
}
bool
DatamanTest::testSyncReadInvalidItem()
{
bool success = _dataman_client1.readSync(DM_KEY_NUM_KEYS, 0, _buffer_read, 2);
return !success;
}
bool
DatamanTest::testSyncWriteInvalidItem()
{
bool success = _dataman_client1.writeSync(DM_KEY_NUM_KEYS, 0, _buffer_write, 2);
return !success;
}
bool
DatamanTest::testSyncReadInvalidIndex()
{
@@ -302,118 +286,6 @@ DatamanTest::testSyncClearAll()
return success;
}
bool
DatamanTest::testAsyncReadInvalidItem()
{
bool success = true;
State state = State::Read;
hrt_abstime start_time = hrt_absolute_time();
//While loop represents a task
while (state != State::Exit) {
_dataman_client1.update();
switch (state) {
case State::Read:
state = State::ReadWait;
success = _dataman_client1.readAsync(DM_KEY_NUM_KEYS, 0, _buffer_read, 2);
if (!success) {
return false;
}
break;
case State::ReadWait:
if (_dataman_client1.lastOperationCompleted(_response_success)) {
state = State::OperationCompleted;
if (!_response_success) {
//Test ends here
return true;
}
}
break;
default:
break;
}
if (hrt_elapsed_time(&start_time) > 1_s) {
PX4_ERR("Test timeout!");
return false;
}
//Simulate rescheduling the task after a 1 ms delay to allow time for the dataman task to operate.
px4_usleep(1_ms);
}
return false;
}
bool
DatamanTest::testAsyncWriteInvalidItem()
{
bool success = true;
State state = State::Write;
hrt_abstime start_time = hrt_absolute_time();
//While loop represents a task
while (state != State::Exit) {
_dataman_client1.update();
switch (state) {
case State::Write:
state = State::WriteWait;
success = _dataman_client1.writeAsync(DM_KEY_NUM_KEYS, 0, _buffer_write, 2);
if (!success) {
return false;
}
break;
case State::WriteWait:
if (_dataman_client1.lastOperationCompleted(_response_success)) {
state = State::OperationCompleted;
if (!_response_success) {
//Test ends here
return true;
}
}
break;
default:
break;
}
if (hrt_elapsed_time(&start_time) > 1_s) {
PX4_ERR("Test timeout!");
return false;
}
//Simulate rescheduling the task after a 1 ms delay to allow time for the dataman task to operate.
px4_usleep(1_ms);
}
return false;
}
bool
DatamanTest::testAsyncReadInvalidIndex()
{
@@ -1120,8 +992,6 @@ DatamanTest::testResetItems()
bool DatamanTest::run_tests()
{
ut_run_test(testSyncReadInvalidItem);
ut_run_test(testSyncWriteInvalidItem);
ut_run_test(testSyncReadInvalidIndex);
ut_run_test(testSyncWriteInvalidIndex);
ut_run_test(testSyncReadBufferOverflow);
@@ -1130,8 +1000,6 @@ bool DatamanTest::run_tests()
ut_run_test(testSyncWriteReadAllItemsMaxSize);
ut_run_test(testSyncClearAll);
ut_run_test(testAsyncReadInvalidItem);
ut_run_test(testAsyncWriteInvalidItem);
ut_run_test(testAsyncReadInvalidIndex);
ut_run_test(testAsyncWriteInvalidIndex);
ut_run_test(testAsyncReadBufferOverflow);