This commit is contained in:
Samuel Sadok
2020-12-09 20:06:59 +01:00
parent 320be74413
commit 119529b0a7
3 changed files with 8 additions and 4 deletions

View File

@@ -15,13 +15,15 @@ jobs:
runs-on: ${{ matrix.os }}
steps:
- name: Install odrivetool
shell: bash
run: |
pip3 list | grep setuptools || echo "setuptools not installed" # show version
pip3 install odrive
env:
# TODO: this is a workaround for https://github.com/pypa/setuptools/issues/2353 and we
# can remove it as soon as python3-setuptools on GitHub's ubuntu-latest
# moves to version 50.1+.
pip3 list | grep setuptools # show version
export SETUPTOOLS_USE_DISTUTILS=stdlib
pip3 install odrive
SETUPTOOLS_USE_DISTUTILS: stdlib
# This one currently fails because Github Actions runs pip as non-root
#- name: Check if udev rules were set up properly

View File

@@ -21,6 +21,7 @@ bool CANSimple::renew_subscription(size_t i) {
extended_node_ids_[i] = axis.config_.can.is_extended;
MsgIdFilterSpecs filter = {
.id = {},
.mask = (uint32_t)(0xffffffff << NUM_CMD_ID_BITS)
};
if (axis.config_.can.is_extended) {

View File

@@ -199,7 +199,8 @@ bool ODriveCAN::unsubscribe(CanSubscription* handle) {
subscription->fifo = kCanFifoNone;
CAN_FilterTypeDef hal_filter = {.FilterActivation = DISABLE};
CAN_FilterTypeDef hal_filter = {};
hal_filter.FilterActivation = DISABLE;
return HAL_CAN_ConfigFilter(handle_, &hal_filter) == HAL_OK;
}