Vadim Zeitlin 2be5f429c1 Don't create wrong wxAppTraits during wxApp construction
Creating wxAppTraits before the object of the user-defined class
deriving from wxApp is fully constructed may result in creating a wrong
traits object if the user class overrides CreateTraits() because the
correct, i.e. user-defined, version isn't used if it's called from wx
code.

This had already happened before and was worked around back in
bc334f39ec (Fixes Bug [ 930200 ] Async does not work, 2004-04-27), but
recently happened again after the changes of 94e4818caa (Warn on startup
when not using comctl32.dll v6 in wxMSW, 2022-11-28). To prevent it from
happening in the future, add WXAppConstructed() that must be called
after fully constructing wxApp (and forgetting to do it would result in
an assert, so doesn't risk to go unnoticed) and which resets m_traits if
it has been wrongly created.

It would, perhaps, be even better if we avoided creating the wrong
traits in the first place, but for now this at least fixes the latest
problem and ensures it doesn't reoccur.

Closes #23315.
2023-03-06 21:28:58 +00:00
2023-02-20 18:28:21 +01:00
2023-02-14 22:52:26 +01:00
2023-02-14 22:52:26 +01:00
2023-02-20 18:28:21 +01:00

About

wxWidgets is a free and open source cross-platform C++ framework for writing advanced GUI applications using native controls.

wxWidgets Logo

wxWidgets allows you to write native-looking GUI applications for all the major desktop platforms and also helps with abstracting the differences in the non-GUI aspects between them. It is free for the use in both open source and commercial applications, comes with the full, easy to read and modify, source and extensive documentation and a collection of more than a hundred examples. You can learn more about wxWidgets at https://www.wxwidgets.org/ and read its documentation online at https://docs.wxwidgets.org/

Platforms

AppVeyor Unix (make) Unix (CMake) MSW (MSVC) MSW (gcc) Mac OSS-Fuzz

This version of wxWidgets supports the following primary platforms:

  • Windows 7, 8, 10 and 11 (32/64 bits).
  • Most Unix variants using the GTK+ toolkit (version 2.6 or newer or 3.x).
  • macOS (10.10 or newer) using Cocoa under both amd64 and ARM platforms.

All C++11 compilers are supported including but not limited to:

  • Microsoft Visual C++ 2015 or later (up to 2022).
  • g++ 4.8 or later (up to 12), including MinGW/MinGW-64/TDM under Windows.
  • Clang (up to 14).

Please use 3.2 branch if you must use wxWidgets with a C++98 compiler or support Windows XP.

Licence

wxWidgets licence is a modified version of LGPL explicitly allowing not distributing the sources of an application using the library even in the case of static linking.

Building

For building the library, please see platform-specific documentation under docs/<port> directory, e.g. here are the instructions for wxGTK, wxMSW and wxOSX.

If you're building the sources checked out from Git, and not from a released version, please see these additional Git-specific notes.

Further information

If you are looking for community support, you can get it from

Commercial support is also available.

Finally, keep in mind that wxWidgets is an open source project collaboratively developed by its users and your contributions to it are always welcome. Please check our guidelines if you'd like to do it.

Have fun!

The wxWidgets Team.

Languages
C++ 69.3%
Objective-C 12.3%
C 7.8%
Makefile 4.3%
Objective-C++ 2.3%
Other 3.8%