80373 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Vadim Zeitlin	f4b679a3d4	Detect Wayland session management protocol in configure ... We need a very recent GTK with gdk_wayland_window_get_xdg_toplevel() to be able to use this protocol. Note that we don't actually do anything if the support is detected yet. But we will soon.	2026-08-06 18:40:49 +02:00
Vadim Zeitlin	e68720e2b5	Retry apt-get commands when using Ubuntu servers ... They still fail, even when using versions later than 18.04, but the failure is usually temporary, so try them several times.	2026-08-04 20:17:37 +02:00
Steve CornettandVadim Zeitlin	a5e16e55ae	Use system colors for generic calendar header ... Use system colors for generic calendar header instead of blue and gray. A separator line is drawn below the header. This makes the control look consistent with the Win32 and WinUI 3 controls. Custom header colors are not overwritten by system color change event. See #25552. Closes #26777.	2026-08-04 18:49:41 +02:00
Steve CornettandVadim Zeitlin	5d4829d6d1	Make dark mode system colors more consistent with other platforms ... Assign values for wxSYS_COLOUR_3DLIGHT and wxSYS_COLOUR_BTNHIGHLIGHT consistent with Linux and macOS. Also stop using wxSYS_COLOUR_BTNHIGHLIGHT for rendering disabled text in wxGrid and wxGenericStaticText: it didn't look before and would be even worse after this change. Instead, just draw the text in "disabled" colour, without using drop shadow at all. Closes #26753.	2026-08-04 18:46:45 +02:00
Vadim Zeitlin	d13fad4371	Prefer calling wxMSW dark mode support "unofficial" ... It's not "experimental" any longer, but we still want to make it clear that this isn't supported as well as standard mode. Closes #26752.	2026-08-04 18:40:42 +02:00
Paul Cornett	061b99fda1	Avoid crash on GTK if wxTextCtrl text is modified in wxEVT_TEXT handler ... The text iterators used in the "after" callbacks are no longer valid if the text has been modified. See #26742	2026-08-03 15:22:59 -07:00
Vadim Zeitlin	f7f534cd13	Merge branch 'sdl3' of github.com:MaartenBent/wxWidgets ... Add SDL3 support and fix Wayland build issue. See #26435, #26773.	2026-08-02 21:38:14 +02:00
Yannick DuchêneandVadim Zeitlin	bd44befcc2	Use variadic template for wxMakeGuard() in the documentation ... Make the declaration in the documentation header a valid C++ declaration. Closes #26769.	2026-08-02 21:15:49 +02:00
PBandVadim Zeitlin	cf9d191250	Don't build the MFC sample with CMake when linking CRT statically ... The MFC sample unconditionally defines "_AFXDLL", which means linking the MFC dynamically. However, this is incompatible with static CRT linking. Therefore, do not generate the MFC sample project when building wxWidgets with CMake and linking the CRT statically, since the build would have failed. Closes #26770.	2026-08-02 21:15:49 +02:00
3 people	561bb292a1	Always create a GtkImageMenuItem for wxITEM_NORMAL items in wxGTK ... wxMenu::GtkAppend() decided between GtkImageMenuItem and plain GtkMenuItem based on mitem->GetBitmap().IsOk() at Append() time. This breaks the common and explicitly supported idiom menu->Append(id, label)->SetBitmap(bmp), where the bitmap is only attached after Append() has already built the underlying widget: for any non-stock id, GtkAppend() picked a plain GtkMenuItem, and the later SetupBitmaps() call (from wxWindowGTK::DoPopupMenu(), triggered whenever the menu is actually popped up) called gtk_image_menu_item_set_image() on it, tripping the GTK_IS_IMAGE_MENU_ITEM assertion and silently failing to attach the bitmap. Always build a GtkImageMenuItem for wxITEM_NORMAL (unless a stock GTK id already provides one). An empty GtkImageMenuItem behaves identically to a plain GtkMenuItem, so this has no effect on items that never get a bitmap. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-08-02 10:43:28 -07:00
Maarten Bent	78472fde85	CMake: Make sure SDL3 targets exist when using installed wxWidgets	2026-08-02 15:01:01 +02:00
Maarten Bent	c70a840f3a	CMake: Fix defining wxHAVE_WAYLAND_CLIENT ... Fixes #26707	2026-08-02 14:48:42 +02:00
Andy VandijckandMaarten Bent	100eb6efc5	Add SDL3 support	2026-08-02 14:45:12 +02:00
Vadim Zeitlin	adde4275d5	Merge branch 'ci-stop-using-ubuntu-18.04' ... Don't use Ubuntu 18.04 and its flaky PPAs for the CI builds any more. See #26758.	2026-08-01 14:04:35 +02:00
MarkLee131andVadim Zeitlin	09cebab5cd	Validate string lengths and item counts in cached help books ... CacheReadString() took the length of a string straight from the .cached file and passed len - 1 to wxCharBuffer. A stored length of 0 underflowed to SIZE_MAX, so wxCharTypeBuffer allocated (SIZE_MAX + 1) bytes, i.e. none, and then wrote its terminator at str[SIZE_MAX], which wraps on 64-bit to a write one byte in front of the block. The buffer was also a byte shorter than the read that filled it, so the terminator was overwritten and the wxString constructor went looking for one past the end, and a large or negative length asked for a huge allocation or a read through a null pointer. Size the buffer as len so the terminator survives the read, as ReadString() in zipstrm.cpp already does, reject a length that cannot have come from CacheWriteString() or that exceeds the file, check the read actually delivered the bytes, and build the string from the known length rather than by scanning for a NUL. The contents and index counts are used to reserve memory before anything is read, so bound them against the file as well, and move the contents loop to std::make_unique so the new early returns cannot leak, as the index loop already does. Fixes #26765. Closes #26766.	2026-08-01 14:04:09 +02:00
MarkLee131andVadim Zeitlin	a546a7c518	Reject TGA images whose declared size cannot fit the input stream ... ReadTGA() sized both the image and its scratch buffer from the header's width, height and bpp without comparing them against the input stream, and never checked how much data the bulk reads actually returned. A 22 byte file declaring a 31232x16382 image at 24bpp therefore allocated 1.5 GB twice over, and, because a short read went undetected, LoadFile() returned true and handed back an image of the declared size that the file never contained. Reject dimensions whose claimed image size cannot fit the stream before allocating anything: uncompressed types must fit exactly, while the RLE variants are allowed up to 128:1 expansion, since each packet costs 1 + pixelSize input bytes and yields at most 128 * pixelSize output bytes. Also check LastRead() after the header read and after each of the three uncompressed bulk reads, so that a truncated file is reported as a failure instead of a success, as imagpcx.cpp has done since #26624; DecodeRLE() already validated its own reads. Fixes #26760. Closes #26761.	2026-08-01 13:59:48 +02:00
alilieandVadim Zeitlin	060564a4bb	Fix crash in wxOSX when toggling a toolbar item without a bitmap ... Check that the bitmap is valid before doing anything with it. Fixes #26763. Closes #26768.	2026-08-01 13:51:15 +02:00
Yannick DuchêneandVadim Zeitlin	63f0ad1c6b	Fix syntax errors in interface headers ... Add missing semicolons which resulted in 2 declarations being merged into a single one in the generated HTML. Fix user-defined operator declaration syntax. Fixes #26754. Closes #26764.	2026-08-01 13:46:48 +02:00
Vadim Zeitlin	2782377d4f	Switch Ubuntu 18.04 CI builds to newer Ubuntu versions ... Don't use the old Ubuntu version, Ubuntu PPAs are simply too flaky to be used. Use the latest available Ubuntu image (26.04) for all builds except wxDFB as libdirectfb-dev package is not available in this Ubuntu version any longer, so use 24.04 for this job. Remove special handling of Ubuntu 18.04 which is not needed any more.	2026-07-31 12:48:12 +02:00
Vadim Zeitlin	49ded50540	Fix sorted wxListBox unit test in wxQt under Unix ... Comparison doesn't seem to use locale-specific rules by default there, so limit the changes of 09c22b080e (Fix listboxtest test failing under wxQt, 2023-10-08) to Windows and check for the actually observed order under Unix. Closes #26759.	2026-07-31 12:45:42 +02:00
Vadim Zeitlin	8b6f8097cf	Use base class IsCurrent() in wxUniv wxVListBox ... Just make the base class function accessible in this class scope, this is better than redefining it and doesn't result in a -Wsuggest-override.	2026-07-31 12:45:42 +02:00
Vadim Zeitlin	af93e02b18	Add missing "override" to wxGLApp::GetXVisualInfo() ... This avoids gcc -Wsuggest-override for it. Always define GetXVisualInfo() in wxGTK wxApp, even for GTK 3, to ensure that this virtual function can be overridden in wxGLApp: this is simpler than overriding it only conditionally there.	2026-07-31 12:45:02 +02:00
Vadim Zeitlin	dfa456f17d	Turn off gcc -Wsuggest-override for wxDFB headers ... There are too many of them and it's probably not worth spending time on fixing them in this not really used port.	2026-07-31 12:45:02 +02:00
Vadim Zeitlin	8327d92835	Add missing "override" to wxX11 and common headers used by wxUniv ... Avoid -Wsuggest-override from gcc.	2026-07-31 12:45:02 +02:00
Vadim Zeitlin	c14b35cafd	Make wxWindow::KillFocus() private and non-virtual in wxX11 ... This is not an overridden base class member function, contrary to what the comment stated.	2026-07-31 12:45:02 +02:00
Steve CornettandVadim Zeitlin	d5aacc4712	Make wxTextCtrl dark mode border consistent with light mode ... For wxTextCtrl, draw a themed border consistent with how the control looks in light mode, and consistent with the WinUI 3 TextBox control in dark mode. A blue line appears at the bottom when the control has the focus. Closes #26745.	2026-07-30 23:57:16 +02:00
PBandVadim Zeitlin	a3d1fef5e6	Use wxIMPLEMENT_APP_CONSOLE() in the archive sample ... Replacing wxIMPLEMENT_APP() with wxIMPLEMENT_APP_CONSOLE() allows building the sample on Windows with CMake with wxWidgets built in the monolithic configuration. The archive sample is a console, not GUI, sample and console applications should use wxIMPLEMENT_APP_CONSOLE() instead of wxIMPLEMENT_APP(). This matters on Windows when compiling with MSVC and the linker subsystem set to console. It can still work when wxUSE_GUI=0 is defined but this is not possible with wxWidgets monolithic build, where wxUSE_GUI=1 is defined for all the projects. Closes #26755.	2026-07-30 19:52:10 +02:00
DanielandVadim Zeitlin	0f8a8d28f4	Fix wxTreeCtrl scrollbar corner colour in wxMSW dark mode ... Extract existing code solving the same problem from wxListCtrl code into a reusable wxMSWImpl::PaintScrollBarCorner() function and use it in wxTreeCtrl too. Fixes #26737. Closes #26743.	2026-07-30 19:29:02 +02:00
Vadim Zeitlin	5e8c5e65d3	Merge branch 'ribbon-colours' ... Fix white pressed-button text becoming illegible in dark ribbon themes. See #26741.	2026-07-30 19:26:19 +02:00
anhnong90andVadim Zeitlin	03f61d05c6	Modernize loops across source files using clang-tidy ... Replace index‑based iteration with C++11 range‑based for loops where appropriate. Closes #26640.	2026-07-30 19:24:25 +02:00
PBandVadim Zeitlin	780eab36dd	Fix a sentence in wxStylusEvent docs ... See #26746.	2026-07-30 19:01:50 +02:00
PBandVadim Zeitlin	eb543bcf61	Clean up the stylus sample ... Prevent the signed/unsigned comparison compiler warning. Remove the unused header. Make the sample follow the wxWidgets coding style standards. Fix the stylus sample in MSVS samples solutions. Closes #26746.	2026-07-30 19:01:25 +02:00
Vadim Zeitlin	09d9aeacaa	Remove implicit conversion of wxColour to GdkRGBA* in wxGTK ... This was dangerous because it allowed the code accidentally dereferencing wxColour to silently compile -- and do a completely wrong thing. Just add a function returning GdkRGBA explicitly and use it. See #26751.	2026-07-30 18:59:47 +02:00
Scott TalbertandVadim Zeitlin	aad79cbf7e	Fix wxList::std test on big endian systems ... Closes #26748.	2026-07-29 20:14:18 +02:00
Vadim Zeitlin	4f31802694	Use SHA-256 checksums for the release files instead of SHA-1 ones ... GitHub automatically computes and shows SHA-256 checksums on the download page, making verifying them more convenient than SHA-1 ones. SHA-1 is also generally considered insecure nowadays. See #26744.	2026-07-29 20:14:18 +02:00
Paul Cornett	74ea434841	Add a function to perform internal processing of wxSysColourChangedEvent ... This avoids the chronic problem of wxSysColourChangedEvent handlers inadvertently failing to call Skip() and thus blocking important internal processing, including propagating to child windows.	2026-07-29 10:56:59 -07:00
Vadim Zeitlin	75a9282598	Fix typo in wxGetContrastingFgColour() ... The code dereferencing wxColour wrongly compiled when using wxGTK due to the existence of operator*() there.	2026-07-29 19:47:29 +02:00
Vadim Zeitlin	c4fe911d19	Link to the current WCAG21 instead of the old 2008 version ... Also update the coefficient in wxGetSRGB() to use the correct value, quoting the linked document: Note 2 Before May 2021 the value of 0.04045 in the definition was different (0.03928). It was taken from an older version of the specification and has been updated. It has no practical effect on the calculations in the context of these guidelines.	2026-07-29 19:36:29 +02:00
Vadim Zeitlin	08ae56c96d	Extract colour-related functions to a reusable header ... Don't duplicate the same code using different names in wxAUI and wxRibbon, put it in a header which can be included from both. No real changes, this is a pure refactoring.	2026-07-29 19:33:42 +02:00
Blake-Madden	d20d50bfbe	Use proper contrast calculation to pick pressed-button label colour ... Uses calculations from AUI.	2026-07-29 08:14:25 -04:00
Blake-Madden	f2685a36e1	Fix white pressed-button text becoming illegible in dark ribbon themes ... Also, refactors duplicate ternary code.	2026-07-26 09:58:36 -04:00
Vadim Zeitlin	0268bc21d1	Update all actions versions in "Create Release" workflow ... Use the newest versions of all actions used here.	2026-07-26 13:59:37 +02:00
Vadim Zeitlin	949a4f9fab	Merge branch 'fix-doxygen-custom-html' ... Fix errors in HTML generated by Doxygen. See #26714. Closes #26716, #26718.	2026-07-26 13:58:16 +02:00
PBandVadim Zeitlin	d35f172262	Update wxApp::SetAppearance() docs ... Update the MSW-related parts after d7d94f9 (Support explicit switching both to and from dark mode in wxMSW, 2026-07-24). Closes #26739. Co-authored-by: Vadim Zeitlin <vadim@wxwidgets.org>	2026-07-26 13:56:52 +02:00
Vadim Zeitlin	965bc69900	Show scroll buttons in wxAuiNotebook when they're needed ... The check for whether these buttons are needed incorrectly compared the width required by tabs with the total rectangle width, but it needs to compare it with the width actually available for the tabs, which can be smaller if other buttons are shown. Closes #26738.	2026-07-25 17:24:29 +02:00
Steve CornettandVadim Zeitlin	a4bedd7396	Fix wxChoice scroll bar after switching to light mode in wxMSW ... Fix wxChoice drop-down list scroll bar when switching to light mode by using "DarkMode_DarkTheme" only for dark mode. Use "Explorer" for light mode. Closes #26736.	2026-07-24 23:41:59 +02:00
Vadim Zeitlin	c831744802	Make wxApp::MSWEnableDarkMode() first parameter an enum ... It was int because the initial plan was to add other flags that could be combined with the existing ones, but now that there are 3 possible values combining the elements of this enum doesn't really make sense any more.	2026-07-24 23:38:15 +02:00
Steve CornettandVadim Zeitlin	d7d94f918d	Support explicit switching both to and from dark mode in wxMSW ... With these changes, wxApp::SetAppearance() and wxApp::MSWEnableDarkMode() can change the dark/light mode at any time. They can be called before or after windows are created, and can be called more than once. The widgets sample has new menu commands to demonstrate this. Closes #26734.	2026-07-24 23:31:50 +02:00
Vadim Zeitlin	e7b0508792	Prefer to test for X11_FOUND rather than its opposite ... No real changes, just make the test added in the parent commit a bit more readable. See #26733.	2026-07-24 17:29:31 +02:00
Carlo BraminiandVadim Zeitlin	70ec9f5b3c	Cmake: Don't use X11 session manager when X11 is not used ... Don't even check for libSM when X11 is not used. Fixes #26691. Closes #26733.	2026-07-24 17:27:36 +02:00