Mirrors_UI_SDK/wxWidgets
1
0
Fork 0
mirror of https://github.com/wxWidgets/wxWidgets.git synced 2026-08-17 17:02:51 +08:00
Code Issues Actions 10 Packages Projects Releases Wiki Activity

Fix incorrect substring size when processing bitmaps.

Browse Source 
Also, use replace Mid() with substr() and use constexpr and preallocate
string memory.
This commit is contained in:
Blake-Madden
2026-04-09 03:00:25 +02:00
committed by Vadim Zeitlin
parent 236e5c2451
commit f1d1678e62
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/common/dcsvg.cpp
+4 -3
View File
@@ -408,6 +408,7 @@ wxSVGBitmapEmbedHandler::ProcessBitmap(const wxBitmap& bmp,
// write image meta information
wxString s;
s.reserve(data.size());
s += wxString::Format(" <image x=\"%d\" y=\"%d\" width=\"%dpx\" height=\"%dpx\"",
x, y, bmp.GetWidth(), bmp.GetHeight());
s += wxString::Format(" id=\"image%d\" "
@@ -415,13 +416,13 @@ wxSVGBitmapEmbedHandler::ProcessBitmap(const wxBitmap& bmp,
sub_images++);
// Wrap Base64 encoded data on 76 columns boundary (same as Inkscape).
const unsigned WRAP = 76;
constexpr unsigned WRAP = 76;
for ( size_t i = 0; i < data.size(); i += WRAP )
{
if (i < data.size() - WRAP)
s += data.Mid(i, WRAP) + "\n";
s += data.substr(i, WRAP) + "\n";
else
s += data.Mid(i, s.size() - i) + "\"\n />\n"; // last line
s += data.substr(i) + "\"\n />\n"; // last line
}
// write to the SVG file