Mirrors_UI_SDK/wxWidgets
1
0
Fork 0
mirror of https://github.com/wxWidgets/wxWidgets.git synced 2026-09-28 15:50:17 +08:00
Code Issues Packages Projects Releases Wiki Activity

Draw hot tracking highlight in MSW wxListCtrl in dark mode

Browse Source 
When the mouse is over an item, change the colour of it.

This only works when using Explorer theme, DarkMode_Explorer does not get custom draw calls to remove the colour.

Fixes #26001
This commit is contained in:
Maarten Bent
2025-11-30 16:10:35 +01:00
parent 10bac0ff4e
commit 47891abefe
1 changed files with 31 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/msw/listctrl.cpp
+31 -17
View File
@@ -615,8 +615,9 @@ bool wxListCtrl::MSWGetDarkModeSupport(MSWDarkModeSupport& support) const
// - "ItemsView" draws the selection and hover as expected, but uses light
// mode scrollbars and also misaligned vertical separators.
//
// We currently use DarkMode_Explorer and override selection drawing.
support.themeName = L"DarkMode_Explorer";
// We currently use Explorer, in Report view we can override all drawing,
// the other views will still have the bluish hover colour.
support.themeName = L"Explorer";
return true;
}
@@ -3338,11 +3339,30 @@ void HandleItemPaint(wxListCtrl* listctrl, LPNMLVCUSTOMDRAW pLVCD)
nmcd.uItemState &= ~CDIS_FOCUS;
}
// determine if the item is hot (mouse hovering over it)
LV_HITTESTINFO lvhti;
wxZeroMemory(lvhti);
wxGetCursorPosMSW(&(lvhti.pt));
::ScreenToClient(GetHwndOf(listctrl), &lvhti.pt);
if ( listctrl->IsEnabled() && ListView_HitTest(GetHwndOf(listctrl), &lvhti) == item )
{
nmcd.uItemState |= CDIS_HOT;
}
else
{
nmcd.uItemState &= ~CDIS_HOT;
}
HDC hdc = nmcd.hdc;
RECT rc = GetCustomDrawnItemRect(nmcd);
COLORREF clrFullBG = wxColourToRGB((nmcd.uItemState & CDIS_SELECTED)
? wxSystemSettings::GetColour(wxSYS_COLOUR_HIGHLIGHT)
: listctrl->GetBackgroundColour());
wxColour clrBg = listctrl->GetBackgroundColour();
if ( nmcd.uItemState & CDIS_SELECTED )
clrBg = wxSystemSettings::GetColour(wxSYS_COLOUR_HIGHLIGHT);
else if ( nmcd.uItemState & CDIS_HOT )
// closest match to colour when hovering over the header (0x434343)
clrBg = wxSystemSettings::GetColour(wxSYS_COLOUR_3DDKSHADOW);
COLORREF clrFullBG = wxColourToRGB(clrBg);
// clear the entire row with the listctrl's bg colour
// otherwise, it'd keep the hover color but only for the regions
@@ -3376,20 +3396,14 @@ void HandleItemPaint(wxListCtrl* listctrl, LPNMLVCUSTOMDRAW pLVCD)
}
HFONT hfont = font.IsOk() ? GetHfontOf(font) : nullptr;
pLVCD->clrText = attr && attr->HasTextColour()
? wxColourToRGB(attr->GetTextColour())
: wxColourToRGB(listctrl->GetTextColour());
pLVCD->clrTextBk = clrFullBG;
if ( nmcd.uItemState & CDIS_SELECTED )
{
pLVCD->clrText = wxColourToRGB(wxSystemSettings::GetColour(wxSYS_COLOUR_HIGHLIGHTTEXT));
pLVCD->clrTextBk = wxColourToRGB(wxSystemSettings::GetColour(wxSYS_COLOUR_HIGHLIGHT));
}
else
{
pLVCD->clrText = attr && attr->HasTextColour()
? wxColourToRGB(attr->GetTextColour())
: wxColourToRGB(listctrl->GetTextColour());
pLVCD->clrTextBk = attr && attr->HasBackgroundColour()
? wxColourToRGB(attr->GetBackgroundColour())
: wxColourToRGB(listctrl->GetBackgroundColour());
}
else if ( !nmcd.uItemState && attr && attr->HasBackgroundColour() )
pLVCD->clrTextBk = wxColourToRGB(attr->GetBackgroundColour());
COLORREF colTextOld = ::SetTextColor(hdc, pLVCD->clrText);