Mirrors_UI_SDK/fltk
1
0
Fork 0
mirror of https://github.com/fltk/fltk.git synced 2026-08-17 08:32:21 +08:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Fix a bogus compiler warning with some compilation flags

Browse Source 
warning: ‘void* memset(void*, int, size_t)’ specified bound
  between 18446743953450467384 and 18446744073709551560 exceeds
  maximum object size 9223372036854775807 [-Wstringop-overflow=]

The solution is using {} to zero-initialize and remove memset().

Also: some minor edits, e.g. making `nc` 'const' where it wasn't.
This commit is contained in:
Albrecht Schlosser
2026-07-16 15:01:47 +02:00
parent 4177a88bdb
commit bb1a8fba1c
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
FL/Fl_Tabs.H
+2 -2
View File
@@ -1,7 +1,7 @@
//
// Tab header file for the Fast Light Tool Kit (FLTK).
//
// Copyright 1998-2023 by Bill Spitzak and others.
// Copyright 1998-2026 by Bill Spitzak and others.
//
// This library is free software. Distribution and use rights are outlined in
// the file "COPYING" which should have been included with this file. If this
@@ -63,7 +63,7 @@ struct Fl_Menu_Item;
be wrapped inside another Fl_Group and inset by five pixels within this
group so the contents of the Fl_Scroll widget are kept away from the tabs
by this amount.
<!-- See GitHub issue #1175. -->
<!-- See GitHub issue # 1175. -->
The background area behind and to the right of the tabs is
"transparent", exposing the background detail of the parent. The
src/Fl_Tabs.cxx
+6 -6
View File
@@ -1,7 +1,7 @@
//
// Tab widget for the Fast Light Tool Kit (FLTK).
//
// Copyright 1998-2023 by Bill Spitzak and others.
// Copyright 1998-2026 by Bill Spitzak and others.
//
// This library is free software. Distribution and use rights are outlined in
// the file "COPYING" which should have been included with this file. If this
@@ -372,7 +372,7 @@ int Fl_Tabs::hit_tabs_area(int event_x, int event_y) {
Check if the tabs overflow and sets the has_overflow_menu flag accordingly.
*/
void Fl_Tabs::check_overflow_menu() {
int nc = children();
const int nc = children();
if (nc == 0) {
has_overflow_menu = 0;
return;
@@ -437,10 +437,11 @@ int Fl_Tabs::maybe_do_callback(Fl_Widget *o) {
The menu item array is then deleted.
*/
void Fl_Tabs::handle_overflow_menu() {
int nc = children();
const int nc = children();
if (nc == 0) return;
int H = tab_height(); if (H < 0) H = -H;
int i, fv=-1, lv=nc; // first and last visible tab
int i; // tab index
int fv = -1, lv = nc; // first and last visible tab
// count visible children
for (i = 0; i < nc; i++) {
@@ -449,8 +450,7 @@ void Fl_Tabs::handle_overflow_menu() {
}
// create a menu with all children
Fl_Menu_Item* overflow_menu = new Fl_Menu_Item[nc+1];
memset(overflow_menu, 0, sizeof(Fl_Menu_Item)*(nc+1));
Fl_Menu_Item* overflow_menu = new Fl_Menu_Item[nc+1]{}; // alloc and zero-init
for (i = 0; i < nc; i++) {
overflow_menu[i].label(child(i)->label());
overflow_menu[i].user_data(child(i));