Mirrors_Framework/rtems
1
0
Fork 0
mirror of https://gitlab.rtems.org/rtems/rtos/rtems.git synced 2026-09-21 13:08:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

posix: Fix _POSIX_signals_Check_signal()

Browse Source 
Do not save and restore the thread wait information.  This is
superfluous and may overwrite thread wait information updates due to
interrupts leading to system corruption.
This commit is contained in:
Sebastian Huber
2016-04-06 09:08:21 +02:00
parent 3c89525608
commit 8b922aafc7
1 changed files with 11 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cpukit/posix/src/psignal.c
+11 -20
View File
@@ -113,10 +113,8 @@ static void _POSIX_signals_Check_signal(
bool is_global
)
{
siginfo_t siginfo_struct;
sigset_t saved_signals_unblocked;
Thread_Wait_information stored_thread_wait_information;
Thread_Control *executing;
siginfo_t siginfo_struct;
sigset_t saved_signals_unblocked;
if ( ! _POSIX_signals_Clear_signals( api, signo, &siginfo_struct,
is_global, true, true ) )
@@ -143,16 +141,6 @@ static void _POSIX_signals_Check_signal(
saved_signals_unblocked = api->signals_unblocked;
api->signals_unblocked &= ~_POSIX_signals_Vectors[ signo ].sa_mask;
executing = _Thread_Get_executing();
/*
* We have to save the blocking information of the current wait queue
* because the signal handler may subsequently go on and put the thread
* on a wait queue, for its own purposes.
*/
memcpy( &stored_thread_wait_information, &executing->Wait,
sizeof( stored_thread_wait_information ));
/*
* Here, the signal handler function executes
*/
@@ -169,12 +157,6 @@ static void _POSIX_signals_Check_signal(
break;
}
/*
* Restore the blocking information
*/
memcpy( &executing->Wait, &stored_thread_wait_information,
sizeof( executing->Wait ));
/*
* Restore the previous set of unblocked signals
*/
@@ -210,6 +192,15 @@ void _POSIX_signals_Action_handler(
if ( !api )
return;
/*
* In case the executing thread is blocked or about to block on something
* that uses the thread wait information, then this is a kernel bug.
*/
_Assert(
( _Thread_Wait_flags_get( executing )
& ( THREAD_WAIT_STATE_BLOCKED | THREAD_WAIT_STATE_INTEND_TO_BLOCK ) ) == 0
);
/*
* If we invoke any user code, there is the possibility that
* a new signal has been posted that we should process so we