Mirrors_Framework/rtems
1
0
Fork 0
mirror of https://gitlab.rtems.org/rtems/rtos/rtems.git synced 2026-08-20 02:32:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

bsp/arm/tms570: use unsigned constants for pin register shifts

Browse Source 
Protect against left-shifting too far into the signed bit which
would be undefined behavior.
This commit is contained in:
Avi Weiss
2026-07-28 08:45:00 -05:00
committed by Kinsey Moore
parent 098ba8472d
commit 5fe4dea4f4
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bsps/arm/tms570/start/pinmux.c
+2 -2
View File
@@ -86,7 +86,7 @@ tms570_bsp_pin_set_function(int pin_num, int pin_fnc)
pin_fnc = (pin_num & TMS570_PIN_FNC_MASK) >> TMS570_PIN_FNC_SHIFT;
}
tms570_bsp_pin_to_pinmmrx(&pinmmrx, &pin_shift, pin_num);
*pinmmrx = (*pinmmrx & ~(0xff << pin_shift)) | (1 << (pin_fnc + pin_shift));
*pinmmrx = (*pinmmrx & ~(0xffU << pin_shift)) | (1U << (pin_fnc + pin_shift));
}
/**
@@ -111,7 +111,7 @@ tms570_bsp_pin_clear_function(int pin_num, int pin_fnc)
pin_fnc = (pin_num & TMS570_PIN_FNC_MASK) >> TMS570_PIN_FNC_SHIFT;
}
tms570_bsp_pin_to_pinmmrx(&pinmmrx, &pin_shift, pin_num);
*pinmmrx = *pinmmrx & ~(1 << (pin_fnc+pin_shift));
*pinmmrx = *pinmmrx & ~(1U << (pin_fnc+pin_shift));
}
/**