Mirrors_Framework/rtems
1
0
Fork 0
mirror of https://gitlab.rtems.org/rtems/rtos/rtems.git synced 2026-09-26 07:15:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

score: Simplify _MRSP_Wait_for_ownership()

Browse Source 
Do not shadow the queue_context parameter with a local variable.  Reuse
the queue context to reduce the required stack space.

This fix relates to a Coverity issue (PW.PARAMETER_HIDDEN).
This commit is contained in:
Sebastian Huber
2021-02-01 06:22:20 +01:00
parent 5dc4f9c7f4
commit 3dcdb9c9e3
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cpukit/include/rtems/score/mrspimpl.h
+6 -7
View File
@@ -367,9 +367,8 @@ RTEMS_INLINE_ROUTINE Status_Control _MRSP_Wait_for_ownership(
if ( status == STATUS_SUCCESSFUL ) {
_MRSP_Replace_priority( mrsp, executing, &ceiling_priority );
} else {
Thread_queue_Context queue_context;
Per_CPU_Control *cpu_self;
int sticky_level_change;
Per_CPU_Control *cpu_self;
int sticky_level_change;
if ( status != STATUS_DEADLOCK ) {
sticky_level_change = -1;
@@ -377,12 +376,12 @@ RTEMS_INLINE_ROUTINE Status_Control _MRSP_Wait_for_ownership(
sticky_level_change = 0;
}
_ISR_lock_ISR_disable( &queue_context.Lock_context.Lock_context );
_MRSP_Remove_priority( executing, &ceiling_priority, &queue_context );
_ISR_lock_ISR_disable( &queue_context->Lock_context.Lock_context );
_MRSP_Remove_priority( executing, &ceiling_priority, queue_context );
cpu_self = _Thread_Dispatch_disable_critical(
&queue_context.Lock_context.Lock_context
&queue_context->Lock_context.Lock_context
);
_ISR_lock_ISR_enable( &queue_context.Lock_context.Lock_context );
_ISR_lock_ISR_enable( &queue_context->Lock_context.Lock_context );
_Thread_Priority_and_sticky_update( executing, sticky_level_change );
_Thread_Dispatch_enable( cpu_self );
}