lwp: copy timeout into kernel space in sys_select()

sys_select() passed the raw user-space timeout pointer straight
through to select(), unlike readfds/writefds/exceptfds which are
all validated with lwp_user_accessable() and copied into kernel
memory first. A malicious or buggy user thread could pass a
timeout pointing at unmapped or otherwise invalid memory, which
select() would then dereference directly (timeout->tv_sec /
timeout->tv_usec) without any check, from kernel context.

Validate and copy it into a kernel-local struct timeval the same
way the fd_set arguments already are, before it reaches select().

Fixes #10298

Signed-off-by: yi chen <94xhn1@gmail.com>
This commit is contained in:
yi chen authored and Rbb666 committed 2026-07-22 21:50:12 +08:00
1 parent 69b66ad411
commit 4fbdf331d1
1 file changed
+12 -1
+12 -1
View File
@@ -970,6 +970,7 @@ sysret_t sys_select(int nfds, fd_set *readfds, fd_set *writefds, fd_set *exceptf
#ifdef ARCH_MM_MMU
int ret = -1;
fd_set *kreadfds = RT_NULL, *kwritefds = RT_NULL, *kexceptfds = RT_NULL;
struct timeval ktimeout, *ptimeout = RT_NULL;
if (readfds)
{
@@ -1016,8 +1017,18 @@ sysret_t sys_select(int nfds, fd_set *readfds, fd_set *writefds, fd_set *exceptf
}
lwp_get_from_user(kexceptfds, exceptfds, sizeof *kexceptfds);
}
if (timeout)
{
if (!lwp_user_accessable((void *)timeout, sizeof *timeout))
{
SET_ERRNO(EFAULT);
goto quit;
}
lwp_get_from_user(&ktimeout, timeout, sizeof ktimeout);
ptimeout = &ktimeout;
}
ret = select(nfds, kreadfds, kwritefds, kexceptfds, timeout);
ret = select(nfds, kreadfds, kwritefds, kexceptfds, ptimeout);
if (kreadfds)
{
lwp_put_to_user(readfds, kreadfds, sizeof *kreadfds);