Mirrors_Framework/nuttx
1
0
Fork 0
mirror of https://github.com/apache/nuttx.git synced 2026-05-23 06:39:01 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

drivers/leds: remove bo_closing as lu_lock can prevent race condition occurs

Browse Source 
remove enter_critical_section

Signed-off-by: fangpeina <fangpeina@xiaomi.com>
This commit is contained in:
fangpeina
2025-06-16 22:13:55 +08:00
committed by Donny(董九柱)
parent a8214b0b1e
commit e44690e22a
1 changed files with 0 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/leds/userled_upper.c
-28
View File
@@ -76,10 +76,6 @@ struct userled_open_s
/* Supports a singly linked list */
FAR struct userled_open_s *bo_flink;
/* The following will be true if we are closing */
volatile bool bo_closing;
};
/****************************************************************************
@@ -174,8 +170,6 @@ static int userled_close(FAR struct file *filep)
FAR struct userled_open_s *opriv;
FAR struct userled_open_s *curr;
FAR struct userled_open_s *prev;
irqstate_t flags;
bool closing;
int ret;
DEBUGASSERT(filep->f_priv);
@@ -184,28 +178,6 @@ static int userled_close(FAR struct file *filep)
DEBUGASSERT(inode->i_private);
priv = inode->i_private;
/* Handle an improbable race conditions with the following atomic test
* and set.
*
* This is actually a pretty feeble attempt to handle this. The
* improbable race condition occurs if two different threads try to
* close the LED driver at the same time. The rule: don't do
* that! It is feeble because we do not really enforce stale pointer
* detection anyway.
*/
flags = enter_critical_section();
closing = opriv->bo_closing;
opriv->bo_closing = true;
leave_critical_section(flags);
if (closing)
{
/* Another thread is doing the close */
return OK;
}
/* Get exclusive access to the driver structure */
ret = nxmutex_lock(&priv->lu_lock);