all: Fix accessing uninitialized local variables

Prior to this commit, in elf_emit() and elf_emit_align(),
ret was uninitialized if total was 0.

Signed-off-by: Mingjie Shen <shen497@purdue.edu>
This commit is contained in:
Mingjie Shen
2024-04-03 14:57:12 -04:00
committed by Xiang Xiao
parent f2082acfd7
commit 99109b8d79
3 changed files with 5 additions and 5 deletions
+2 -2
View File
@@ -2020,8 +2020,8 @@ static int cxd56_set_mic_gains(uint8_t gain, enum cxd56_mic_type_e mic_dev,
static void cxd56_get_mic_config(uint8_t *count, uint8_t *dev, uint8_t *mode) static void cxd56_get_mic_config(uint8_t *count, uint8_t *dev, uint8_t *mode)
{ {
uint8_t i; uint8_t i;
uint8_t is_dmic; bool is_dmic = false;
uint8_t is_amic; bool is_amic = false;
uint8_t mic_sel = 0; uint8_t mic_sel = 0;
uint8_t mic_count = 0; uint8_t mic_count = 0;
+1 -1
View File
@@ -3370,7 +3370,7 @@ static int khci_epconfigure(struct usbdev_ep_s *ep,
uint32_t regval; uint32_t regval;
uint8_t epno; uint8_t epno;
bool epin; bool epin;
bool bidi; bool bidi = false;
int index; int index;
#ifdef CONFIG_DEBUG_FEATURES #ifdef CONFIG_DEBUG_FEATURES
+2 -2
View File
@@ -91,7 +91,7 @@ static int elf_emit(FAR struct elf_dumpinfo_s *cinfo,
{ {
FAR const uint8_t *ptr = buf; FAR const uint8_t *ptr = buf;
size_t total = len; size_t total = len;
int ret; int ret = 0;
while (total > 0) while (total > 0)
{ {
@@ -122,7 +122,7 @@ static int elf_emit_align(FAR struct elf_dumpinfo_s *cinfo)
ELF_PAGESIZE) - cinfo->stream->nput; ELF_PAGESIZE) - cinfo->stream->nput;
unsigned char null[256]; unsigned char null[256];
off_t total = align; off_t total = align;
off_t ret; off_t ret = 0;
memset(null, 0, sizeof(null)); memset(null, 0, sizeof(null));