From 99109b8d79eb35a5fc6d4ffd399895f7355a0cc1 Mon Sep 17 00:00:00 2001 From: Mingjie Shen Date: Wed, 3 Apr 2024 14:57:12 -0400 Subject: [PATCH] all: Fix accessing uninitialized local variables Prior to this commit, in elf_emit() and elf_emit_align(), ret was uninitialized if total was 0. Signed-off-by: Mingjie Shen --- arch/arm/src/cxd56xx/cxd56_nxaudio.c | 4 ++-- arch/arm/src/kinetis/kinetis_usbdev.c | 2 +- binfmt/libelf/libelf_coredump.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/src/cxd56xx/cxd56_nxaudio.c b/arch/arm/src/cxd56xx/cxd56_nxaudio.c index 6551111157b..2831b6e0cf2 100644 --- a/arch/arm/src/cxd56xx/cxd56_nxaudio.c +++ b/arch/arm/src/cxd56xx/cxd56_nxaudio.c @@ -2020,8 +2020,8 @@ static int cxd56_set_mic_gains(uint8_t gain, enum cxd56_mic_type_e mic_dev, static void cxd56_get_mic_config(uint8_t *count, uint8_t *dev, uint8_t *mode) { uint8_t i; - uint8_t is_dmic; - uint8_t is_amic; + bool is_dmic = false; + bool is_amic = false; uint8_t mic_sel = 0; uint8_t mic_count = 0; diff --git a/arch/arm/src/kinetis/kinetis_usbdev.c b/arch/arm/src/kinetis/kinetis_usbdev.c index f60a074651c..ccf5f1ba427 100644 --- a/arch/arm/src/kinetis/kinetis_usbdev.c +++ b/arch/arm/src/kinetis/kinetis_usbdev.c @@ -3370,7 +3370,7 @@ static int khci_epconfigure(struct usbdev_ep_s *ep, uint32_t regval; uint8_t epno; bool epin; - bool bidi; + bool bidi = false; int index; #ifdef CONFIG_DEBUG_FEATURES diff --git a/binfmt/libelf/libelf_coredump.c b/binfmt/libelf/libelf_coredump.c index 868deab9d80..4e3e85783ac 100644 --- a/binfmt/libelf/libelf_coredump.c +++ b/binfmt/libelf/libelf_coredump.c @@ -91,7 +91,7 @@ static int elf_emit(FAR struct elf_dumpinfo_s *cinfo, { FAR const uint8_t *ptr = buf; size_t total = len; - int ret; + int ret = 0; while (total > 0) { @@ -122,7 +122,7 @@ static int elf_emit_align(FAR struct elf_dumpinfo_s *cinfo) ELF_PAGESIZE) - cinfo->stream->nput; unsigned char null[256]; off_t total = align; - off_t ret; + off_t ret = 0; memset(null, 0, sizeof(null));