Mirrors_Framework/nuttx
1
0
Fork 0
mirror of https://github.com/apache/nuttx.git synced 2026-05-25 09:45:55 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

sched/sched/sched_rrgetinterval.c: coverity HIS_metric_violation: RETURN

Browse Source 
Consolidate multiple return statements in sched_rrgetinterval() to reduce
function complexity and comply with MISRA HIS coding standards. This refactoring
maintains functional equivalence while improving code maintainability for
safety-critical embedded systems applications.

Signed-off-by: hujun5 <hujun5@xiaomi.com>
This commit is contained in:
hujun5
2025-08-08 14:33:41 +08:00
committed by Xiang Xiao
parent ce743a22ee
commit 7f167ecc85
1 changed files with 50 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sched/sched/sched_rrgetinterval.c
+50 -46
View File
@@ -70,63 +70,67 @@
int sched_rr_get_interval(pid_t pid, struct timespec *interval)
{
FAR struct tcb_s *rrtcb;
int status = OK;
/* If pid is zero, the timeslice for the calling process is written
* into 'interval.'
*/
if (pid == 0)
if (pid >= 0)
{
rrtcb = this_task();
}
/* Return a special error code on invalid PID */
else if (pid < 0)
{
set_errno(EINVAL);
return ERROR;
}
/* Otherwise, lookup the TCB associated with this PID */
else
{
rrtcb = nxsched_get_tcb(pid);
if (rrtcb == NULL)
if (interval != NULL)
{
set_errno(ESRCH);
return ERROR;
if (pid == 0)
{
rrtcb = this_task();
}
else
{
rrtcb = nxsched_get_tcb(pid);
}
if (rrtcb != NULL)
{
#if CONFIG_RR_INTERVAL > 0
/* The thread has a timeslice ONLY if it is
* configured for round-robin scheduling.
*/
if ((rrtcb->flags & TCB_FLAG_POLICY_MASK) ==
TCB_FLAG_SCHED_RR)
{
/* Convert the timeslice value from ticks to a timespec */
interval->tv_sec = CONFIG_RR_INTERVAL / MSEC_PER_SEC;
interval->tv_nsec = (CONFIG_RR_INTERVAL % MSEC_PER_SEC) *
NSEC_PER_MSEC;
}
else
#endif
{
/* Return {0,0} meaning that the time slice is indefinite */
interval->tv_sec = 0;
interval->tv_nsec = 0;
}
}
else
{
set_errno(ESRCH);
status = ERROR;
}
}
else
{
set_errno(EFAULT);
status = ERROR;
}
}
if (interval == NULL)
{
set_errno(EFAULT);
return ERROR;
}
#if CONFIG_RR_INTERVAL > 0
/* The thread has a timeslice ONLY if it is configured for round-robin
* scheduling.
*/
if ((rrtcb->flags & TCB_FLAG_POLICY_MASK) == TCB_FLAG_SCHED_RR)
{
/* Convert the timeslice value from ticks to a timespec */
interval->tv_sec = CONFIG_RR_INTERVAL / MSEC_PER_SEC;
interval->tv_nsec = (CONFIG_RR_INTERVAL % MSEC_PER_SEC) *
NSEC_PER_MSEC;
}
else
#endif
{
/* Return {0,0} meaning that the time slice is indefinite */
interval->tv_sec = 0;
interval->tv_nsec = 0;
set_errno(EINVAL);
status = ERROR;
}
return OK;
return status;
}