Mirrors_Framework/nuttx
1
0
Fork 0
mirror of https://github.com/apache/nuttx.git synced 2026-05-09 23:12:17 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

clock_settime: don't block when up_rtc_settime is called

Browse Source 
Setting the current time in RTC may be a blocking operation (driver
needs to wait for oscillator stabilization after reset and so on).
This may cause the unwanted effect of clock_settime blocking the
code execution for a considerable amount of time.

The solution is to plan a low priority work that takes care
of setting the time in RTC and let clock_settime continue. We don't
have to check if the work is available, just cancel it if there
is a new time set request.

This is used only if CONFIG_SCHED_LPWORK is enabled.

Signed-off-by: Michal Lenc <michallenc@seznam.cz>
This commit is contained in:
Michal Lenc
2026-04-28 11:34:16 +02:00
committed by Matteo Golin
parent 369755d00b
commit 7dc6be8f08
1 changed files with 29 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sched/clock/clock_settime.c
+29
View File
@@ -44,10 +44,22 @@
# include "clock/clock_timekeeping.h"
#endif
#if defined(CONFIG_RTC) && defined(CONFIG_SCHED_LPWORK)
static struct work_s g_rtc_work;
static struct timespec g_rtc_to_set;
#endif
/****************************************************************************
* Private Functions
****************************************************************************/
#if defined(CONFIG_RTC) && defined(CONFIG_SCHED_LPWORK)
static void rtc_worker(FAR void *arg)
{
up_rtc_settime(arg);
}
#endif
static void nxclock_set_realtime(FAR const struct timespec *tp)
{
#ifndef CONFIG_CLOCK_TIMEKEEPING
@@ -82,7 +94,24 @@ static void nxclock_set_realtime(FAR const struct timespec *tp)
# ifdef CONFIG_RTC
if (g_rtc_enabled)
{
# ifdef CONFIG_SCHED_LPWORK
/* Setting the current time in RTC may be a blocking operation (driver
* needs to wait for oscillator stabilization after reset and so on).
* This may cause the unwanted effect of clock_settime blocking the
* code execution for a considerable amount of time.
*
* The solution is to plan a low priority work that takes care
* of setting the time in RTC and let clock_settime continue. We don't
* have to check if the work is available, just cancel it if there
* is a new time set request.
*/
g_rtc_to_set = *tp;
work_queue(LPWORK, &g_rtc_work, rtc_worker,
(FAR void *)&g_rtc_to_set, 0);
# else
up_rtc_settime(tp);
# endif
}
# endif