Mirrors_Framework/nuttx
1
0
Fork 0
mirror of https://github.com/apache/nuttx.git synced 2026-09-22 06:04:28 +08:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

sem_trywait.c: coverity HIS_metric_violation(HIS_GOTO)

Browse Source 
Refactor sem_trywait.c to replace goto statements with structured control
flow to comply with MISRA HIS coding standards. This improves code clarity
and maintainability while preserving all functional behavior and performance
characteristics.

Signed-off-by: hujun5 <hujun5@xiaomi.com>
This commit is contained in:
hujun5
2026-01-27 14:29:33 -03:00
committed by Alan C. Assis
parent 922426346e
commit 49cb8e08e6
1 changed files with 23 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sched/semaphore/sem_trywait.c
+23 -20
View File
@@ -84,7 +84,8 @@ int nxsem_trywait_slow(FAR sem_t *sem)
{
if (NXSEM_MACQUIRED(old))
{
goto out;
ret = -EAGAIN;
break;
}
new = nxsched_gettid();
@@ -93,7 +94,8 @@ int nxsem_trywait_slow(FAR sem_t *sem)
{
if (old <= 0)
{
goto out;
ret = -EAGAIN;
break;
}
new = old - 1;
@@ -101,31 +103,32 @@ int nxsem_trywait_slow(FAR sem_t *sem)
}
while (!atomic_try_cmpxchg_acquire(val, &old, new));
/* It is, let the task take the semaphore */
#ifdef CONFIG_PRIORITY_PROTECT
ret = nxsem_protect_wait(sem);
if (ret < 0)
if (ret != -EAGAIN)
{
if (mutex)
/* It is, let the task take the semaphore */
#ifdef CONFIG_PRIORITY_PROTECT
ret = nxsem_protect_wait(sem);
if (ret < 0)
{
atomic_set(NXSEM_MHOLDER(sem), NXSEM_NO_MHOLDER);
if (mutex)
{
atomic_set(NXSEM_MHOLDER(sem), NXSEM_NO_MHOLDER);
}
else
{
atomic_fetch_add(NXSEM_COUNT(sem), 1);
}
}
else
#endif
{
atomic_fetch_add(NXSEM_COUNT(sem), 1);
if (!mutex)
{
nxsem_add_holder(sem);
}
}
goto out;
}
#endif
if (!mutex)
{
nxsem_add_holder(sem);
}
out:
/* Interrupts may now be enabled. */