Mirrors_Framework/nuttx
1
0
Fork 0
mirror of https://github.com/apache/nuttx.git synced 2026-06-04 06:42:32 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

drivers/lcd: lcd_framebuffer.c does not need to include board-specific board.h.

Browse Source
This commit is contained in:
Gregory Nutt
2018-02-15 09:17:27 -06:00
parent 7062ca2c03
commit 46e5f292dd
2 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Documentation/NuttxPortingGuide.html
+1 -1
View File
@@ -1586,7 +1586,7 @@ The specific environmental definitions are unique for each board but should incl
Keeping in the spirit of the layered architecture, these publicly visible header files must <i>not</i> export platform-specific definitions; Only platform-specific realizations of standardized declarations should be visible. Keeping in the spirit of the layered architecture, these publicly visible header files must <i>not</i> export platform-specific definitions; Only platform-specific realizations of standardized declarations should be visible.
Those <i>standardized declarations</i> should appear in common header files such as those provided by <code>include/nuttx/arch.h</code> and <code>include/nuttx/board.h</code>. Those <i>standardized declarations</i> should appear in common header files such as those provided by <code>include/nuttx/arch.h</code> and <code>include/nuttx/board.h</code>.
Similarly, these publicly visible header file must <i>not</i> include files that reside in the inaccessible platform-specific source directories. Similarly, these publicly visible header file must <i>not</i> include files that reside in the inaccessible platform-specific source directories.
For example, the board-specific <code>configs/&lt;board&gt;/include/board.h</code> header file must never include microcontroller-specific header files that reside in <code>arch/&lt;arch&gt;/src/</code>. For example, the board-specific <code>configs/&lt;board&gt;/include/board.h</code> header file must never include microcontroller-specific header files that reside in <code>arch/&lt;arch&gt;/src/&lt;mcu&gt;</code>.
That practice will cause inclusion failures when the publicly visible file is included in common logic outside of the platform-specific source directories. That practice will cause inclusion failures when the publicly visible file is included in common logic outside of the platform-specific source directories.
</p> </p>
</li> </li>
drivers/lcd/lcd_framebuffer.c
-1
View File
@@ -51,7 +51,6 @@
#include <nuttx/nx/nxglib.h> #include <nuttx/nx/nxglib.h>
#include <nuttx/lcd/lcd.h> #include <nuttx/lcd/lcd.h>
#include <nuttx/video/fb.h> #include <nuttx/video/fb.h>
#include <arch/board/board.h>
#ifdef CONFIG_LCD_FRAMEBUFFER #ifdef CONFIG_LCD_FRAMEBUFFER