From 46e5f292dd3a65a2432669e7b44b6189130b573b Mon Sep 17 00:00:00 2001 From: Gregory Nutt Date: Thu, 15 Feb 2018 09:17:27 -0600 Subject: [PATCH] drivers/lcd: lcd_framebuffer.c does not need to include board-specific board.h. --- Documentation/NuttxPortingGuide.html | 2 +- drivers/lcd/lcd_framebuffer.c | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/Documentation/NuttxPortingGuide.html b/Documentation/NuttxPortingGuide.html index 7aeb146db10..016d43a9cd7 100644 --- a/Documentation/NuttxPortingGuide.html +++ b/Documentation/NuttxPortingGuide.html @@ -1586,7 +1586,7 @@ The specific environmental definitions are unique for each board but should incl Keeping in the spirit of the layered architecture, these publicly visible header files must not export platform-specific definitions; Only platform-specific realizations of standardized declarations should be visible. Those standardized declarations should appear in common header files such as those provided by include/nuttx/arch.h and include/nuttx/board.h. Similarly, these publicly visible header file must not include files that reside in the inaccessible platform-specific source directories. - For example, the board-specific configs/<board>/include/board.h header file must never include microcontroller-specific header files that reside in arch/<arch>/src/. + For example, the board-specific configs/<board>/include/board.h header file must never include microcontroller-specific header files that reside in arch/<arch>/src/<mcu>. That practice will cause inclusion failures when the publicly visible file is included in common logic outside of the platform-specific source directories.

diff --git a/drivers/lcd/lcd_framebuffer.c b/drivers/lcd/lcd_framebuffer.c index db9c27ffaa4..b97b10d25ed 100644 --- a/drivers/lcd/lcd_framebuffer.c +++ b/drivers/lcd/lcd_framebuffer.c @@ -51,7 +51,6 @@ #include #include #include -#include #ifdef CONFIG_LCD_FRAMEBUFFER