Mirrors_Framework/nuttx
1
0
Fork 0
mirror of https://github.com/apache/nuttx.git synced 2026-05-22 05:42:05 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

sched_setpriority.c: coverity HIS_metric_violation: RETURN

Browse Source 
This change consolidates multiple return statements in nxsched_set_priority()
into a single exit point to reduce cyclomatic complexity and comply with MISRA
HIS coding standards for safety-critical embedded systems.

Signed-off-by: hujun5 <hujun5@xiaomi.com>
This commit is contained in:
hujun5
2026-01-28 10:26:02 +08:00
committed by Xiang Xiao
parent fee69a2046
commit 2860333552
1 changed files with 36 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sched/sched/sched_setpriority.c
+36 -32
View File
@@ -262,52 +262,56 @@ static inline void nxsched_blocked_setpriority(FAR struct tcb_s *tcb,
int nxsched_set_priority(FAR struct tcb_s *tcb, int sched_priority)
{
irqstate_t flags;
int ret = OK;
/* Verify that the requested priority is in the valid range */
if (sched_priority < SCHED_PRIORITY_MIN ||
sched_priority > SCHED_PRIORITY_MAX)
{
return -EINVAL;
ret = -EINVAL;
}
/* We need to assure that there there is no interrupt activity while
* performing the following.
*/
flags = enter_critical_section();
/* There are three major cases (and two sub-cases) that must be
* considered:
*/
switch (tcb->task_state)
else
{
/* CASE 1. The task is running and a context switch may be caused by
* the re-prioritization
/* We need to assure that there there is no interrupt activity while
* performing the following.
*/
case TSTATE_TASK_RUNNING:
nxsched_running_setpriority(tcb, sched_priority);
break;
flags = enter_critical_section();
/* CASE 2. The task is ready-to-run (but not running) and a context
* switch may be caused by the re-prioritization
/* There are three major cases (and two sub-cases) that must be
* considered:
*/
case TSTATE_TASK_READYTORUN:
nxsched_readytorun_setpriority(tcb, sched_priority);
break;
switch (tcb->task_state)
{
/* CASE 1. The task is running and a context switch may be caused
* by the re-prioritization
*/
/* CASE 3. The task is not in the ready to run list. Changing its
* Priority cannot effect the currently executing task.
*/
case TSTATE_TASK_RUNNING:
nxsched_running_setpriority(tcb, sched_priority);
break;
default:
nxsched_blocked_setpriority(tcb, sched_priority);
break;
}
/* CASE 2. The task is ready-to-run (but not running) and a context
* switch may be caused by the re-prioritization
*/
leave_critical_section(flags);
return OK;
case TSTATE_TASK_READYTORUN:
nxsched_readytorun_setpriority(tcb, sched_priority);
break;
/* CASE 3. The task is not in the ready to run list. Changing its
* Priority cannot effect the currently executing task.
*/
default:
nxsched_blocked_setpriority(tcb, sched_priority);
break;
}
leave_critical_section(flags);
}
return ret;
}