Mirrors_Framework/nuttx
1
0
Fork 0
mirror of https://github.com/apache/nuttx.git synced 2026-05-12 01:42:49 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

drivers/analog/mcp47x6: fix configuration command

Browse Source 
Previously the ioctl-based configuration was not encoded properly.
It lacked the three command bits selecting the "set volatile
configuration" mode.
Thus, configuration the reference, power-down or gain resulted in no
change.

Now the configuration is properly applied.

The DAC value to be send is now combined with the proper command prefix
bits, too.
But this operation was already working, since the command prefix is zero.

Signed-off-by: Lars Kruse <devel@sumpfralle.de>
This commit is contained in:
Lars Kruse
2026-01-21 12:16:15 +01:00
committed by GUIDINGLI
parent 34d3b06955
commit 21c19b7824
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/analog/mcp47x6.c
+3 -2
View File
@@ -305,7 +305,7 @@ static int mcp47x6_send(FAR struct dac_dev_s *dev, FAR struct dac_msg_s *msg)
uint32_t data;
data = msg->am_data & MCP47X6_DATA_MASK;
data <<= MCP47X6_DATA_SHIFT;
buffer[0] = (uint8_t)(data >> 8);
buffer[0] = (uint8_t)(data >> 8) | MCP47X6_COMMAND_WRITE_DAC;
buffer[1] = (uint8_t)(data);
ret = mcp47x6_i2c_write(priv, buffer, sizeof(buffer));
@@ -396,7 +396,8 @@ static int mcp47x6_ioctl(FAR struct dac_dev_s *dev, int cmd,
if (command_prepared)
{
ret = mcp47x6_i2c_write(priv, &priv->cmd, sizeof(priv->cmd));
uint8_t raw_cmd = MCP47X6_COMMAND_WRITE_CONFIG | priv->cmd;
ret = mcp47x6_i2c_write(priv, &raw_cmd, sizeof(raw_cmd));
}
return ret;