Mirrors_Framework/nuttx
1
0
Fork 0
mirror of https://github.com/apache/nuttx.git synced 2026-09-21 13:25:12 +08:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

sched_sysinfo.c: coverity HIS_metric_violation: RETURN

Browse Source 
This change consolidates multiple return statements in the sysinfo() function
into a single exit point and inverts the error condition to improve code structure
and comply with MISRA HIS coding standards for safety-critical systems.

Signed-off-by: hujun5 <hujun5@xiaomi.com>
This commit is contained in:
hujun5
2026-01-31 02:53:58 +08:00
committed by Xiang Xiao
parent f375093a25
commit 1900d4c8fb
1 changed files with 33 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sched/sched/sched_sysinfo.c
+33 -30
View File
@@ -62,55 +62,58 @@ int sysinfo(FAR struct sysinfo *info)
#if defined(MM_KERNEL_USRHEAP_INIT) || defined(CONFIG_MM_KERNEL_HEAP)
struct mallinfo minfo;
#endif
int ret = OK;
if (info == NULL)
if (info != NULL)
{
set_errno(EINVAL);
return -1;
}
memset(info, 0, sizeof(*info));
memset(info, 0, sizeof(*info));
#ifndef CONFIG_SCHED_CPULOAD_NONE
clock_cpuload(0, &cpuload);
clock_cpuload(0, &cpuload);
/* On the simulator, you may hit cpuload.total == 0, but probably never
* on real hardware.
*/
/* On the simulator, you may hit cpuload.total == 0, but probably never
* on real hardware.
*/
if (cpuload.total)
{
info->loads[0] = ((cpuload.total - cpuload.active) <<
SI_LOAD_SHIFT) / cpuload.total;
info->loads[1] = info->loads[0];
info->loads[2] = info->loads[0];
}
if (cpuload.total)
{
info->loads[0] = ((cpuload.total - cpuload.active) <<
SI_LOAD_SHIFT) / cpuload.total;
info->loads[1] = info->loads[0];
info->loads[2] = info->loads[0];
}
#endif
#ifdef MM_KERNEL_USRHEAP_INIT
minfo = kumm_mallinfo();
minfo = kumm_mallinfo();
info->totalram += minfo.arena;
info->freeram += minfo.fordblks;
info->totalram += minfo.arena;
info->freeram += minfo.fordblks;
#endif
#ifdef CONFIG_MM_KERNEL_HEAP
minfo = kmm_mallinfo();
minfo = kmm_mallinfo();
info->totalram += minfo.arena;
info->freeram += minfo.fordblks;
info->totalram += minfo.arena;
info->freeram += minfo.fordblks;
#endif
#ifdef CONFIG_MM_PGALLOC
mm_pginfo(&pginfo);
mm_pginfo(&pginfo);
info->totalram += pginfo.ntotal << MM_PGSHIFT;
info->freeram += pginfo.nfree << MM_PGSHIFT;
info->totalram += pginfo.ntotal << MM_PGSHIFT;
info->freeram += pginfo.nfree << MM_PGSHIFT;
#endif
info->uptime = TICK2SEC(clock_systime_ticks());
info->procs = CONFIG_SMP_NCPUS;
info->mem_unit = 1;
info->uptime = TICK2SEC(clock_systime_ticks());
info->procs = CONFIG_SMP_NCPUS;
info->mem_unit = 1;
}
else
{
set_errno(EINVAL);
ret = -1;
}
return 0;
return ret;
}