checkstack: fix access overflow when checkstack

We should check length first, and then check the value

Signed-off-by: ligd <liguiding1@xiaomi.com>

arch/arm/src/common/arm_checkstack.c

@@ -119,7 +119,7 @@ size_t arm_stack_check(void *stackbase, size_t nbytes)
    */
 
   for (ptr = (uint32_t *)start, mark = (nbytes >> 2);
-       *ptr == STACK_COLOR && mark > 0;
+       mark > 0 && *ptr == STACK_COLOR;
        ptr++, mark--);
 
   /* If the stack is completely used, then this might mean that the stack

arch/arm64/src/common/arm64_checkstack.c

@@ -101,7 +101,7 @@ size_t arm64_stack_check(void *stackbase, size_t nbytes)
    */
 
   for (ptr = (uint32_t *)start, mark = (nbytes >> 2);
-       *ptr == STACK_COLOR && mark > 0;
+       mark > 0 && *ptr == STACK_COLOR;
        ptr++, mark--);
 
   /* If the stack is completely used, then this might mean that the stack

arch/avr/src/avr/avr_checkstack.c

@@ -108,7 +108,7 @@ size_t avr_stack_check(uintptr_t alloc, size_t size)
    */
 
   for (ptr = (FAR uint8_t *)alloc, mark = size;
-       *ptr == STACK_COLOR && mark > 0;
+       mark > 0 && *ptr == STACK_COLOR;
        ptr++, mark--);
 
   /* If the stack is completely used, then this might mean that the stack

arch/ceva/src/common/ceva_checkstack.c

@@ -100,7 +100,7 @@ size_t ceva_stack_check(uintptr_t alloc, size_t size)
    */
 
   for (ptr = (uint32_t *)alloc, mark = nwords;
-       *ptr == STACK_COLOR && mark > 0;
+       mark > 0 && *ptr == STACK_COLOR;
        ptr++, mark--);
 
   /* If the stack is completely used, then this might mean that the stack

arch/or1k/src/common/or1k_checkstack.c

@@ -115,7 +115,7 @@ size_t or1k_stack_check(uintptr_t alloc, size_t size)
   size  = end - start;
 
   for (ptr = (uint32_t *)start, mark = (size >> 2);
-       *ptr == STACK_COLOR && mark > 0;
+       mark > 0 && *ptr == STACK_COLOR;
        ptr++, mark--);
 
   /* Return our guess about how much stack space was used */

arch/risc-v/src/common/riscv_checkstack.c

@@ -117,7 +117,7 @@ size_t riscv_stack_check(uintptr_t alloc, size_t size)
    */
 
   for (ptr = (uint32_t *)start, mark = (size >> 2);
-       *ptr == STACK_COLOR && mark > 0;
+       mark > 0 && *ptr == STACK_COLOR;
        ptr++, mark--);
 
   /* If the stack is completely used, then this might mean that the stack

arch/sim/src/sim/sim_checkstack.c

@@ -91,7 +91,7 @@ size_t sim_stack_check(void *alloc, size_t size)
    */
 
   for (ptr = (uint32_t *)start, mark = (size >> 2);
-       *ptr == STACK_COLOR && mark > 0;
+       mark > 0 && *ptr == STACK_COLOR;
        ptr++, mark--);
 
   /* If the stack is completely used, then this might mean that the stack

arch/sparc/src/common/sparc_checkstack.c

@@ -115,7 +115,7 @@ size_t sparc_stack_check(void *stackbase, size_t nbytes)
    */
 
   for (ptr = (uint32_t *)start, mark = (nbytes >> 2);
-       *ptr == STACK_COLOR && mark > 0;
+       mark > 0 && *ptr == STACK_COLOR;
        ptr++, mark--);
 
   /* If the stack is completely used, then this might mean that the stack

arch/tricore/src/common/tricore_checkstack.c

@@ -93,7 +93,7 @@ size_t tricore_stack_check(uintptr_t alloc, size_t size)
    */
 
   for (ptr = (uint32_t *)start, mark = (size >> 2);
-       *ptr == STACK_COLOR && mark > 0;
+       mark > 0 && *ptr == STACK_COLOR;
        ptr++, mark--);
 
   /* Return our guess about how much stack space was used */

arch/x86_64/src/intel64/intel64_checkstack.c

@@ -86,7 +86,7 @@ size_t x86_64_stack_check(void *stackbase, size_t nbytes)
    */
 
   for (ptr = (uint32_t *)start, mark = (nbytes >> 2);
-       *ptr == STACK_COLOR && mark > 0;
+       mark > 0 && *ptr == STACK_COLOR;
        ptr++, mark--);
 
   /* Return our guess about how much stack space was used */

arch/xtensa/src/common/xtensa_checkstack.c

@@ -116,7 +116,7 @@ size_t xtensa_stack_check(uintptr_t alloc, size_t size)
    */
 
   for (ptr = (uint32_t *)start, mark = (size >> 2);
-       *ptr == STACK_COLOR && mark > 0;
+       mark > 0 && *ptr == STACK_COLOR;
        ptr++, mark--);
 
   /* If the stack is completely used, then this might mean that the stack