Mirrors_Framework/mosquitto
1
0
Fork 0
mirror of https://github.com/eclipse-mosquitto/mosquitto.git synced 2026-03-27 09:33:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

dynsec: don't leave in partial state on error

Browse Source
This commit is contained in:
Roger A. Light
2022-08-04 19:16:30 +01:00
parent 9b04d0dd36
commit e5d6bbb907
1 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
plugins/dynamic-security/rolelist.c
View File

@@ -147,7 +147,12 @@ int dynsec_rolelist__client_add(struct dynsec__client *client, struct dynsec__ro
return MOSQ_ERR_UNKNOWN;
}
return dynsec_clientlist__add(&role->clientlist, client, priority);
rc = dynsec_clientlist__add(&role->clientlist, client, priority);
if(rc){
dynsec_rolelist__remove_role(&client->rolelist, role);
}
return rc;
}
@@ -158,7 +163,11 @@ int dynsec_rolelist__group_add(struct dynsec__group *group, struct dynsec__role
rc = dynsec_rolelist__add(&group->rolelist, role, priority);
if(rc) return rc;
return dynsec_grouplist__add(&role->grouplist, group, priority);
rc = dynsec_grouplist__add(&role->grouplist, group, priority);
if(rc){
dynsec_rolelist__remove_role(&group->rolelist, role);
}
return rc;
}