GP-0: Fix javadoc warnings.

This commit is contained in:
Dan
2025-01-06 09:50:09 -05:00
parent 51a236b36d
commit afa673fed0
73 changed files with 25 additions and 138 deletions
@@ -322,8 +322,8 @@ public class JitDataFlowModel {
/**
* An upward graph traversal for collecting all values in the use-def graph.
*
* @see JitAnalysisContext#allValues()
* @see JitAnalysisContext#allValuesSorted()
* @see #allValues()
* @see #allValuesSorted()
*/
protected class ValCollector extends HashSet<JitVal> implements JitOpUpwardVisitor {
public ValCollector() {
@@ -479,7 +479,7 @@ public class JitDataFlowModel {
* NOTE: This is only as complete as it needed to be for me to diagnose whatever issue I was
* having at the time.
*
* @see JitAnalysisContext#exportGraphviz(File)
* @see #exportGraphviz(File)
*/
protected class GraphvizExporter implements JitOpUpwardVisitor {
final PrintWriter out;
@@ -22,7 +22,7 @@ import ghidra.pcode.emu.jit.gen.tgt.JitCompiledPassage;
/**
* A field request for a pre-fetched or pre-constructed element
*/
interface FieldReq {
public interface FieldReq {
/**
* Derive a suitable name for the field
*
@@ -21,7 +21,7 @@ import org.objectweb.asm.MethodVisitor;
/**
* An instance field request initialized in the class constructor
*/
interface InstanceFieldReq extends FieldReq {
public interface InstanceFieldReq extends FieldReq {
/**
* Emit the field declaration and its initialization bytecode
*
@@ -21,13 +21,13 @@ import org.objectweb.asm.MethodVisitor;
/**
* A static field request initialized in the class initializer
*/
interface StaticFieldReq extends FieldReq {
public interface StaticFieldReq extends FieldReq {
/**
* Emit the field declaration and its initialization bytecode
*
* <p>
* The declaration is emitted into the class definition, and the initialization code is
* emitted into the class initializer.
* The declaration is emitted into the class definition, and the initialization code is emitted
* into the class initializer.
*
* @param gen the code generator
* @param cv the visitor for the class definition
@@ -16,8 +16,6 @@
package ghidra.pcode.emu.jit.gen.op;
import static ghidra.lifecycle.Unfinished.TODO;
import static org.objectweb.asm.Opcodes.ILOAD;
import static org.objectweb.asm.Opcodes.ISTORE;
import org.objectweb.asm.*;
@@ -15,9 +15,6 @@
*/
package ghidra.pcode.emu.jit.gen.op;
import static org.objectweb.asm.Opcodes.IAND;
import static org.objectweb.asm.Opcodes.LAND;
import ghidra.pcode.emu.jit.op.JitBoolAndOp;
import ghidra.pcode.opbehavior.OpBehaviorBoolAnd;
@@ -15,9 +15,6 @@
*/
package ghidra.pcode.emu.jit.gen.op;
import static org.objectweb.asm.Opcodes.IXOR;
import static org.objectweb.asm.Opcodes.LXOR;
import org.objectweb.asm.MethodVisitor;
import ghidra.lifecycle.Unfinished;
@@ -15,9 +15,6 @@
*/
package ghidra.pcode.emu.jit.gen.op;
import static org.objectweb.asm.Opcodes.IOR;
import static org.objectweb.asm.Opcodes.LOR;
import ghidra.pcode.emu.jit.op.JitBoolOrOp;
import ghidra.pcode.opbehavior.OpBehaviorBoolOr;
@@ -15,9 +15,6 @@
*/
package ghidra.pcode.emu.jit.gen.op;
import static org.objectweb.asm.Opcodes.IXOR;
import static org.objectweb.asm.Opcodes.LXOR;
import ghidra.pcode.emu.jit.op.JitBoolXorOp;
import ghidra.pcode.opbehavior.OpBehaviorBoolXor;
@@ -15,16 +15,13 @@
*/
package ghidra.pcode.emu.jit.gen.op;
import static org.objectweb.asm.Opcodes.ACONST_NULL;
import static org.objectweb.asm.Opcodes.ARETURN;
import org.objectweb.asm.MethodVisitor;
import ghidra.pcode.emu.jit.JitPcodeThread;
import ghidra.pcode.emu.jit.analysis.JitControlFlowModel.JitBlock;
import ghidra.pcode.emu.jit.analysis.JitType;
import ghidra.pcode.emu.jit.analysis.JitType.LongJitType;
import ghidra.pcode.emu.jit.gen.*;
import ghidra.pcode.emu.jit.gen.JitCodeGenerator;
import ghidra.pcode.emu.jit.gen.type.TypeConversions;
import ghidra.pcode.emu.jit.op.JitBranchIndOp;
@@ -17,7 +17,6 @@ package ghidra.pcode.emu.jit.gen.op;
import static ghidra.pcode.emu.jit.gen.GenConsts.MDESC_JIT_COMPILED_PASSAGE__GET_CHAINED;
import static ghidra.pcode.emu.jit.gen.GenConsts.NAME_JIT_COMPILED_PASSAGE;
import static org.objectweb.asm.Opcodes.*;
import org.objectweb.asm.Label;
import org.objectweb.asm.MethodVisitor;
@@ -25,7 +24,8 @@ import org.objectweb.asm.MethodVisitor;
import ghidra.pcode.emu.jit.JitPassage.*;
import ghidra.pcode.emu.jit.JitPcodeThread;
import ghidra.pcode.emu.jit.analysis.JitControlFlowModel.JitBlock;
import ghidra.pcode.emu.jit.gen.*;
import ghidra.pcode.emu.jit.gen.FieldForExitSlot;
import ghidra.pcode.emu.jit.gen.JitCodeGenerator;
import ghidra.pcode.emu.jit.gen.tgt.JitCompiledPassage;
import ghidra.pcode.emu.jit.gen.var.VarGen;
import ghidra.pcode.emu.jit.op.JitBranchOp;
@@ -15,8 +15,6 @@
*/
package ghidra.pcode.emu.jit.gen.op;
import static org.objectweb.asm.Opcodes.*;
import org.objectweb.asm.Label;
import org.objectweb.asm.MethodVisitor;
@@ -24,7 +22,7 @@ import ghidra.pcode.emu.jit.JitPassage.ExtBranch;
import ghidra.pcode.emu.jit.JitPassage.IntBranch;
import ghidra.pcode.emu.jit.analysis.JitControlFlowModel.JitBlock;
import ghidra.pcode.emu.jit.analysis.JitType;
import ghidra.pcode.emu.jit.gen.*;
import ghidra.pcode.emu.jit.gen.JitCodeGenerator;
import ghidra.pcode.emu.jit.gen.type.TypeConversions;
import ghidra.pcode.emu.jit.gen.var.VarGen;
import ghidra.pcode.emu.jit.gen.var.VarGen.BlockTransition;
@@ -17,7 +17,6 @@ package ghidra.pcode.emu.jit.gen.op;
import static ghidra.pcode.emu.jit.gen.GenConsts.MDESC_SLEIGH_LINK_EXCEPTION__$INIT;
import static ghidra.pcode.emu.jit.gen.GenConsts.NAME_SLEIGH_LINK_EXCEPTION;
import static org.objectweb.asm.Opcodes.*;
import org.objectweb.asm.MethodVisitor;
@@ -16,7 +16,6 @@
package ghidra.pcode.emu.jit.gen.op;
import static ghidra.pcode.emu.jit.gen.GenConsts.*;
import static org.objectweb.asm.Opcodes.*;
import java.lang.reflect.Method;
import java.lang.reflect.Parameter;
@@ -15,8 +15,6 @@
*/
package ghidra.pcode.emu.jit.gen.op;
import static org.objectweb.asm.Opcodes.GOTO;
import org.objectweb.asm.Label;
import org.objectweb.asm.MethodVisitor;
@@ -16,7 +16,6 @@
package ghidra.pcode.emu.jit.gen.op;
import static ghidra.pcode.emu.jit.gen.GenConsts.*;
import static org.objectweb.asm.Opcodes.*;
import org.objectweb.asm.Label;
import org.objectweb.asm.MethodVisitor;
@@ -18,8 +18,8 @@ package ghidra.pcode.emu.jit.gen.op;
import org.objectweb.asm.MethodVisitor;
import ghidra.pcode.emu.jit.analysis.JitControlFlowModel.JitBlock;
import ghidra.pcode.emu.jit.gen.JitCodeGenerator;
import ghidra.pcode.emu.jit.analysis.JitType;
import ghidra.pcode.emu.jit.gen.JitCodeGenerator;
import ghidra.pcode.emu.jit.op.JitCopyOp;
/**
@@ -17,7 +17,6 @@ package ghidra.pcode.emu.jit.gen.op;
import static ghidra.lifecycle.Unfinished.TODO;
import static ghidra.pcode.emu.jit.gen.GenConsts.*;
import static org.objectweb.asm.Opcodes.INVOKESTATIC;
import org.objectweb.asm.MethodVisitor;
@@ -16,8 +16,6 @@
package ghidra.pcode.emu.jit.gen.op;
import static ghidra.lifecycle.Unfinished.TODO;
import static org.objectweb.asm.Opcodes.DADD;
import static org.objectweb.asm.Opcodes.FADD;
import org.objectweb.asm.MethodVisitor;
@@ -18,7 +18,6 @@ package ghidra.pcode.emu.jit.gen.op;
import static ghidra.lifecycle.Unfinished.TODO;
import static ghidra.pcode.emu.jit.gen.GenConsts.MDESC_$DOUBLE_UNOP;
import static ghidra.pcode.emu.jit.gen.GenConsts.NAME_MATH;
import static org.objectweb.asm.Opcodes.*;
import org.objectweb.asm.MethodVisitor;
@@ -16,8 +16,6 @@
package ghidra.pcode.emu.jit.gen.op;
import static ghidra.lifecycle.Unfinished.TODO;
import static org.objectweb.asm.Opcodes.DDIV;
import static org.objectweb.asm.Opcodes.FDIV;
import org.objectweb.asm.MethodVisitor;
@@ -15,8 +15,6 @@
*/
package ghidra.pcode.emu.jit.gen.op;
import static org.objectweb.asm.Opcodes.*;
import ghidra.pcode.emu.jit.op.JitFloatEqualOp;
/**
@@ -16,8 +16,6 @@
package ghidra.pcode.emu.jit.gen.op;
import static ghidra.lifecycle.Unfinished.TODO;
import static org.objectweb.asm.Opcodes.D2F;
import static org.objectweb.asm.Opcodes.F2D;
import org.objectweb.asm.MethodVisitor;
@@ -18,7 +18,6 @@ package ghidra.pcode.emu.jit.gen.op;
import static ghidra.lifecycle.Unfinished.TODO;
import static ghidra.pcode.emu.jit.gen.GenConsts.MDESC_$DOUBLE_UNOP;
import static ghidra.pcode.emu.jit.gen.GenConsts.NAME_MATH;
import static org.objectweb.asm.Opcodes.*;
import org.objectweb.asm.MethodVisitor;
@@ -16,7 +16,6 @@
package ghidra.pcode.emu.jit.gen.op;
import static ghidra.lifecycle.Unfinished.TODO;
import static org.objectweb.asm.Opcodes.*;
import org.objectweb.asm.MethodVisitor;
@@ -15,8 +15,6 @@
*/
package ghidra.pcode.emu.jit.gen.op;
import static org.objectweb.asm.Opcodes.*;
import ghidra.pcode.emu.jit.op.JitFloatLessEqualOp;
/**
@@ -15,8 +15,6 @@
*/
package ghidra.pcode.emu.jit.gen.op;
import static org.objectweb.asm.Opcodes.*;
import ghidra.pcode.emu.jit.op.JitFloatLessOp;
/**
@@ -16,8 +16,6 @@
package ghidra.pcode.emu.jit.gen.op;
import static ghidra.lifecycle.Unfinished.TODO;
import static org.objectweb.asm.Opcodes.DMUL;
import static org.objectweb.asm.Opcodes.FMUL;
import org.objectweb.asm.MethodVisitor;
@@ -17,7 +17,6 @@ package ghidra.pcode.emu.jit.gen.op;
import static ghidra.lifecycle.Unfinished.TODO;
import static ghidra.pcode.emu.jit.gen.GenConsts.*;
import static org.objectweb.asm.Opcodes.INVOKESTATIC;
import org.objectweb.asm.MethodVisitor;
@@ -16,8 +16,6 @@
package ghidra.pcode.emu.jit.gen.op;
import static ghidra.lifecycle.Unfinished.TODO;
import static org.objectweb.asm.Opcodes.DNEG;
import static org.objectweb.asm.Opcodes.FNEG;
import org.objectweb.asm.MethodVisitor;
@@ -15,8 +15,6 @@
*/
package ghidra.pcode.emu.jit.gen.op;
import static org.objectweb.asm.Opcodes.*;
import ghidra.pcode.emu.jit.op.JitFloatNotEqualOp;
/**
@@ -18,7 +18,6 @@ package ghidra.pcode.emu.jit.gen.op;
import static ghidra.lifecycle.Unfinished.TODO;
import static ghidra.pcode.emu.jit.gen.GenConsts.MDESC_$DOUBLE_UNOP;
import static ghidra.pcode.emu.jit.gen.GenConsts.NAME_MATH;
import static org.objectweb.asm.Opcodes.*;
import org.objectweb.asm.MethodVisitor;
@@ -18,7 +18,6 @@ package ghidra.pcode.emu.jit.gen.op;
import static ghidra.lifecycle.Unfinished.TODO;
import static ghidra.pcode.emu.jit.gen.GenConsts.MDESC_$DOUBLE_UNOP;
import static ghidra.pcode.emu.jit.gen.GenConsts.NAME_MATH;
import static org.objectweb.asm.Opcodes.*;
import org.objectweb.asm.MethodVisitor;
@@ -16,8 +16,6 @@
package ghidra.pcode.emu.jit.gen.op;
import static ghidra.lifecycle.Unfinished.TODO;
import static org.objectweb.asm.Opcodes.DSUB;
import static org.objectweb.asm.Opcodes.FSUB;
import org.objectweb.asm.MethodVisitor;
@@ -16,7 +16,6 @@
package ghidra.pcode.emu.jit.gen.op;
import static ghidra.lifecycle.Unfinished.TODO;
import static org.objectweb.asm.Opcodes.*;
import org.objectweb.asm.MethodVisitor;
@@ -15,9 +15,6 @@
*/
package ghidra.pcode.emu.jit.gen.op;
import static org.objectweb.asm.Opcodes.INEG;
import static org.objectweb.asm.Opcodes.LNEG;
import org.objectweb.asm.MethodVisitor;
import ghidra.lifecycle.Unfinished;
@@ -16,7 +16,6 @@
package ghidra.pcode.emu.jit.gen.op;
import static ghidra.lifecycle.Unfinished.TODO;
import static org.objectweb.asm.Opcodes.*;
import org.objectweb.asm.*;
@@ -15,9 +15,6 @@
*/
package ghidra.pcode.emu.jit.gen.op;
import static org.objectweb.asm.Opcodes.IAND;
import static org.objectweb.asm.Opcodes.LAND;
import ghidra.pcode.emu.jit.op.JitIntAndOp;
/**
@@ -17,7 +17,6 @@ package ghidra.pcode.emu.jit.gen.op;
import static ghidra.lifecycle.Unfinished.TODO;
import static ghidra.pcode.emu.jit.gen.GenConsts.*;
import static org.objectweb.asm.Opcodes.*;
import org.objectweb.asm.*;
@@ -17,7 +17,6 @@ package ghidra.pcode.emu.jit.gen.op;
import static ghidra.lifecycle.Unfinished.TODO;
import static ghidra.pcode.emu.jit.gen.GenConsts.*;
import static org.objectweb.asm.Opcodes.INVOKESTATIC;
import org.objectweb.asm.MethodVisitor;
@@ -15,9 +15,6 @@
*/
package ghidra.pcode.emu.jit.gen.op;
import static org.objectweb.asm.Opcodes.IFEQ;
import static org.objectweb.asm.Opcodes.IF_ICMPEQ;
import ghidra.pcode.emu.jit.op.JitIntEqualOp;
/**
@@ -15,8 +15,6 @@
*/
package ghidra.pcode.emu.jit.gen.op;
import static org.objectweb.asm.Opcodes.IFLE;
import ghidra.pcode.emu.jit.op.JitIntLessEqualOp;
/**
@@ -15,8 +15,6 @@
*/
package ghidra.pcode.emu.jit.gen.op;
import static org.objectweb.asm.Opcodes.IFLT;
import ghidra.pcode.emu.jit.op.JitIntLessOp;
/**
@@ -16,8 +16,6 @@
package ghidra.pcode.emu.jit.gen.op;
import static ghidra.lifecycle.Unfinished.TODO;
import static org.objectweb.asm.Opcodes.IMUL;
import static org.objectweb.asm.Opcodes.LMUL;
import org.objectweb.asm.MethodVisitor;
@@ -15,8 +15,6 @@
*/
package ghidra.pcode.emu.jit.gen.op;
import static org.objectweb.asm.Opcodes.*;
import org.objectweb.asm.MethodVisitor;
import ghidra.lifecycle.Unfinished;
@@ -15,9 +15,6 @@
*/
package ghidra.pcode.emu.jit.gen.op;
import static org.objectweb.asm.Opcodes.IFNE;
import static org.objectweb.asm.Opcodes.IF_ICMPNE;
import ghidra.pcode.emu.jit.op.JitIntNotEqualOp;
/**
@@ -15,9 +15,6 @@
*/
package ghidra.pcode.emu.jit.gen.op;
import static org.objectweb.asm.Opcodes.IOR;
import static org.objectweb.asm.Opcodes.LOR;
import ghidra.pcode.emu.jit.op.JitIntOrOp;
/**
@@ -17,7 +17,6 @@ package ghidra.pcode.emu.jit.gen.op;
import static ghidra.lifecycle.Unfinished.TODO;
import static ghidra.pcode.emu.jit.gen.GenConsts.*;
import static org.objectweb.asm.Opcodes.INVOKESTATIC;
import org.objectweb.asm.MethodVisitor;
@@ -17,7 +17,6 @@ package ghidra.pcode.emu.jit.gen.op;
import static ghidra.lifecycle.Unfinished.TODO;
import static ghidra.pcode.emu.jit.gen.GenConsts.*;
import static org.objectweb.asm.Opcodes.*;
import org.objectweb.asm.MethodVisitor;
@@ -17,7 +17,6 @@ package ghidra.pcode.emu.jit.gen.op;
import static ghidra.lifecycle.Unfinished.TODO;
import static ghidra.pcode.emu.jit.gen.GenConsts.*;
import static org.objectweb.asm.Opcodes.*;
import org.objectweb.asm.MethodVisitor;

Some files were not shown because too many files have changed in this diff Show More