Mirrors_Framework/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2026-05-23 01:50:15 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

GP-3183 Fixed CParser.parse(String) method with not data type archive.

Browse Source 
Fixed return data type of method when parsing a structure.
This commit is contained in:
emteere
2023-03-11 21:47:46 +00:00
parent 5bd0bb5b00
commit 8191d408f3
2 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Ghidra/Features/Base/src/main/javacc/ghidra/app/util/cparser/C/C.jj
+3 -1
View File
@@ -307,6 +307,8 @@ public class CParser {
private DataType addDef(Map<String, DataType> table, String name, DataType dt) {
// System.out.println("** addDef " + name + " = " + (dt != null ? dt.getName() : " - no type -") );
lastDataType = dt;
DataType existingDT = table.get(name);
if (existingDT != null && dt.isEquivalent(existingDT)) {
return existingDT;
@@ -426,7 +428,7 @@ public class CParser {
hasNoComponents = (dtComp.getNumDefinedComponents() == 0 ? true : false);
hasSameSourceArchive = dt.getSourceArchive().equals(dtMgr.getLocalSourceArchive());
hasSameSourceArchive = Objects.equals(dt.getSourceArchive(), dtMgr.getLocalSourceArchive());
}
// make sure comp is a Composite, if existing dt is empty, in same category and archive
Ghidra/Features/Base/src/test/java/ghidra/app/util/cparser/CParserTest.java
+15
View File
@@ -51,6 +51,21 @@ public class CParserTest extends AbstractGenericTest {
DataType dt = parser.getDataTypeManager().getDataType("/int32_t");
assertTrue(dt != null);
assertTrue(dt instanceof TypeDef);
dt = parser.parse("struct mystruct {" +
" int field1;" +
" char field2;" +
" };");
assertTrue(dt != null);
assertTrue(dt instanceof Structure);
Structure sdt = (Structure) dt;
DataTypeComponent comp = sdt.getComponent(0);
assertEquals("field1", comp.getFieldName());
assertEquals(comp.getDataType().getName(),"int");
comp = sdt.getComponent(1);
assertEquals("field2", comp.getFieldName());
assertEquals(comp.getDataType().getName(),"char");
}
/**