Everything estop or safety must use cm1

This commit is contained in:
Rob Giseburt
2019-11-07 23:48:27 -05:00
parent d130ed4675
commit dd430f8f67
4 changed files with 67 additions and 46 deletions

View File

@@ -96,7 +96,7 @@ void cm_clear()
void cm_parse_clear(const char *s)
{
#ifdef ENABLE_INTERLOCK_AND_ESTOP
if (cm->machine_state == MACHINE_ALARM || (cm->machine_state == MACHINE_SHUTDOWN && cm->estop_state != 0)) {
if (cm->machine_state == MACHINE_ALARM || (cm->machine_state == MACHINE_SHUTDOWN && cm1.estop_state != 0)) {
#else
if (cm->machine_state == MACHINE_ALARM) {
#endif

View File

@@ -304,9 +304,9 @@ void canonical_machine_reset(cmMachine_t *_cm)
_cm->machine_state = MACHINE_READY;
#ifdef ENABLE_INTERLOCK_AND_ESTOP
_cm->safety_state = _cm->estop_state = 0;
_cm->esc_boot_timer.set(ESC_BOOT_TIME);
_cm->safety_state = SAFETY_ESC_REBOOTING;
cm1.safety_state = cm1.estop_state = 0;
cm1.esc_boot_timer.set(ESC_BOOT_TIME);
cm1.safety_state = SAFETY_ESC_REBOOTING;
#endif
cm_operation_init(); // reset operations runner
@@ -1770,8 +1770,8 @@ void cm_program_end()
#ifdef ENABLE_INTERLOCK_AND_ESTOP
stat_t cm_ack_estop(nvObj_t *nv)
{
cm->estop_state &= ~ESTOP_UNACKED;
nv->value_flt = (float)cm->estop_state;
cm1.estop_state &= ~ESTOP_UNACKED;
nv->value_flt = (float)cm1.estop_state;
nv->valuetype = TYPE_FLOAT;
return (STAT_OK);
}
@@ -2156,15 +2156,15 @@ stat_t cm_get_frmo(nvObj_t *nv) { return(_get_msg_helper(nv, msg_frmo, cm_get_fe
#ifdef ENABLE_INTERLOCK_AND_ESTOP
stat_t cm_get_safe(nvObj_t *nv) {
uint8_t safe = 0;
if ((cm->safety_state & SAFETY_INTERLOCK_MASK) != 0) {
if ((cm1.safety_state & SAFETY_INTERLOCK_MASK) != 0) {
safe |= 0x1;
}
if ((cm->safety_state & SAFETY_ESC_MASK) != 0) {
if ((cm1.safety_state & SAFETY_ESC_MASK) != 0) {
safe |= 0x2;
}
return (_get_msg_helper(nv, msg_safe, safe));
}
stat_t cm_get_estp(nvObj_t *nv) { return (_get_msg_helper(nv, msg_estp, (cm->estop_state & 0x3))); }
stat_t cm_get_estp(nvObj_t *nv) { return (_get_msg_helper(nv, msg_estp, (cm1.estop_state & 0x3))); }
#endif
stat_t cm_get_toolv(nvObj_t *nv) { return(get_integer(nv, cm_get_tool(ACTIVE_MODEL))); }

View File

@@ -155,6 +155,13 @@ void controller_init()
din_handlers[INPUT_ACTION_SHUTDOWN].registerHandler(&_shutdown_input_handler);
din_handlers[INPUT_ACTION_LIMIT].registerHandler(&_limit_input_handler);
din_handlers[INPUT_ACTION_INTERLOCK].registerHandler(&_interlock_input_handler);
if (gpio_read_input(INTERLOCK_SWITCH_INPUT) == INPUT_ACTIVE) {
// cm1.safety_interlock_disengaged = INTERLOCK_SWITCH_INPUT;
cm1.safety_state |= SAFETY_INTERLOCK_OPEN;
}
// if (gpio_read_input(ESTOP_SWITCH_INPUT) == INPUT_ACTIVE) {
// cm1.estop_state = ESTOP_PRESSED | ESTOP_UNACKED | ESTOP_ACTIVE;
// }
}
void controller_request_enquiry()
@@ -268,7 +275,7 @@ static stat_t _dispatch_control()
static stat_t _dispatch_command()
{
#ifdef ENABLE_INTERLOCK_AND_ESTOP
if (cs.controller_state != CONTROLLER_PAUSED && cm->estop_state == 0) {
if (cs.controller_state != CONTROLLER_PAUSED && cm1.estop_state == 0) {
#else
if (cs.controller_state != CONTROLLER_PAUSED) {
#endif
@@ -568,71 +575,81 @@ static stat_t _limit_switch_handler(void)
static stat_t _interlock_estop_handler(void) {
bool report = false;
// Process E-Stop and Interlock signals
if ((cm->safety_state & SAFETY_INTERLOCK_MASK) == SAFETY_INTERLOCK_CLOSED &&
gpio_read_input(INTERLOCK_SWITCH_INPUT) == INPUT_ACTIVE) {
cm->safety_state |= SAFETY_INTERLOCK_OPEN;
// Door opened and was closed
if ((cm1.safety_state & SAFETY_INTERLOCK_MASK) == SAFETY_INTERLOCK_CLOSED && (gpio_read_input(INTERLOCK_SWITCH_INPUT) == INPUT_ACTIVE)) {
cm1.safety_state |= SAFETY_INTERLOCK_OPEN;
// Check if the spindle is on
if (spindle.state != SPINDLE_OFF) {
if (mp_get_run_buffer() != NULL)
cm_request_feedhold(FEEDHOLD_TYPE_HOLD,
FEEDHOLD_EXIT_STOP); // may have already requested STOP as INPUT_ACTION
else {
cm_request_cycle_start(); // proper way to restart the cycle
spindle_control_immediate(spindle.state);
if (cm1.machine_state == MACHINE_CYCLE) {
cm_request_feedhold(FEEDHOLD_TYPE_ACTIONS, FEEDHOLD_EXIT_CYCLE);
} else {
// cm_request_cycle_start(); // proper way to restart the cycle
spindle_control_immediate(SPINDLE_OFF);
}
}
// If we just entered interlock and we're not off, start the lockout timer
if ((cm->safety_state & SAFETY_ESC_MASK) == SAFETY_ESC_ONLINE ||
(cm->safety_state & SAFETY_ESC_MASK) == SAFETY_ESC_REBOOTING) {
if ((cm1.safety_state & SAFETY_ESC_MASK) == SAFETY_ESC_ONLINE ||
(cm1.safety_state & SAFETY_ESC_MASK) == SAFETY_ESC_REBOOTING) {
cm->esc_lockout_timer.set(ESC_LOCKOUT_TIME);
cm->safety_state |= SAFETY_ESC_LOCKOUT;
cm1.safety_state |= SAFETY_ESC_LOCKOUT;
}
report = true;
} else if ((cm->safety_state & SAFETY_INTERLOCK_MASK) == SAFETY_INTERLOCK_OPEN &&
gpio_read_input(INTERLOCK_SWITCH_INPUT) == INPUT_INACTIVE) {
cm->safety_state &= ~SAFETY_INTERLOCK_OPEN;
// Door closed and was open
} else if ((cm1.safety_state & SAFETY_INTERLOCK_MASK) == SAFETY_INTERLOCK_OPEN && (gpio_read_input(INTERLOCK_SWITCH_INPUT) == INPUT_INACTIVE)) {
cm1.safety_state &= ~SAFETY_INTERLOCK_OPEN;
// If we just left interlock, stop the lockout timer
if ((cm->safety_state & SAFETY_ESC_LOCKOUT) == SAFETY_ESC_LOCKOUT) cm->safety_state &= ~SAFETY_ESC_LOCKOUT;
if ((cm1.safety_state & SAFETY_ESC_LOCKOUT) == SAFETY_ESC_LOCKOUT) {
cm1.safety_state &= ~SAFETY_ESC_LOCKOUT;
cm->esc_lockout_timer.clear();
}
report = true;
}
if ((cm->estop_state & ESTOP_PRESSED_MASK) == ESTOP_RELEASED &&
gpio_read_input(ESTOP_SWITCH_INPUT) == INPUT_ACTIVE) {
cm->estop_state = ESTOP_PRESSED | ESTOP_UNACKED | ESTOP_ACTIVE;
// EStop was pressed
if ((cm1.estop_state & ESTOP_PRESSED_MASK) == ESTOP_RELEASED && gpio_read_input(ESTOP_SWITCH_INPUT) == INPUT_ACTIVE) {
cm1.estop_state = ESTOP_PRESSED | ESTOP_UNACKED | ESTOP_ACTIVE;
cm_shutdown(STAT_SHUTDOWN, "e-stop pressed");
// E-stop always sets the ESC to off
cm->safety_state &= ~SAFETY_ESC_MASK;
cm->safety_state |= SAFETY_ESC_OFFLINE;
cm1.safety_state &= ~SAFETY_ESC_MASK;
cm1.safety_state |= SAFETY_ESC_OFFLINE;
report = true;
} else if ((cm->estop_state & ESTOP_PRESSED_MASK) == ESTOP_PRESSED &&
gpio_read_input(ESTOP_SWITCH_INPUT) == INPUT_INACTIVE) {
cm->estop_state &= ~ESTOP_PRESSED;
// EStop was released
} else if ((cm1.estop_state & ESTOP_PRESSED_MASK) == ESTOP_PRESSED && gpio_read_input(ESTOP_SWITCH_INPUT) == INPUT_INACTIVE) {
cm1.estop_state &= ~ESTOP_PRESSED;
report = true;
}
// if E-Stop and Interlock are both 0, and we're off, go into "ESC Reboot"
if ((cm->safety_state & SAFETY_ESC_MASK) == SAFETY_ESC_OFFLINE && (cm->estop_state & ESTOP_PRESSED) == 0 &&
(cm->safety_state & SAFETY_INTERLOCK_OPEN) == 0) {
cm->safety_state &= ~SAFETY_ESC_MASK;
cm->safety_state |= SAFETY_ESC_REBOOTING;
if ((cm1.safety_state & SAFETY_ESC_MASK) == SAFETY_ESC_OFFLINE && (cm1.estop_state & ESTOP_PRESSED) == 0 && (cm1.safety_state & SAFETY_INTERLOCK_OPEN) == 0) {
cm1.safety_state &= ~SAFETY_ESC_MASK;
cm1.safety_state |= SAFETY_ESC_REBOOTING;
cm->esc_boot_timer.set(ESC_BOOT_TIME);
report = true;
}
// Check if ESC lockout timer or reboot timer have expired
if ((cm->safety_state & SAFETY_ESC_LOCKOUT) != 0 && cm->esc_lockout_timer.isPast()) {
cm->safety_state &= ~SAFETY_ESC_MASK;
cm->safety_state |= SAFETY_ESC_OFFLINE;
if ((cm1.safety_state & SAFETY_ESC_LOCKOUT) != 0 && cm->esc_lockout_timer.isPast()) {
cm1.safety_state &= ~SAFETY_ESC_MASK;
cm1.safety_state |= SAFETY_ESC_OFFLINE;
report = true;
}
if ((cm->safety_state & SAFETY_ESC_MASK) == SAFETY_ESC_REBOOTING && cm->esc_boot_timer.isPast()) {
cm->safety_state &= ~SAFETY_ESC_MASK;
if ((cm1.safety_state & SAFETY_ESC_MASK) == SAFETY_ESC_REBOOTING && cm->esc_boot_timer.isPast()) {
cm1.safety_state &= ~SAFETY_ESC_MASK;
report = true;
}
// If we've successfully ended all the ESTOP conditions, then end ESTOP
if (cm->estop_state == ESTOP_ACTIVE) {
cm->estop_state = 0;
if (cm1.estop_state == ESTOP_ACTIVE) {
cm1.estop_state = 0;
report = true;
}
if (report) {
sr_request_status_report(SR_REQUEST_IMMEDIATE);
}

View File

@@ -368,6 +368,10 @@ static stat_t _run_interlock_ended() {
void cm_request_cycle_start()
{
#ifdef ENABLE_INTERLOCK_AND_ESTOP
#endif
if (cm1.hold_state != FEEDHOLD_OFF) { // restart from a feedhold
if (cm1.queue_flush_state == QUEUE_FLUSH_REQUESTED) { // possible race condition. Flush wins
cm1.cycle_start_state = CYCLE_START_OFF;
@@ -504,7 +508,7 @@ static stat_t _run_job_kill()
_run_queue_flush();
#ifdef ENABLE_INTERLOCK_AND_ESTOP
if((cm->safety_state & (SAFETY_ESC_MASK | SAFETY_INTERLOCK_MASK)) != 0 && spindle.state != SPINDLE_OFF)
if((cm1.safety_state & (SAFETY_ESC_MASK | SAFETY_INTERLOCK_MASK)) != 0 && spindle.state != SPINDLE_OFF)
return STAT_EAGAIN;
#endif