Mirrors_Framework/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-05-12 10:08:47 +08:00
Code Issues Actions 11 Packages Projects Releases Wiki Activity

Move extract_packed_value to shared component test helper

Browse Source 
Add tests/component_tests/helpers.py with typed extract_packed_value()
and INTERNAL_BIT constant, replacing 5 duplicate copies.
This commit is contained in:
J. Nick Koston
2026-03-06 10:56:51 -10:00
parent c704d97804
commit 41c413d5f7
6 changed files with 31 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/component_tests/binary_sensor/test_binary_sensor.py
+3 -13
View File
@@ -1,16 +1,6 @@
"""Tests for the binary sensor component."""
import re
_INTERNAL_BIT = 1 << 24
def _extract_packed_value(main_cpp, var_name):
"""Extract the third (packed) argument from a configure_entity_ call."""
pattern = rf"{re.escape(var_name)}->configure_entity_\([^,]+,\s*\w+,\s*(\d+)\)"
match = re.search(pattern, main_cpp)
assert match, f"configure_entity_ call not found for {var_name}"
return int(match.group(1))
from tests.component_tests.helpers import INTERNAL_BIT, extract_packed_value
def test_binary_sensor_is_setup(generate_main):
@@ -57,8 +47,8 @@ def test_binary_sensor_config_value_internal_set(generate_main):
)
# Then: bs_1 has internal: true, bs_2 has internal: false
assert _extract_packed_value(main_cpp, "bs_1") & _INTERNAL_BIT != 0
assert _extract_packed_value(main_cpp, "bs_2") & _INTERNAL_BIT == 0
assert extract_packed_value(main_cpp, "bs_1") & INTERNAL_BIT != 0
assert extract_packed_value(main_cpp, "bs_2") & INTERNAL_BIT == 0
def test_binary_sensor_config_value_use_raw_set(generate_main):
tests/component_tests/button/test_button.py
+3 -13
View File
@@ -1,16 +1,6 @@
"""Tests for the button component"""
import re
_INTERNAL_BIT = 1 << 24
def _extract_packed_value(main_cpp, var_name):
"""Extract the third (packed) argument from a configure_entity_ call."""
pattern = rf"{re.escape(var_name)}->configure_entity_\([^,]+,\s*\w+,\s*(\d+)\)"
match = re.search(pattern, main_cpp)
assert match, f"configure_entity_ call not found for {var_name}"
return int(match.group(1))
from tests.component_tests.helpers import INTERNAL_BIT, extract_packed_value
def test_button_is_setup(generate_main):
@@ -52,5 +42,5 @@ def test_button_config_value_internal_set(generate_main):
main_cpp = generate_main("tests/component_tests/button/test_button.yaml")
# Then: wol_1 has internal: true, wol_2 has internal: false
assert _extract_packed_value(main_cpp, "wol_1") & _INTERNAL_BIT != 0
assert _extract_packed_value(main_cpp, "wol_2") & _INTERNAL_BIT == 0
assert extract_packed_value(main_cpp, "wol_1") & INTERNAL_BIT != 0
assert extract_packed_value(main_cpp, "wol_2") & INTERNAL_BIT == 0
tests/component_tests/helpers.py
+15
View File
@@ -0,0 +1,15 @@
"""Shared helpers for component tests."""
from __future__ import annotations
import re
INTERNAL_BIT = 1 << 24
def extract_packed_value(main_cpp: str, var_name: str) -> int:
"""Extract the third (packed) argument from a configure_entity_ call."""
pattern = rf"{re.escape(var_name)}->configure_entity_\([^,]+,\s*\w+,\s*(\d+)\)"
match = re.search(pattern, main_cpp)
assert match, f"configure_entity_ call not found for {var_name}"
return int(match.group(1))
tests/component_tests/sensor/test_sensor.py
+2 -10
View File
@@ -1,14 +1,6 @@
"""Tests for the sensor component."""
import re
def _extract_packed_value(main_cpp, var_name):
"""Extract the third (packed) argument from a configure_entity_ call."""
pattern = rf"{re.escape(var_name)}->configure_entity_\([^,]+,\s*\w+,\s*(\d+)\)"
match = re.search(pattern, main_cpp)
assert match, f"configure_entity_ call not found for {var_name}"
return int(match.group(1))
from tests.component_tests.helpers import extract_packed_value
def test_sensor_device_class_set(generate_main):
@@ -21,5 +13,5 @@ def test_sensor_device_class_set(generate_main):
main_cpp = generate_main("tests/component_tests/sensor/test_sensor.yaml")
# Then: device_class: voltage means packed value must be non-zero
packed = _extract_packed_value(main_cpp, "s_1")
packed = extract_packed_value(main_cpp, "s_1")
assert packed != 0
tests/component_tests/text/test_text.py
+3 -13
View File
@@ -1,16 +1,6 @@
"""Tests for the text component."""
import re
_INTERNAL_BIT = 1 << 24
def _extract_packed_value(main_cpp, var_name):
"""Extract the third (packed) argument from a configure_entity_ call."""
pattern = rf"{re.escape(var_name)}->configure_entity_\([^,]+,\s*\w+,\s*(\d+)\)"
match = re.search(pattern, main_cpp)
assert match, f"configure_entity_ call not found for {var_name}"
return int(match.group(1))
from tests.component_tests.helpers import INTERNAL_BIT, extract_packed_value
def test_text_is_setup(generate_main):
@@ -50,8 +40,8 @@ def test_text_config_value_internal_set(generate_main):
main_cpp = generate_main("tests/component_tests/text/test_text.yaml")
# Then: it_2 has internal: false, it_3 has internal: true
assert _extract_packed_value(main_cpp, "it_2") & _INTERNAL_BIT == 0
assert _extract_packed_value(main_cpp, "it_3") & _INTERNAL_BIT != 0
assert extract_packed_value(main_cpp, "it_2") & INTERNAL_BIT == 0
assert extract_packed_value(main_cpp, "it_3") & INTERNAL_BIT != 0
def test_text_config_value_mode_set(generate_main):
tests/component_tests/text_sensor/test_text_sensor.py
+5 -15
View File
@@ -1,16 +1,6 @@
"""Tests for the text sensor component."""
import re
_INTERNAL_BIT = 1 << 24
def _extract_packed_value(main_cpp, var_name):
"""Extract the third (packed) argument from a configure_entity_ call."""
pattern = rf"{re.escape(var_name)}->configure_entity_\([^,]+,\s*\w+,\s*(\d+)\)"
match = re.search(pattern, main_cpp)
assert match, f"configure_entity_ call not found for {var_name}"
return int(match.group(1))
from tests.component_tests.helpers import INTERNAL_BIT, extract_packed_value
def test_text_sensor_is_setup(generate_main):
@@ -52,8 +42,8 @@ def test_text_sensor_config_value_internal_set(generate_main):
main_cpp = generate_main("tests/component_tests/text_sensor/test_text_sensor.yaml")
# Then: ts_2 has internal: true, ts_3 has internal: false
assert _extract_packed_value(main_cpp, "ts_2") & _INTERNAL_BIT != 0
assert _extract_packed_value(main_cpp, "ts_3") & _INTERNAL_BIT == 0
assert extract_packed_value(main_cpp, "ts_2") & INTERNAL_BIT != 0
assert extract_packed_value(main_cpp, "ts_3") & INTERNAL_BIT == 0
def test_text_sensor_device_class_set(generate_main):
@@ -67,7 +57,7 @@ def test_text_sensor_device_class_set(generate_main):
# Then: ts_2 has device_class: timestamp, ts_3 has device_class: date
# so their packed values must be non-zero
packed_ts_2 = _extract_packed_value(main_cpp, "ts_2")
packed_ts_2 = extract_packed_value(main_cpp, "ts_2")
assert packed_ts_2 != 0
packed_ts_3 = _extract_packed_value(main_cpp, "ts_3")
packed_ts_3 = extract_packed_value(main_cpp, "ts_3")
assert packed_ts_3 != 0