Mirrors_Framework/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-05-25 10:26:10 +08:00
Code Issues Actions 13 Packages Projects Releases Wiki Activity

Address code review: add triple-quote support and improve error handling

Browse Source 
Co-authored-by: clydebarrow <2366188+clydebarrow@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-01-26 01:01:40 +00:00
parent b8ac92c537
commit 354f60a9cf
1 changed files with 12 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/auto-label-pr.yml
+12 -9
View File
@@ -390,7 +390,7 @@ jobs:
const deprecatedInfo = [];
// Compile regex once for better performance
const componentFileRegex = /^esphome\/components\/([^\/]+)\/.+\.py$/;
const componentFileRegex = /^esphome\/components\/([^\/]+)\/[^/]*\.py$/;
// Get files that are modified or added in components directory
const componentFiles = changedFiles.filter(file => componentFileRegex.test(file));
@@ -399,11 +399,10 @@ jobs:
return { labels, deprecatedInfo };
}
// Extract unique component names
// Extract unique component names using the same regex
const components = new Set();
const componentMatchRegex = /^esphome\/components\/([^\/]+)\//;
for (const file of componentFiles) {
const match = file.match(componentMatchRegex);
const match = file.match(componentFileRegex);
if (match) {
components.add(match[1]);
}
@@ -416,9 +415,11 @@ jobs:
const content = fs.readFileSync(initFile, 'utf8');
// Look for DEPRECATED_COMPONENT = "message" or DEPRECATED_COMPONENT = 'message'
// Support both single and double quotes, and handle escaped quotes
const doubleQuoteMatch = content.match(/DEPRECATED_COMPONENT\s*=\s*"((?:[^"\\]|\\.)*)"/);
const singleQuoteMatch = content.match(/DEPRECATED_COMPONENT\s*=\s*'((?:[^'\\]|\\.)*)'/);
// Support single quotes, double quotes, and triple quotes (for multiline)
const doubleQuoteMatch = content.match(/DEPRECATED_COMPONENT\s*=\s*"""((?:[^\\]|\\.)*)"""/s) ||
content.match(/DEPRECATED_COMPONENT\s*=\s*"((?:[^"\\]|\\.)*)"/);
const singleQuoteMatch = content.match(/DEPRECATED_COMPONENT\s*=\s*'''((?:[^\\]|\\.)*)'''/s) ||
content.match(/DEPRECATED_COMPONENT\s*=\s*'((?:[^'\\]|\\.)*)'/);
const deprecatedMatch = doubleQuoteMatch || singleQuoteMatch;
if (deprecatedMatch) {
@@ -430,8 +431,10 @@ jobs:
console.log(`Found deprecated component: ${component}`);
}
} catch (error) {
// File doesn't exist or can't be read - not an error, just skip
console.log(`Could not read ${initFile}:`, error.message);
// Only log if it's not a simple "file not found" error
if (error.code !== 'ENOENT') {
console.log(`Error reading ${initFile}:`, error.message);
}
}
}