Mirrors_Framework/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-05-24 01:37:15 +08:00
Code Issues Actions 11 Packages Projects Releases Wiki Activity

[time] Fix test namespace for RecalcTimestampLocal and TimezoneOffset tests

Browse Source 
Move tests that use make_us_central(), set_global_tz(), ParsedTimezone,
and DSTRuleType into esphome::time::testing namespace where those symbols
are declared.
This commit is contained in:
J. Nick Koston
2026-02-23 16:41:20 -06:00
parent 8374ccf7b5
commit 199288b813
1 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/components/time/posix_tz_parser.cpp
+11 -5
View File
@@ -565,6 +565,12 @@ TEST(ESPTimeStrptime, LeadingZeroTime) {
// recalc_timestamp_local() tests - verify behavior matches libc mktime()
// ============================================================================
} // namespace esphome::testing
namespace esphome::time::testing {
using esphome::ESPTime;
// Helper to call libc mktime with same fields
static time_t libc_mktime(int year, int month, int day, int hour, int min, int sec) {
struct tm tm {};
@@ -775,7 +781,7 @@ TEST(RecalcTimestampLocal, YearBoundaryDST) {
// ============================================================================
TEST(TimezoneOffset, NoTimezone) {
time::ParsedTimezone tz{};
ParsedTimezone tz{};
set_global_tz(tz);
int32_t offset = ESPTime::timezone_offset();
@@ -784,7 +790,7 @@ TEST(TimezoneOffset, NoTimezone) {
TEST(TimezoneOffset, FixedOffsetPositive) {
// India: IST-5:30 (no DST)
time::ParsedTimezone tz{};
ParsedTimezone tz{};
tz.std_offset_seconds = -(5 * 3600 + 30 * 60);
set_global_tz(tz);
@@ -794,7 +800,7 @@ TEST(TimezoneOffset, FixedOffsetPositive) {
TEST(TimezoneOffset, FixedOffsetNegative) {
// EST5 (no DST)
time::ParsedTimezone tz{};
ParsedTimezone tz{};
tz.std_offset_seconds = 5 * 3600;
set_global_tz(tz);
@@ -812,7 +818,7 @@ TEST(TimezoneOffset, WithDstReturnsCorrectOffsetBasedOnCurrentTime) {
int32_t offset = ESPTime::timezone_offset();
// Verify offset matches what is_in_dst says
if (time::is_in_dst(now, tz)) {
if (is_in_dst(now, tz)) {
// During DST, offset should be -4 hours (EDT)
EXPECT_EQ(offset, -4 * 3600);
} else {
@@ -821,4 +827,4 @@ TEST(TimezoneOffset, WithDstReturnsCorrectOffsetBasedOnCurrentTime) {
}
}
} // namespace esphome::testing
} // namespace esphome::time::testing