Mirrors_Framework/c-periphery
1
0
Fork 0
mirror of https://github.com/vsergeev/c-periphery.git synced 2026-09-23 21:39:17 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

led: fix null termination of internal buffers

Browse Source 
unlikely to be encountered, but handled correctly now.
This commit is contained in:
Vanya A. Sergeev
2025-11-02 00:01:25 -05:00
parent 03e9232d5f
commit 8c5eb85136
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/led.c
+6 -8
View File
@@ -111,18 +111,17 @@ int led_get_brightness(led_t *led, unsigned int *brightness) {
if ((fd = open(led_path, O_RDONLY)) < 0)
return _led_error(led, LED_ERROR_IO, errno, "Opening LED 'brightness'");
if ((ret = read(fd, buf, sizeof(buf))) < 0) {
if ((ret = read(fd, buf, sizeof(buf) - 1)) < 0) {
int errsv = errno;
close(fd);
return _led_error(led, LED_ERROR_IO, errsv, "Reading LED 'brightness'");
}
buf[ret] = '\0';
if (close(fd) < 0)
return _led_error(led, LED_ERROR_IO, errno, "Closing LED 'brightness'");
/* Null-terminate over newline */
buf[ret] = '\0';
*brightness = strtoul(buf, NULL, 10);
return 0;
@@ -138,18 +137,17 @@ int led_get_max_brightness(led_t *led, unsigned int *max_brightness) {
if ((fd = open(led_path, O_RDONLY)) < 0)
return _led_error(led, LED_ERROR_QUERY, errno, "Opening LED 'max_brightness'");
if ((ret = read(fd, buf, sizeof(buf))) < 0) {
if ((ret = read(fd, buf, sizeof(buf) - 1)) < 0) {
int errsv = errno;
close(fd);
return _led_error(led, LED_ERROR_QUERY, errsv, "Reading LED 'max_brightness'");
}
buf[ret] = '\0';
if (close(fd) < 0)
return _led_error(led, LED_ERROR_QUERY, errno, "Closing LED 'max_brightness'");
/* Null-terminate over newline */
buf[ret] = '\0';
led->max_brightness = strtoul(buf, NULL, 10);
*max_brightness = led->max_brightness;