Mirrors_Framework/PX4-Autopilot
1
0
Fork 0
mirror of https://github.com/PX4/PX4-Autopilot.git synced 2026-05-28 02:36:37 +08:00
Code Issues Actions 32 Packages Projects Releases Wiki Activity

Enable flash analysis comments again for non-fork PRs (#24603)

Browse Source
This commit is contained in:
Alexander Lerach
2025-03-25 20:13:18 +01:00
committed by GitHub
parent 5cb3fd1c9f
commit f608a10ed4
1 changed files with 51 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/flash_analysis.yml
+51 -52
View File
@@ -95,62 +95,61 @@ jobs:
echo "$EOF" >> $GITHUB_OUTPUT echo "$EOF" >> $GITHUB_OUTPUT
# TODO: # TODO:
# This part of the workflow is causing errors, we should find a way to fix this and enable this test again # This part of the workflow is causing errors for forks. We should find a way to fix this and enable it again for forks.
# Track this issue https://github.com/PX4/PX4-Autopilot/issues/24408 # Track this issue https://github.com/PX4/PX4-Autopilot/issues/24408
# post_pr_comment:
#post_pr_comment: name: Publish Results
#name: Publish Results runs-on: [runs-on,runner=1cpu-linux-x64,image=ubuntu24-full-x64,"run-id=${{ github.run_id }}",spot=false]
#runs-on: [runs-on,runner=1cpu-linux-x64,image=ubuntu24-full-x64,"run-id=${{ github.run_id }}",spot=false] needs: [analyze_flash]
#needs: [analyze_flash] env:
#env: V5X-SUMMARY-MAP-ABS: ${{ fromJSON(fromJSON(needs.analyze_flash.outputs.px4_fmu-v5x-bloaty-summary-map).vm-absolute) }}
#V5X-SUMMARY-MAP-ABS: ${{ fromJSON(fromJSON(needs.analyze_flash.outputs.px4_fmu-v5x-bloaty-summary-map).vm-absolute) }} V5X-SUMMARY-MAP-PERC: ${{ fromJSON(fromJSON(needs.analyze_flash.outputs.px4_fmu-v5x-bloaty-summary-map).vm-percentage) }}
#V5X-SUMMARY-MAP-PERC: ${{ fromJSON(fromJSON(needs.analyze_flash.outputs.px4_fmu-v5x-bloaty-summary-map).vm-percentage) }} V6X-SUMMARY-MAP-ABS: ${{ fromJSON(fromJSON(needs.analyze_flash.outputs.px4_fmu-v6x-bloaty-summary-map).vm-absolute) }}
#V6X-SUMMARY-MAP-ABS: ${{ fromJSON(fromJSON(needs.analyze_flash.outputs.px4_fmu-v6x-bloaty-summary-map).vm-absolute) }} V6X-SUMMARY-MAP-PERC: ${{ fromJSON(fromJSON(needs.analyze_flash.outputs.px4_fmu-v6x-bloaty-summary-map).vm-percentage) }}
#V6X-SUMMARY-MAP-PERC: ${{ fromJSON(fromJSON(needs.analyze_flash.outputs.px4_fmu-v6x-bloaty-summary-map).vm-percentage) }} if: github.event.pull_request && github.event.pull_request.head.repo.full_name == github.repository
#if: ${{ github.event.pull_request }} steps:
#steps: - name: Find Comment
#- name: Find Comment uses: peter-evans/find-comment@v3
#uses: peter-evans/find-comment@v3 id: fc
#id: fc with:
#with: issue-number: ${{ github.event.pull_request.number }}
#issue-number: ${{ github.event.pull_request.number }} comment-author: 'github-actions[bot]'
#comment-author: 'github-actions[bot]' body-includes: FLASH Analysis
#body-includes: FLASH Analysis
#- name: Set Build Time - name: Set Build Time
#id: bt id: bt
#run: | run: |
#echo "timestamp=$(date +'%Y-%m-%dT%H:%M:%S')" >> $GITHUB_OUTPUT echo "timestamp=$(date +'%Y-%m-%dT%H:%M:%S')" >> $GITHUB_OUTPUT
#- name: Create or update comment - name: Create or update comment
## This can't be moved to the job-level conditions, as GH actions don't allow a job-level if condition to access the env. # This can't be moved to the job-level conditions, as GH actions don't allow a job-level if condition to access the env.
#if: | if: |
#steps.fc.outputs.comment-id != '' || steps.fc.outputs.comment-id != '' ||
#env.V5X-SUMMARY-MAP-ABS >= fromJSON(env.MIN_FLASH_POS_DIFF_FOR_COMMENT) || env.V5X-SUMMARY-MAP-ABS >= fromJSON(env.MIN_FLASH_POS_DIFF_FOR_COMMENT) ||
#env.V5X-SUMMARY-MAP-ABS <= fromJSON(env.MIN_FLASH_NEG_DIFF_FOR_COMMENT) || env.V5X-SUMMARY-MAP-ABS <= fromJSON(env.MIN_FLASH_NEG_DIFF_FOR_COMMENT) ||
#env.V6X-SUMMARY-MAP-ABS >= fromJSON(env.MIN_FLASH_POS_DIFF_FOR_COMMENT) || env.V6X-SUMMARY-MAP-ABS >= fromJSON(env.MIN_FLASH_POS_DIFF_FOR_COMMENT) ||
#env.V6X-SUMMARY-MAP-ABS <= fromJSON(env.MIN_FLASH_NEG_DIFF_FOR_COMMENT) env.V6X-SUMMARY-MAP-ABS <= fromJSON(env.MIN_FLASH_NEG_DIFF_FOR_COMMENT)
#uses: peter-evans/create-or-update-comment@v4 uses: peter-evans/create-or-update-comment@v4
#with: with:
#comment-id: ${{ steps.fc.outputs.comment-id }} comment-id: ${{ steps.fc.outputs.comment-id }}
#issue-number: ${{ github.event.pull_request.number }} issue-number: ${{ github.event.pull_request.number }}
#body: | body: |
### 🔎 FLASH Analysis ## 🔎 FLASH Analysis
#<details> <details>
#<summary>px4_fmu-v5x [Total VM Diff: ${{ env.V5X-SUMMARY-MAP-ABS }} byte (${{ env.V5X-SUMMARY-MAP-PERC}} %)]</summary> <summary>px4_fmu-v5x [Total VM Diff: ${{ env.V5X-SUMMARY-MAP-ABS }} byte (${{ env.V5X-SUMMARY-MAP-PERC}} %)]</summary>
#``` ```
#${{ needs.analyze_flash.outputs.px4_fmu-v5x-bloaty-output }} ${{ needs.analyze_flash.outputs.px4_fmu-v5x-bloaty-output }}
#``` ```
#</details> </details>
#<details> <details>
#<summary>px4_fmu-v6x [Total VM Diff: ${{ env.V6X-SUMMARY-MAP-ABS }} byte (${{ env.V6X-SUMMARY-MAP-PERC }} %)]</summary> <summary>px4_fmu-v6x [Total VM Diff: ${{ env.V6X-SUMMARY-MAP-ABS }} byte (${{ env.V6X-SUMMARY-MAP-PERC }} %)]</summary>
#``` ```
#${{ needs.analyze_flash.outputs.px4_fmu-v6x-bloaty-output }} ${{ needs.analyze_flash.outputs.px4_fmu-v6x-bloaty-output }}
#``` ```
#</details> </details>
#**Updated: _${{ steps.bt.outputs.timestamp }}_** **Updated: _${{ steps.bt.outputs.timestamp }}_**
#edit-mode: replace edit-mode: replace