Mirrors_Framework/PX4-Autopilot
1
0
Fork 0
mirror of https://github.com/PX4/PX4-Autopilot.git synced 2026-05-31 02:16:53 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

build(cmake): treat clang-cl like MSVC in px4_add_common_flags

Browse Source 
clang-cl emits CMAKE_CXX_COMPILER_ID="Clang" with
CMAKE_CXX_SIMULATE_ID="MSVC" because it is the LLVM driver running
on top of MSVC's headers and CRT. The previous flag selector keyed
strictly on CMAKE_CXX_COMPILER_ID == "MSVC", so clang-cl fell into
the GCC/Clang flag branch and tried to forward switches the cl-style
driver rejects (e.g. -fdata-sections, GCC-style warning toggles).

Recognise the (Clang + SIMULATE_ID=MSVC) combination as the MSVC
driver path so the same MSVC-flavoured flag set is applied. Native
clang/AppleClang is unaffected because SIMULATE_ID is empty there.

Signed-off-by: Nuno Marques <n.marques21@hotmail.com>
This commit is contained in:
Nuno Marques
2026-05-07 18:05:59 -07:00
parent 0dafafbc90
commit ce12bbaefd
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmake/px4_add_common_flags.cmake
+7 -1
View File
@@ -195,7 +195,13 @@ endfunction()
function(px4_add_common_flags) function(px4_add_common_flags)
if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC") # clang-cl emits CMAKE_CXX_COMPILER_ID="Clang" with
# CMAKE_CXX_SIMULATE_ID="MSVC" because it is the LLVM driver running
# on top of the MSVC headers/CRT. Treat it like native MSVC for flag
# selection so we don't try to forward GCC-style switches like
# -fdata-sections that the cl-style driver rejects.
if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC" OR
(("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang") AND ("${CMAKE_CXX_SIMULATE_ID}" STREQUAL "MSVC")))
add_compile_options( add_compile_options(
/MP /MP
/Zi /Zi