PX4 ROS2 msg conformity and explicit topics

- .msg files are PascalCase
 - topics are still either per msg or explicitly listed in TOPICS
 - compatible structs are still generated (eg struct msg_s), but ROS2 style px4::msg::Msg is also available

msg/ActuatorControls.msg

@@ -20,6 +20,3 @@ uint8 GROUP_INDEX_PAYLOAD = 6
 
 uint64 timestamp_sample	    # the timestamp the data this control response is based on was sampled
 float32[8] control
-
-# TOPICS actuator_controls actuator_controls_0 actuator_controls_1 actuator_controls_2 actuator_controls_3
-# TOPICS actuator_controls_virtual_fw actuator_controls_virtual_mc

msg/ActuatorControlsStatus.msg

@@ -6,5 +6,3 @@ uint8 INDEX_YAW = 2
 uint8 INDEX_THROTTLE = 3
 
 float32[4] control_power
-
-# TOPICS actuator_controls_status actuator_controls_status_0 actuator_controls_status_1

msg/ActuatorOutputs.msg

@@ -3,6 +3,3 @@ uint8 NUM_ACTUATOR_OUTPUTS		= 16
 uint8 NUM_ACTUATOR_OUTPUT_GROUPS	= 4	# for sanity checking
 uint32 noutputs				# valid outputs
 float32[16] output				# output data, in natural output units
-
-# actuator_outputs_sim is used for SITL, HITL & SIH (with an output range of [-1, 1])
-# TOPICS actuator_outputs actuator_outputs_sim

msg/CMakeLists.txt

@@ -1,6 +1,6 @@
 ############################################################################
 #
-#   Copyright (c) 2016 PX4 Development Team. All rights reserved.
+#   Copyright (c) 2016-2022 PX4 Development Team. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions
@@ -37,213 +37,179 @@ cmake_policy(SET CMP0057 NEW)
 include(px4_list_make_absolute)
 
 set(msg_files
-	action_request.msg
-	actuator_armed.msg
-	actuator_controls.msg
-	actuator_controls_status.msg
-	actuator_motors.msg
-	actuator_outputs.msg
-	actuator_servos.msg
-	actuator_servos_trim.msg
-	actuator_test.msg
-	adc_report.msg
-	airspeed.msg
-	airspeed_validated.msg
-	airspeed_wind.msg
-	autotune_attitude_control_status.msg
-	battery_status.msg
-	camera_capture.msg
-	camera_status.msg
-	camera_trigger.msg
-	cellular_status.msg
-	collision_constraints.msg
-	collision_report.msg
-	commander_state.msg
-	control_allocator_status.msg
-	cpuload.msg
-	differential_pressure.msg
-	distance_sensor.msg
-	ekf2_timestamps.msg
-	estimator_gps_status.msg
-	esc_report.msg
-	esc_status.msg
-	estimator_baro_bias.msg
-	estimator_event_flags.msg
-	estimator_innovations.msg
-	estimator_optical_flow_vel.msg
-	estimator_selector_status.msg
-	estimator_sensor_bias.msg
-	estimator_states.msg
-	estimator_status.msg
-	estimator_status_flags.msg
-	event.msg
-	follow_target.msg
-	failure_detector_status.msg
-	generator_status.msg
-	geofence_result.msg
-	gimbal_device_attitude_status.msg
-	gimbal_device_information.msg
-	gimbal_device_set_attitude.msg
-	gimbal_manager_information.msg
-	gimbal_manager_set_attitude.msg
-	gimbal_manager_set_manual_control.msg
-	gimbal_manager_status.msg
-	gps_dump.msg
-	gps_inject_data.msg
-	heater_status.msg
-	home_position.msg
-	hover_thrust_estimate.msg
-	internal_combustion_engine_status.msg
-	input_rc.msg
-	iridiumsbd_status.msg
-	irlock_report.msg
-	landing_gear.msg
-	landing_target_innovations.msg
-	landing_target_pose.msg
-	led_control.msg
-	log_message.msg
-	logger_status.msg
-	mag_worker_data.msg
-	magnetometer_bias_estimate.msg
-	manual_control_setpoint.msg
-	manual_control_switches.msg
-	mavlink_log.msg
-	mavlink_tunnel.msg
-	mission.msg
-	mission_result.msg
-	mount_orientation.msg
-	navigator_mission_item.msg
-	npfg_status.msg
-	obstacle_distance.msg
-	offboard_control_mode.msg
-	onboard_computer_status.msg
-	optical_flow.msg
-	orbit_status.msg
-	parameter_update.msg
-	ping.msg
-	pps_capture.msg
-	position_controller_landing_status.msg
-	position_controller_status.msg
-	position_setpoint.msg
-	position_setpoint_triplet.msg
-	power_button_state.msg
-	power_monitor.msg
-	pwm_input.msg
-	px4io_status.msg
-	radio_status.msg
-	rate_ctrl_status.msg
-	rc_channels.msg
-	rc_parameter_map.msg
-	rpm.msg
-	rtl_time_estimate.msg
-	safety.msg
-	satellite_info.msg
-	sensor_accel.msg
-	sensor_accel_fifo.msg
-	sensor_baro.msg
-	sensor_combined.msg
-	sensor_correction.msg
-	sensor_gps.msg
-	sensor_gyro.msg
-	sensor_gyro_fft.msg
-	sensor_gyro_fifo.msg
-	sensor_hygrometer.msg
-	sensor_mag.msg
-	sensor_preflight_mag.msg
-	sensor_selection.msg
-	sensors_status_imu.msg
-	system_power.msg
-	takeoff_status.msg
-	task_stack_info.msg
-	tecs_status.msg
-	telemetry_status.msg
-	test_motor.msg
-	timesync.msg
-	timesync_status.msg
-	trajectory_bezier.msg
-	trajectory_waypoint.msg
-	transponder_report.msg
-	tune_control.msg
-	uavcan_parameter_request.msg
-	uavcan_parameter_value.msg
-	ulog_stream.msg
-	ulog_stream_ack.msg
-	vehicle_acceleration.msg
-	vehicle_air_data.msg
-	vehicle_angular_acceleration.msg
-	vehicle_angular_acceleration_setpoint.msg
-	vehicle_angular_velocity.msg
-	vehicle_attitude.msg
-	vehicle_attitude_setpoint.msg
-	vehicle_command.msg
-	vehicle_command_ack.msg
-	vehicle_constraints.msg
-	vehicle_control_mode.msg
-	vehicle_global_position.msg
-	vehicle_gps_position.msg
-	vehicle_imu.msg
-	vehicle_imu_status.msg
-	vehicle_land_detected.msg
-	vehicle_local_position.msg
-	vehicle_local_position_setpoint.msg
-	vehicle_magnetometer.msg
-	vehicle_odometry.msg
-	vehicle_rates_setpoint.msg
-	vehicle_roi.msg
-	vehicle_status.msg
-	vehicle_status_flags.msg
-	vehicle_thrust_setpoint.msg
-	vehicle_torque_setpoint.msg
-	vehicle_trajectory_bezier.msg
-	vehicle_trajectory_waypoint.msg
-	vtol_vehicle_status.msg
-	wheel_encoders.msg
-	wind.msg
-	yaw_estimator_status.msg
+	ActionRequest.msg
+	ActuatorArmed.msg
+	ActuatorControls.msg
+	ActuatorControlsStatus.msg
+	ActuatorMotors.msg
+	ActuatorOutputs.msg
+	ActuatorServos.msg
+	ActuatorServosTrim.msg
+	ActuatorTest.msg
+	AdcReport.msg
+	Airspeed.msg
+	AirspeedValidated.msg
+	AirspeedWind.msg
+	AutotuneAttitudeControlStatus.msg
+	BatteryStatus.msg
+	CameraCapture.msg
+	CameraStatus.msg
+	CameraTrigger.msg
+	CellularStatus.msg
+	CollisionConstraints.msg
+	CollisionReport.msg
+	CommanderState.msg
+	ControlAllocatorStatus.msg
+	Cpuload.msg
+	DebugArray.msg
+	DebugKeyValue.msg
+	DebugValue.msg
+	DebugVect.msg
+	DifferentialPressure.msg
+	DistanceSensor.msg
+	Ekf2Timestamps.msg
+	EscReport.msg
+	EscStatus.msg
+	EstimatorBaroBias.msg
+	EstimatorEventFlags.msg
+	EstimatorGpsStatus.msg
+	EstimatorInnovations.msg
+	EstimatorOpticalFlowVel.msg
+	EstimatorSelectorStatus.msg
+	EstimatorSensorBias.msg
+	EstimatorStates.msg
+	EstimatorStatus.msg
+	EstimatorStatusFlags.msg
+	Event.msg
+	FailureDetectorStatus.msg
+	FollowTarget.msg
+	GeneratorStatus.msg
+	GeofenceResult.msg
+	GimbalDeviceAttitudeStatus.msg
+	GimbalDeviceInformation.msg
+	GimbalDeviceSetAttitude.msg
+	GimbalManagerInformation.msg
+	GimbalManagerSetAttitude.msg
+	GimbalManagerSetManualControl.msg
+	GimbalManagerStatus.msg
+	GpsDump.msg
+	GpsInjectData.msg
+	HeaterStatus.msg
+	HomePosition.msg
+	HoverThrustEstimate.msg
+	InputRc.msg
+	InternalCombustionEngineStatus.msg
+	IridiumsbdStatus.msg
+	IrlockReport.msg
+	LandingGear.msg
+	LandingTargetInnovations.msg
+	LandingTargetPose.msg
+	LedControl.msg
+	LoggerStatus.msg
+	LogMessage.msg
+	MagnetometerBiasEstimate.msg
+	MagWorkerData.msg
+	ManualControlSetpoint.msg
+	ManualControlSwitches.msg
+	MavlinkLog.msg
+	MavlinkTunnel.msg
+	Mission.msg
+	MissionResult.msg
+	MountOrientation.msg
+	NavigatorMissionItem.msg
+	NpfgStatus.msg
+	ObstacleDistance.msg
+	OffboardControlMode.msg
+	OnboardComputerStatus.msg
+	OpticalFlow.msg
+	OrbitStatus.msg
+	OrbTest.msg
+	OrbTestLarge.msg
+	OrbTestMedium.msg
+	ParameterUpdate.msg
+	Ping.msg
+	PositionControllerLandingStatus.msg
+	PositionControllerStatus.msg
+	PositionSetpoint.msg
+	PositionSetpointTriplet.msg
+	PowerButtonState.msg
+	PowerMonitor.msg
+	PpsCapture.msg
+	PwmInput.msg
+	Px4ioStatus.msg
+	RadioStatus.msg
+	RateCtrlStatus.msg
+	RcChannels.msg
+	RcParameterMap.msg
+	Rpm.msg
+	RtlTimeEstimate.msg
+	Safety.msg
+	SatelliteInfo.msg
+	SensorAccel.msg
+	SensorAccelFifo.msg
+	SensorBaro.msg
+	SensorCombined.msg
+	SensorCorrection.msg
+	SensorGps.msg
+	SensorGyro.msg
+	SensorGyroFft.msg
+	SensorGyroFifo.msg
+	SensorHygrometer.msg
+	SensorMag.msg
+	SensorPreflightMag.msg
+	SensorSelection.msg
+	SensorsStatusImu.msg
+	SystemPower.msg
+	TakeoffStatus.msg
+	TaskStackInfo.msg
+	TecsStatus.msg
+	TelemetryStatus.msg
+	TestMotor.msg
+	Timesync.msg
+	TimesyncStatus.msg
+	TrajectoryBezier.msg
+	TrajectoryWaypoint.msg
+	TransponderReport.msg
+	TuneControl.msg
+	UavcanParameterRequest.msg
+	UavcanParameterValue.msg
+	UlogStream.msg
+	UlogStreamAck.msg
+	VehicleAcceleration.msg
+	VehicleAirData.msg
+	VehicleAngularAcceleration.msg
+	VehicleAngularAccelerationSetpoint.msg
+	VehicleAngularVelocity.msg
+	VehicleAttitude.msg
+	VehicleAttitudeSetpoint.msg
+	VehicleCommand.msg
+	VehicleCommandAck.msg
+	VehicleConstraints.msg
+	VehicleControlMode.msg
+	VehicleGlobalPosition.msg
+	VehicleGpsPosition.msg
+	VehicleImu.msg
+	VehicleImuStatus.msg
+	VehicleLandDetected.msg
+	VehicleLocalPosition.msg
+	VehicleLocalPositionSetpoint.msg
+	VehicleMagnetometer.msg
+	VehicleOdometry.msg
+	VehicleRatesSetpoint.msg
+	VehicleRoi.msg
+	VehicleStatus.msg
+	VehicleStatusFlags.msg
+	VehicleThrustSetpoint.msg
+	VehicleTorqueSetpoint.msg
+	VehicleTrajectoryBezier.msg
+	VehicleTrajectoryWaypoint.msg
+	VtolVehicleStatus.msg
+	WheelEncoders.msg
+	Wind.msg
+	YawEstimatorStatus.msg
 )
-
-if(NOT px4_constrained_flash_build)
-	list(APPEND msg_files
-		debug_array.msg
-		debug_key_value.msg
-		debug_value.msg
-		debug_vect.msg
-	)
-endif()
-
-if(PX4_TESTING)
-	list(APPEND msg_files
-		orb_test.msg
-		orb_test_large.msg
-		orb_test_medium.msg
-	)
-endif()
-
 list(SORT msg_files)
 
-set(deprecated_msgs
-	ekf2_innovations.msg	# 2019-11-22, Updated estimator interface and logging; replaced by 'estimator_innovations'.
-	)
-
-foreach(msg IN LISTS deprecated_msgs)
-	if(msg IN_LIST msg_files)
-		get_filename_component(msg_we ${msg} NAME_WE)
-		list(APPEND invalid_msgs ${msg_we})
-	endif()
-endforeach()
-if(invalid_msgs)
-	list(LENGTH invalid_msgs invalid_msgs_size)
-	if(${invalid_msgs_size} GREATER 1)
-		foreach(msg IN LISTS invalid_msgs)
-			string(CONCAT invalid_msgs_cs ${invalid_msgs_cs} "'${msg}', ")
-		endforeach()
-		STRING(REGEX REPLACE ", +$" "" invalid_msgs_cs ${invalid_msgs_cs})
-		message(FATAL_ERROR "${invalid_msgs_cs} are listed as deprecated. Please use different names for the messages.")
-	else()
-		message(FATAL_ERROR "'${invalid_msgs}' is listed as deprecated. Please use a different name for the message.")
-	endif()
-endif()
-
 px4_list_make_absolute(msg_files ${CMAKE_CURRENT_SOURCE_DIR} ${msg_files})
 
 if(NOT EXTERNAL_MODULES_LOCATION STREQUAL "")
@@ -258,40 +224,40 @@ if(NOT EXTERNAL_MODULES_LOCATION STREQUAL "")
 	endif()
 endif()
 
+# set parent scope msg_files for other modules to consume (eg topic_listener)
+set(msg_files ${msg_files} PARENT_SCOPE)
+
 # headers
 set(msg_out_path ${PX4_BINARY_DIR}/uORB/topics)
 set(msg_source_out_path	${CMAKE_CURRENT_BINARY_DIR}/topics_sources)
 
-set(uorb_headers ${msg_out_path}/uORBTopics.hpp)
-set(uorb_sources ${msg_source_out_path}/uORBTopics.cpp)
+set(uorb_headers)
 foreach(msg_file ${msg_files})
 	get_filename_component(msg ${msg_file} NAME_WE)
+
+	# Pascal case to snake case (MsgFile -> msg_file)
+	string(REGEX REPLACE "(.)([A-Z][a-z]+)" "\\1_\\2" msg "${msg}")
+	string(REGEX REPLACE "([a-z0-9])([A-Z])" "\\1_\\2" msg "${msg}")
+	string(TOLOWER "${msg}" msg)
+
 	list(APPEND uorb_headers ${msg_out_path}/${msg}.h)
-	list(APPEND uorb_sources ${msg_source_out_path}/${msg}.cpp)
 endforeach()
 
-if (px4_constrained_flash_build)
+if(px4_constrained_flash_build)
 	set(added_arguments --constrained-flash)
 endif()
 
-# set parent scope msg_files for other modules to consume (eg topic_listener)
-set(msg_files ${msg_files} PARENT_SCOPE)
-
 # Generate uORB headers
 add_custom_command(OUTPUT ${uorb_headers}
 	COMMAND ${PYTHON_EXECUTABLE} tools/px_generate_uorb_topic_files.py
-		--headers
 		-f ${msg_files}
 		-i ${CMAKE_CURRENT_SOURCE_DIR}
 		-o ${msg_out_path}
 		-e templates/uorb
-		-t ${CMAKE_CURRENT_BINARY_DIR}/tmp/headers
-		-q
 		${added_arguments}
 	DEPENDS
 		${msg_files}
 		templates/uorb/msg.h.em
-		templates/uorb/uORBTopics.hpp.em
 		tools/px_generate_uorb_topic_files.py
 		tools/px_generate_uorb_topic_helper.py
 	COMMENT "Generating uORB topic headers"
@@ -299,28 +265,3 @@ add_custom_command(OUTPUT ${uorb_headers}
 	VERBATIM
 	)
 add_custom_target(uorb_headers DEPENDS ${uorb_headers})
-
-# Generate uORB sources
-add_custom_command(OUTPUT ${uorb_sources}
-	COMMAND ${PYTHON_EXECUTABLE} tools/px_generate_uorb_topic_files.py
-		--sources
-		-f ${msg_files}
-		-i ${CMAKE_CURRENT_SOURCE_DIR}
-		-o ${msg_source_out_path}
-		-e templates/uorb
-		-t ${CMAKE_CURRENT_BINARY_DIR}/tmp/sources
-		-q
-		${added_arguments}
-	DEPENDS
-		${msg_files}
-		templates/uorb/msg.cpp.em
-		templates/uorb/uORBTopics.cpp.em
-		tools/px_generate_uorb_topic_files.py
-		tools/px_generate_uorb_topic_helper.py
-	COMMENT "Generating uORB topic sources"
-	WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
-	VERBATIM
-	)
-
-add_library(uorb_msgs ${uorb_sources})
-add_dependencies(uorb_msgs prebuild_targets uorb_headers)

msg/CameraTrigger.msg

@@ -5,5 +5,3 @@ uint32 seq		# Image sequence number
 bool feedback	# Trigger feedback from camera
 
 uint32 ORB_QUEUE_LENGTH = 2
-
-# TOPICS camera_trigger

msg/EscStatus.msg

@@ -25,4 +25,4 @@ uint8 esc_online_flags					# Bitmask indicating which ESC is online/offline
 
 uint8 esc_armed_flags					# Bitmask indicating which ESC is armed. For ESC's where the arming state is not known (returned by the ESC), the arming bits should always be set.
 
-esc_report[8] esc
+px4/EscReport[8] esc

msg/EstimatorInnovations.msg

@@ -34,5 +34,3 @@ float32 hagl		# height of ground innovation (m) and innovation variance (m**2)
 
 # The innovation test ratios are scalar values. In case the field is a vector,
 # the test ratio will be put in the first component of the vector.
-
-# TOPICS estimator_innovations estimator_innovation_variances estimator_innovation_test_ratios

msg/FollowTarget.msg

@@ -1,8 +1,8 @@
 uint64 timestamp		# time since system start (microseconds)
 float64 lat			# target position (deg * 1e7)
-float64 lon			# target position (deg * 1e7) 
+float64 lon			# target position (deg * 1e7)
 float32 alt			# target position
 float32 vy			# target vel in y
 float32 vx			# target vel in x
-float32 vz			# target vel in z 
+float32 vz			# target vel in z
 uint8 est_cap # target reporting capabilities