refactor(sensor_airspeed_sim): remove previous airspeed failure implementation

src/modules/simulation/sensor_airspeed_sim/SensorAirspeedSim.cpp

@@ -108,7 +108,6 @@ void SensorAirspeedSim::Run()
 		updateParams();
 	}
 
-	if (_sim_failure.get() == 0) {
 	if (_vehicle_local_position_sub.updated() && _vehicle_global_position_sub.updated()
 	    && _vehicle_attitude_sub.updated()) {
 
@@ -151,7 +150,6 @@ void SensorAirspeedSim::Run()
 		_differential_pressure_pub.publish(differential_pressure);
 
 	}
-	}
 
 	perf_end(_loop_perf);
 }

src/modules/simulation/sensor_airspeed_sim/SensorAirspeedSim.hpp

@@ -91,8 +91,4 @@ private:
 	uORB::PublicationMulti<differential_pressure_s> _differential_pressure_pub{ORB_ID(differential_pressure)};
 
 	perf_counter_t _loop_perf{perf_alloc(PC_ELAPSED, MODULE_NAME": cycle")};
-
-	DEFINE_PARAMETERS(
-		(ParamInt<px4::params::SIM_ARSPD_FAIL>) _sim_failure
-	)
 };

src/modules/simulation/sensor_airspeed_sim/parameters.yaml

@@ -13,14 +13,3 @@ parameters:
       reboot_required: true
       min: 0
       max: 1
-    SIM_ARSPD_FAIL:
-      description:
-        short: Dynamically simulate failure of airspeed sensor instance
-      type: enum
-      values:
-        0: Disabled
-        1: Enabled
-      default: 0
-      reboot_required: true
-      min: 0
-      max: 1