Mirrors_Framework/PX4-Autopilot
1
0
Fork 0
mirror of https://github.com/PX4/PX4-Autopilot.git synced 2026-05-31 02:16:53 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

fix(ci): enable clang-tidy bugprone-macro-parentheses (#26722)

Browse Source 
Signed-off-by: kuralme <kuralme@protonmail.com>
This commit is contained in:
Ege Kural
2026-03-12 16:42:07 -04:00
committed by GitHub
parent 11700382f6
commit 4a33fb169f
5 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.clang-tidy
-1
View File
@@ -150,7 +150,6 @@ Checks: '*,
-readability-convert-member-functions-to-static, -readability-convert-member-functions-to-static,
-readability-make-member-function-const, -readability-make-member-function-const,
-bugprone-implicit-widening-of-multiplication-result, -bugprone-implicit-widening-of-multiplication-result,
-bugprone-macro-parentheses,
-bugprone-multi-level-implicit-pointer-conversion, -bugprone-multi-level-implicit-pointer-conversion,
-bugprone-signed-char-misuse, -bugprone-signed-char-misuse,
-cppcoreguidelines-avoid-non-const-global-variables, -cppcoreguidelines-avoid-non-const-global-variables,
platforms/common/uORB/uORB_tests/uORBTest_UnitTest.cpp
+2 -2
View File
@@ -645,7 +645,7 @@ int uORBTest::UnitTest::test_wrap_around()
} }
#define CHECK_COPY(i_got, i_correct) \ #define CHECK_COPY(i_got, i_correct) \
orb_copy(ORB_ID(orb_test_medium_wrap_around), sfd, &u); \ orb_copy(ORB_ID(orb_test_medium_wrap_around), sfd, &u); \
if (i_got != i_correct) { \ if ((i_got) != (i_correct)) { \
return test_fail("got wrong element from the queue (got %i, should be %i)", i_got, i_correct); \ return test_fail("got wrong element from the queue (got %i, should be %i)", i_got, i_correct); \
} }
@@ -875,7 +875,7 @@ int uORBTest::UnitTest::test_queue()
} }
#define CHECK_COPY(i_got, i_correct) \ #define CHECK_COPY(i_got, i_correct) \
orb_copy(ORB_ID(orb_test_medium_queue), sfd, &u); \ orb_copy(ORB_ID(orb_test_medium_queue), sfd, &u); \
if (i_got != i_correct) { \ if ((i_got) != (i_correct)) { \
return test_fail("got wrong element from the queue (got %i, should be %i)", i_got, i_correct); \ return test_fail("got wrong element from the queue (got %i, should be %i)", i_got, i_correct); \
} }
src/drivers/camera_trigger/camera_trigger.cpp
+1 -1
View File
@@ -88,7 +88,7 @@ typedef enum : int32_t {
TRIGGER_MODE_DISTANCE_ON_CMD TRIGGER_MODE_DISTANCE_ON_CMD
} trigger_mode_t; } trigger_mode_t;
#define commandParamToInt(n) static_cast<int>(n >= 0 ? n + 0.5f : n - 0.5f) #define commandParamToInt(n) static_cast<int>((n) >= 0 ? (n) + 0.5f : (n) - 0.5f)
class CameraTrigger final : public px4::ScheduledWorkItem class CameraTrigger final : public px4::ScheduledWorkItem
{ {
src/lib/tinybson/tinybson.cpp
+2 -2
View File
@@ -51,8 +51,8 @@
# define debug(fmt, args...) do { } while(0) # define debug(fmt, args...) do { } while(0)
#endif #endif
#define CODER_CHECK(_c) do { if (_c->dead) { PX4_ERR("coder dead"); return -1; }} while(0) #define CODER_CHECK(_c) do { if ((_c)->dead) { PX4_ERR("coder dead"); return -1; }} while(0)
#define CODER_KILL(_c, _reason) do { PX4_ERR("killed: %s", _reason); _c->dead = true; return -1; } while(0) #define CODER_KILL(_c, _reason) do { PX4_ERR("killed: %s", _reason); (_c)->dead = true; return -1; } while(0)
static int static int
read_x(bson_decoder_t decoder, void *p, size_t s) read_x(bson_decoder_t decoder, void *p, size_t s)
src/lib/tunes/tunes.cpp
+1 -1
View File
@@ -46,7 +46,7 @@
#include <errno.h> #include <errno.h>
#define BEAT_TIME_CONVERSION_MS (60 * 1000 * 4) #define BEAT_TIME_CONVERSION_MS (60 * 1000 * 4)
#define BEAT_TIME_CONVERSION_US BEAT_TIME_CONVERSION_MS * 1000 #define BEAT_TIME_CONVERSION_US (BEAT_TIME_CONVERSION_MS * 1000)
#define BEAT_TIME_CONVERSION BEAT_TIME_CONVERSION_US #define BEAT_TIME_CONVERSION BEAT_TIME_CONVERSION_US
// semitone offsets from C for the characters 'A'-'G' // semitone offsets from C for the characters 'A'-'G'