chore(claude): overhaul review-pr skill to focus on substance (#27892)

Browse Source

* chore(claude): overhaul review-pr skill to focus on substance

The skill spent most of its 207 lines on process: merge-strategy
recommendations, commit-message auditing, formatting checks, and an
interactive posting menu. That feedback is nit-picky noise for a PR
author, and CI already enforces formatting.

Rewrite it (49 lines) around reviewing substance: merit and need (root
cause vs papering over), first-principles analysis for physics/math
changes, architecture consistency with the surrounding code, and an
alternatives assessment. Output is a debrief for the operator plus a
terse, actionable draft comment explicitly attributed as a Claude
review.

Signed-off-by: Jacob Dahl <dahl.jakejacob@gmail.com>

* chore(claude): generalize numeric-robustness check beyond float32

The physics/math check hardcoded float32; not all flight-critical math
uses it. Phrase the robustness check in terms of the given
representation, keeping float32 precision as a concrete example.

Signed-off-by: Jacob Dahl <dahl.jakejacob@gmail.com>

* chore(claude): fold maintainability into the architecture check

Rename the check to Architecture and maintainability and direct it at
hidden cross-module coupling — a change that silently breaks an
assumption in another module — asking for a contract-codifying unit
test when such coupling is unavoidable.

Signed-off-by: Jacob Dahl <dahl.jakejacob@gmail.com>

* chore(claude): add reliability to the correctness check

Reliability was not called out anywhere. Rename to Correctness and
reliability and add resource exhaustion and failure-path handling to
the list of defects to look for.

Signed-off-by: Jacob Dahl <dahl.jakejacob@gmail.com>

* chore(claude): make the debrief lead with findings

A per-file restatement of a well-described PR wastes tokens and time.
Have the debrief lead with actionable findings and only explain what
the change does when the PR description is missing, ambiguous, or
misleading.

Signed-off-by: Jacob Dahl <dahl.jakejacob@gmail.com>

* chore(claude): require provable, objectively-framed findings

Direct the draft comment to frame findings as engineering tradeoffs
rather than judgments, and to stay silent on any flaw it cannot
demonstrate via a concrete code path or first-principles derivation.

Signed-off-by: Jacob Dahl <dahl.jakejacob@gmail.com>

---------

Signed-off-by: Jacob Dahl <dahl.jakejacob@gmail.com>

...

This commit is contained in:

Jacob Dahl

2026-07-14 10:03:37 -06:00

committed by GitHub

parent 25bb4a2224

commit 219fcf387d

1 changed files with 26 additions and 184 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

.claude/skills/review-pr/SKILL.md

+26 -184

File diff suppressed because it is too large Load Diff