Mirrors_Framework/ODrive
1
0
Fork 0
mirror of https://github.com/odriverobotics/ODrive.git synced 2026-09-20 22:55:00 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix buffer overflow issue in 'w' and 'r' commands

Browse Source
This commit is contained in:
Paul Guenette
2019-05-12 00:37:13 +02:00
parent 4ecaba769f
commit d84a5f6471
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Firmware/communication/ascii_protocol.cpp
+2 -2
View File
@@ -216,7 +216,7 @@ void ASCII_protocol_process_line(const uint8_t* buffer, size_t len, StreamSink&
} else if (cmd[0] == 'r') { // read property
char name[MAX_LINE_LENGTH];
int numscan = sscanf(cmd, "r %" TO_STR(MAX_LINE_LENGTH) "s", name);
int numscan = sscanf(cmd, "r %255s", name);
if (numscan < 1) {
respond(response_channel, use_checksum, "invalid command format");
} else {
@@ -236,7 +236,7 @@ void ASCII_protocol_process_line(const uint8_t* buffer, size_t len, StreamSink&
} else if (cmd[0] == 'w') { // write property
char name[MAX_LINE_LENGTH];
char value[MAX_LINE_LENGTH];
int numscan = sscanf(cmd, "w %" TO_STR(MAX_LINE_LENGTH) "s %" TO_STR(MAX_LINE_LENGTH) "s", name, value);
int numscan = sscanf(cmd, "w %255s %255s", name, value);
if (numscan < 1) {
respond(response_channel, use_checksum, "invalid command format");
} else {