mirror of
https://github.com/wxWidgets/wxWidgets.git
synced 2026-08-18 01:19:45 +08:00
wxDateTimeChristianHolidays was tested with a wxDateTimeUSCatholicFeasts already existing and taking precedence. I.e. the tests for Christmas in ChristianHolidays actually tested (again) the USCatholicFeasts implementation. This reveals an off-by-one bug in wxDateTimeChristianHolidays::DoIsHoliday(), which doesn't use the enum symbol for month, and declares Christmas to be on the 25th day of the 13th month. Further, this raises the question whether it is a bad idea to have the authority implementations in a header. Fixing bugs like this would require recompiling the application, instead of simply updating the DLL/dylib.