From 9886f14fdb133898bee7efcdaec63f5915a2a7de Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Sat, 13 Sep 2025 15:42:13 +0200 Subject: [PATCH] Don't leave temporary files after running "Load" unit test This test created temporary files but never deleted them. Fix this by using TestFile helper class, which also simplifies the test code. --- tests/misc/garbage.cpp | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/tests/misc/garbage.cpp b/tests/misc/garbage.cpp index 1b23b4fa0b..1eeaa1ca2b 100644 --- a/tests/misc/garbage.cpp +++ b/tests/misc/garbage.cpp @@ -12,6 +12,8 @@ #include "testprec.h" +#include "testfile.h" + #include "wx/filename.h" #include "wx/image.h" @@ -146,17 +148,10 @@ TEST_CASE("Load", "[garbage]") data[i] = rand(); // write it to a file - wxString garbagename = wxFileName::CreateTempFileName("garbage"); - CHECK(!garbagename.empty()); - - wxFile garbage(garbagename, wxFile::write); - CHECK(garbage.IsOpened()); - - CHECK(garbage.Write(data, size) == size); - garbage.Close(); + TestFile tf(data, size); // try to load it by name - DoLoadGarbageFile(garbagename); + DoLoadGarbageFile(tf.GetName()); // try to load it from a wxInputStream wxMemoryInputStream stream(data, size);