Files
lvgl/.github/instructions/c-code.instructions.md
T
VIFEX 50e2852624
Arduino Lint / lint (push) Has been cancelled
Build Examples with C++ Compiler / build-examples (push) Has been cancelled
MicroPython CI / Build esp32 port (push) Has been cancelled
MicroPython CI / Build rp2 port (push) Has been cancelled
MicroPython CI / Build stm32 port (push) Has been cancelled
MicroPython CI / Build unix port (push) Has been cancelled
C/C++ CI / Build OPTIONS_16BIT - Ubuntu (push) Has been cancelled
C/C++ CI / Build OPTIONS_24BIT - Ubuntu (push) Has been cancelled
C/C++ CI / Build OPTIONS_FULL_32BIT - Ubuntu (push) Has been cancelled
C/C++ CI / Build OPTIONS_NORMAL_8BIT - Ubuntu (push) Has been cancelled
C/C++ CI / Build OPTIONS_SDL - Ubuntu (push) Has been cancelled
C/C++ CI / Build OPTIONS_16BIT - cl - Windows (push) Has been cancelled
C/C++ CI / Build OPTIONS_16BIT - gcc - Windows (push) Has been cancelled
C/C++ CI / Build OPTIONS_24BIT - cl - Windows (push) Has been cancelled
C/C++ CI / Build OPTIONS_24BIT - gcc - Windows (push) Has been cancelled
C/C++ CI / Build OPTIONS_FULL_32BIT - cl - Windows (push) Has been cancelled
C/C++ CI / Build OPTIONS_FULL_32BIT - gcc - Windows (push) Has been cancelled
C/C++ CI / Build ESP IDF ESP32S3 (push) Has been cancelled
C/C++ CI / Run tests with 32bit build (push) Has been cancelled
C/C++ CI / Run tests with 64bit build (push) Has been cancelled
BOM Check / bom-check (push) Has been cancelled
Verify that lv_conf_internal.h matches repository state / verify-conf-internal (push) Has been cancelled
Verify GDB constants are up-to-date / verify-gdb-consts (push) Has been cancelled
Verify the widget property name / verify-property-name (push) Has been cancelled
Verify code formatting / verify-formatting (push) Has been cancelled
Compare file templates with file names / template-check (push) Has been cancelled
Build Docs / build-and-deploy (push) Has been cancelled
Test API JSON generator / Test API JSON (push) Has been cancelled
Install LVGL using CMake / build-examples (push) Has been cancelled
Check Makefile / Build using Makefile (push) Has been cancelled
Check Makefile for UEFI / Build using Makefile for UEFI (push) Has been cancelled
Emulated Performance Test / ARM Emulated Benchmark - Script Check (scripts/perf/tests/benchmark_results_comment/test.sh) (push) Has been cancelled
Emulated Performance Test / ARM Emulated Benchmark - Script Check (scripts/perf/tests/filter_docker_logs/test.sh) (push) Has been cancelled
Emulated Performance Test / ARM Emulated Benchmark - Script Check (scripts/perf/tests/serialize_results/test.sh) (push) Has been cancelled
Hardware Performance Test / Hardware Performance Benchmark (push) Has been cancelled
Hardware Performance Test / HW Benchmark - Save PR Number (push) Has been cancelled
Performance Tests CI / Perf Tests OPTIONS_TEST_PERF_32B - Ubuntu (push) Has been cancelled
Performance Tests CI / Perf Tests OPTIONS_TEST_PERF_64B - Ubuntu (push) Has been cancelled
Port repo release update / run-release-branch-updater (push) Has been cancelled
Verify Font License / verify-font-license (push) Has been cancelled
Verify Kconfig / verify-kconfig (push) Has been cancelled
Emulated Performance Test / ARM Emulated Benchmark 32b - lv_conf_perf32b (push) Has been cancelled
Emulated Performance Test / ARM Emulated Benchmark 64b - lv_conf_perf64b (push) Has been cancelled
Emulated Performance Test / ARM Emulated Benchmark - Save PR Number (push) Has been cancelled
ci(review): add Copilot code review instructions (#10012)
2026-04-24 13:42:38 +02:00

1.8 KiB

applyTo
applyTo
src/**/*.c,src/**/*.h

LVGL C Source Review Rules

Memory Safety

  • Every lv_malloc / lv_realloc must have a NULL check immediately after
  • Every allocation must have a matching lv_free on all exit paths (including error paths)
  • lv_free(NULL) is safe — don't add redundant NULL checks before it
  • Pointer parameters: NULL-check before dereference when caller could reasonably pass NULL
  • Array access must be bounds-checked

Error Handling

  • Functions returning lv_result_t must be checked by callers
  • Error paths must clean up all allocated resources before returning
  • Graceful runtime fallback is preferred over assert for recoverable failures (e.g. cache allocation failure should degrade, not crash)
  • Add LV_LOG_WARN for unexpected but recoverable conditions
  • Add LV_LOG_ERROR for conditions that indicate a bug

Performance

  • No heap allocation in hot paths (draw loops, event handlers, timer callbacks)
  • Prefer stack allocation for small temporary buffers
  • Avoid lv_obj_is_valid() in internal callbacks — it walks the entire object tree
  • Cache-friendly access: sequential over random
  • Struct member ordering: pointers first, then int32_t, then smaller types/bitfields — minimizes padding

Portability

  • No platform headers without #if guards
  • No compiler extensions without fallback
  • No float/double in core code unless behind LV_USE_FLOAT
  • Use LV_ATTRIBUTE_* macros for alignment/section placement
  • Use "%" LV_PRId32 for int32_t format strings, not "%d"

Include Structure

  • .h files: #ifndef LV_<MODULE>_H / #define / #endif
  • Feature-gated files: keep #if LV_USE_<FEATURE> near the top and the matching #endif at the bottom; necessary includes (module headers, private headers) may appear before the feature guard
  • Never include test headers in production source files