From ff65e702e6a83697b409cebd972638fa21cdf313 Mon Sep 17 00:00:00 2001
From: Gabor Kiss-Vamosi <kisvegabor@gmail.com>
Date: Thu, 2 Apr 2026 06:14:12 +0200
Subject: [PATCH] fix(lodepng): return error when 16 bit/channel images are
 used (#9882)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
---
 src/libs/lodepng/lodepng.c                    |   4 +++
 src/libs/lodepng/lv_lodepng.c                 |   1 +
 .../test_assets/test_16bit_per_channel.png    | Bin 0 -> 567 bytes
 .../src/test_cases/libs/test_libjpeg_turbo.c  |  26 ++++--------------
 tests/src/test_cases/libs/test_libpng.c       |   5 ++++
 tests/src/test_cases/libs/test_lodepng.c      |  15 ++++++++++
 tests/src/test_cases/libs/test_tjpgd.c        |   5 ++++
 7 files changed, 35 insertions(+), 21 deletions(-)
 create mode 100644 tests/src/test_assets/test_16bit_per_channel.png

diff --git a/src/libs/lodepng/lodepng.c b/src/libs/lodepng/lodepng.c
index 7e37636a20..b339538e53 100644
--- a/src/libs/lodepng/lodepng.c
+++ b/src/libs/lodepng/lodepng.c
@@ -4668,6 +4668,8 @@ unsigned lodepng_inspect(unsigned * w, unsigned * h, LodePNGState * state,
     if(info->filter_method != 0) CERROR_RETURN_ERROR(state->error, 33);
     /*error: only interlace methods 0 and 1 exist in the specification*/
     if(info->interlace_method > 1) CERROR_RETURN_ERROR(state->error, 34);
+    /*error: bitdepths > 8 bits per channel are not supported*/
+    if(info->color.bitdepth > 8) CERROR_RETURN_ERROR(state->error, 116);
 
     if(!state->decoder.ignore_crc) {
         unsigned CRC = lodepng_read32bitInt(&in[29]);
@@ -7432,6 +7434,8 @@ const char * lodepng_error_text(unsigned code)
             return "sBIT chunk has wrong size for the color type of the image";
         case 115:
             return "sBIT value out of range";
+        case 116:
+            return "bitdepths > 8 bits per channel are not supported";
     }
     return "unknown error code";
 }
diff --git a/src/libs/lodepng/lv_lodepng.c b/src/libs/lodepng/lv_lodepng.c
index 4ec0b1d137..f61db5bd6f 100644
--- a/src/libs/lodepng/lv_lodepng.c
+++ b/src/libs/lodepng/lv_lodepng.c
@@ -246,6 +246,7 @@ static lv_draw_buf_t * decode_png_data(const void * png_data, size_t png_data_si
     /*Decode the image in ARGB8888 */
     unsigned error = lodepng_decode32((unsigned char **)&decoded, &png_width, &png_height, png_data, png_data_size);
     if(error) {
+        LV_LOG_WARN("error %u: %s", error, lodepng_error_text(error));
         if(decoded != NULL)  lv_draw_buf_destroy(decoded);
         return NULL;
     }
diff --git a/tests/src/test_assets/test_16bit_per_channel.png b/tests/src/test_assets/test_16bit_per_channel.png
new file mode 100644
index 0000000000000000000000000000000000000000..2a9c9587b2cbccdc9bcbbfd323a76dced5190f29
GIT binary patch
literal 567
zcmeAS@N?(olHy`uVBq!ia0vp^3Lq@N1|*eVE!z&_Bzpw;GB8xBF)%c=FfjZA3N^f7
zU???UV0e|lz+g3lfkC`r&aOZkpaffzx4X-KFyM^%eg`O`TH+c}l9E`GYL#4+3Zxi}
z42;Zl4UBaS%|Z+<tqcvU42`u746F<c^rOraQ8eV{r(~v8LNyra8X1Hbnpv3wHJC#*
zyyDo$2-Khfx1l66H?_DVF}DC=iDihPv6Z2Pm9Ys#kLIWAkqiusTAnVBAsP4H&OFWA
zV!-3_{W8Z~2hAxCoFz<i1GuI*u)k59#XM2zxWh5U)4O|)v{n?zSnr8bGwHotc~5(u
z_<0k{yW932;*iUiW)>(Yh}=?IYq@@<*7DfrAzq~t8+81xPfb1Hs&F8&;MMY7VH;Bu
zQno34*v!~2V!G)4TIH`9x3@I5U%At9CEmtN`ApyW3x&tR)-<<;p7LIGzU90j^Q&J~
z!Rs5+9M)a1<LT-zJvBdnDgU-PLE72AHQH<MFx@OqdR1!2HYL-+#*4Yg_Fv7U(zcyp
z|DT9!U$eDeZ_G2n`@H{rL4&*~b|?AS?`M4q@;xA+UUYrRb@Ahe+7vlsHgzR%PnpE|
z%-o&-|GArdMzTwkBw}l9j!oRW?@2<}6|uFCmie=^oICU1wl6-@rcQoKQBW`=(`sNy
OGkCiCxvX<aXaWGx0MXC@

literal 0
HcmV?d00001

diff --git a/tests/src/test_cases/libs/test_libjpeg_turbo.c b/tests/src/test_cases/libs/test_libjpeg_turbo.c
index dad12c9372..7d410fd816 100644
--- a/tests/src/test_cases/libs/test_libjpeg_turbo.c
+++ b/tests/src/test_cases/libs/test_libjpeg_turbo.c
@@ -8,6 +8,11 @@
 void setUp(void)
 {
     /* Function run before every test */
+    /* Temporarily remove other JPEG decoders to make sure libjpeg is used */
+    lv_tjpgd_deinit();
+#if LV_USE_FFMPEG
+    lv_ffmpeg_deinit();
+#endif
 }
 
 void tearDown(void)
@@ -59,9 +64,6 @@ static void create_images(void)
 
 void test_jpg_2(void)
 {
-    /* Temporarily remove tjpgd decoder */
-    lv_tjpgd_deinit();
-
     create_images();
 
     TEST_ASSERT_EQUAL_SCREENSHOT("libs/jpg_2.png");
@@ -77,25 +79,16 @@ void test_jpg_2(void)
     TEST_ASSERT_EQUAL_SCREENSHOT("libs/jpg_2.png");
 
     TEST_ASSERT_MEM_LEAK_LESS_THAN(mem_before, 64);
-
-    /* Re-add tjpgd decoder */
-    lv_tjpgd_init();
 }
 
 void test_jpg_cmyk(void)
 {
-    /* Temporarily remove tjpgd decoder */
-    lv_tjpgd_deinit();
-
     lv_obj_clean(lv_screen_active());
     lv_obj_t * img = lv_image_create(lv_screen_active());
     lv_image_set_src(img, "A:src/test_assets/test_img_lvgl_logo_cmyk.jpg");
     lv_obj_align(img, LV_ALIGN_CENTER, 0, 0);
 
     TEST_ASSERT_EQUAL_SCREENSHOT("libs/jpg_cmyk.png");
-
-    /* Re-add tjpgd decoder */
-    lv_tjpgd_init();
 }
 
 void test_jpg_sign_error(void)
@@ -109,16 +102,10 @@ void test_jpg_sign_error(void)
     lv_obj_align(img, LV_ALIGN_CENTER, 0, 0);
 
     TEST_ASSERT_EQUAL_SCREENSHOT("libs/jpg_sign_error.png");
-
-    /* Re-add tjpgd decoder */
-    lv_tjpgd_init();
 }
 
 void test_jpg_decode_failed(void)
 {
-    /* Temporarily remove tjpgd decoder */
-    lv_tjpgd_deinit();
-
     lv_image_decoder_dsc_t decoder_dsc;
     const char * image_path = "A:src/test_assets/test_img_lvgl_logo_with_decode_failed.jpg";
 
@@ -127,9 +114,6 @@ void test_jpg_decode_failed(void)
 
     /* Should fail when decoder is removed */
     TEST_ASSERT_EQUAL(LV_RESULT_INVALID, res);
-
-    /* Re-add tjpgd decoder */
-    lv_tjpgd_init();
 }
 
 #endif
diff --git a/tests/src/test_cases/libs/test_libpng.c b/tests/src/test_cases/libs/test_libpng.c
index 5eca0e02ad..a8c922e10b 100644
--- a/tests/src/test_cases/libs/test_libpng.c
+++ b/tests/src/test_cases/libs/test_libpng.c
@@ -8,6 +8,11 @@
 void setUp(void)
 {
     /* Function run before every test */
+    /* Temporarily remove other PNG-capable decoders (lodepng/ffmpeg) to make sure libpng is used */
+    lv_lodepng_deinit();
+#if LV_USE_FFMPEG
+    lv_ffmpeg_deinit();
+#endif
 }
 
 void tearDown(void)
diff --git a/tests/src/test_cases/libs/test_lodepng.c b/tests/src/test_cases/libs/test_lodepng.c
index fbd5b22cd3..5b1cb3b391 100644
--- a/tests/src/test_cases/libs/test_lodepng.c
+++ b/tests/src/test_cases/libs/test_lodepng.c
@@ -8,6 +8,11 @@
 void setUp(void)
 {
     /* Function run before every test */
+    /* Temporarily remove other PNG decoders to make sure lodepng is used */
+    lv_libpng_deinit();
+#if LV_USE_FFMPEG
+    lv_ffmpeg_deinit();
+#endif
 }
 
 void tearDown(void)
@@ -76,4 +81,14 @@ void test_lodepng_1(void)
     lv_libpng_init();
 }
 
+void test_lodepng_no_crash_with_16bit(void)
+{
+    /*LodePNG should return a custom error code (116) as it's crash with 16 bit/channel images.
+     *(Consider upstreaming the changes)*/
+    lv_obj_t * img = lv_image_create(lv_screen_active());
+    lv_image_set_src(img, "A:src/test_assets/test_16bit_per_channel.png");
+    lv_refr_now(NULL);
+}
+
+
 #endif
diff --git a/tests/src/test_cases/libs/test_tjpgd.c b/tests/src/test_cases/libs/test_tjpgd.c
index 01dd297ac4..98908f7421 100644
--- a/tests/src/test_cases/libs/test_tjpgd.c
+++ b/tests/src/test_cases/libs/test_tjpgd.c
@@ -8,6 +8,11 @@
 void setUp(void)
 {
     /* Function run before every test */
+    /* Temporarily remove other JPEG decoders to make sure tjpegd is used */
+    lv_libjpeg_turbo_deinit();
+#if LV_USE_FFMPEG
+    lv_ffmpeg_deinit();
+#endif
 }
 
 void tearDown(void)