From c582d291daf2e8d8938fa1fa5070d020f9c93ad1 Mon Sep 17 00:00:00 2001 From: Niklas Fiekas Date: Fri, 23 Jan 2026 01:24:41 +0100 Subject: [PATCH] fix(property): remove LV_PROPERTY_TEXTAREA_INSERT_REPLACE (#9606) (#9625) --- src/widgets/property/lv_obj_property_names.h | 2 +- src/widgets/property/lv_textarea_properties.c | 3 +-- src/widgets/textarea/lv_textarea.c | 5 ----- src/widgets/textarea/lv_textarea.h | 11 +++++------ tests/src/test_cases/widgets/test_textarea.c | 5 ----- 5 files changed, 7 insertions(+), 19 deletions(-) diff --git a/src/widgets/property/lv_obj_property_names.h b/src/widgets/property/lv_obj_property_names.h index 8d4471b6df..336d204bea 100644 --- a/src/widgets/property/lv_obj_property_names.h +++ b/src/widgets/property/lv_obj_property_names.h @@ -34,6 +34,6 @@ extern const lv_property_name_t lv_switch_property_names[1]; extern const lv_property_name_t lv_table_property_names[2]; extern const lv_property_name_t lv_tabview_property_names[2]; - extern const lv_property_name_t lv_textarea_property_names[15]; + extern const lv_property_name_t lv_textarea_property_names[14]; #endif #endif diff --git a/src/widgets/property/lv_textarea_properties.c b/src/widgets/property/lv_textarea_properties.c index 7bed65eabd..2da616487e 100644 --- a/src/widgets/property/lv_textarea_properties.c +++ b/src/widgets/property/lv_textarea_properties.c @@ -14,12 +14,11 @@ * Generated code from properties.py */ /* *INDENT-OFF* */ -const lv_property_name_t lv_textarea_property_names[15] = { +const lv_property_name_t lv_textarea_property_names[14] = { {"accepted_chars", LV_PROPERTY_TEXTAREA_ACCEPTED_CHARS,}, {"current_char", LV_PROPERTY_TEXTAREA_CURRENT_CHAR,}, {"cursor_click_pos", LV_PROPERTY_TEXTAREA_CURSOR_CLICK_POS,}, {"cursor_pos", LV_PROPERTY_TEXTAREA_CURSOR_POS,}, - {"insert_replace", LV_PROPERTY_TEXTAREA_INSERT_REPLACE,}, {"label", LV_PROPERTY_TEXTAREA_LABEL,}, {"max_length", LV_PROPERTY_TEXTAREA_MAX_LENGTH,}, {"one_line", LV_PROPERTY_TEXTAREA_ONE_LINE,}, diff --git a/src/widgets/textarea/lv_textarea.c b/src/widgets/textarea/lv_textarea.c index c7a9d69d1b..2b6416db78 100644 --- a/src/widgets/textarea/lv_textarea.c +++ b/src/widgets/textarea/lv_textarea.c @@ -116,11 +116,6 @@ static const lv_property_ops_t lv_textarea_properties[] = { .setter = lv_textarea_set_max_length, .getter = lv_textarea_get_max_length, }, - { - .id = LV_PROPERTY_TEXTAREA_INSERT_REPLACE, - .setter = lv_textarea_set_insert_replace, - .getter = NULL, - }, { .id = LV_PROPERTY_TEXTAREA_TEXT_SELECTION, .setter = lv_textarea_set_text_selection, diff --git a/src/widgets/textarea/lv_textarea.h b/src/widgets/textarea/lv_textarea.h index 24e57802bd..d9df59dc78 100644 --- a/src/widgets/textarea/lv_textarea.h +++ b/src/widgets/textarea/lv_textarea.h @@ -46,12 +46,11 @@ enum _lv_property_textarea_id_t { LV_PROPERTY_ID(TEXTAREA, ONE_LINE, LV_PROPERTY_TYPE_BOOL, 6), LV_PROPERTY_ID(TEXTAREA, ACCEPTED_CHARS, LV_PROPERTY_TYPE_TEXT, 7), LV_PROPERTY_ID(TEXTAREA, MAX_LENGTH, LV_PROPERTY_TYPE_INT, 8), - LV_PROPERTY_ID(TEXTAREA, INSERT_REPLACE, LV_PROPERTY_TYPE_TEXT, 9), - LV_PROPERTY_ID(TEXTAREA, TEXT_SELECTION, LV_PROPERTY_TYPE_BOOL, 10), - LV_PROPERTY_ID(TEXTAREA, PASSWORD_SHOW_TIME, LV_PROPERTY_TYPE_INT, 11), - LV_PROPERTY_ID(TEXTAREA, LABEL, LV_PROPERTY_TYPE_OBJ, 12), - LV_PROPERTY_ID(TEXTAREA, TEXT_IS_SELECTED, LV_PROPERTY_TYPE_INT, 13), - LV_PROPERTY_ID(TEXTAREA, CURRENT_CHAR, LV_PROPERTY_TYPE_INT, 14), + LV_PROPERTY_ID(TEXTAREA, TEXT_SELECTION, LV_PROPERTY_TYPE_BOOL, 9), + LV_PROPERTY_ID(TEXTAREA, PASSWORD_SHOW_TIME, LV_PROPERTY_TYPE_INT, 10), + LV_PROPERTY_ID(TEXTAREA, LABEL, LV_PROPERTY_TYPE_OBJ, 11), + LV_PROPERTY_ID(TEXTAREA, TEXT_IS_SELECTED, LV_PROPERTY_TYPE_INT, 12), + LV_PROPERTY_ID(TEXTAREA, CURRENT_CHAR, LV_PROPERTY_TYPE_INT, 13), LV_PROPERTY_TEXTAREA_END, }; #endif diff --git a/tests/src/test_cases/widgets/test_textarea.c b/tests/src/test_cases/widgets/test_textarea.c index 47a61df1a7..f331b32431 100644 --- a/tests/src/test_cases/widgets/test_textarea.c +++ b/tests/src/test_cases/widgets/test_textarea.c @@ -219,11 +219,6 @@ void test_textarea_properties(void) TEST_ASSERT_EQUAL_INT(10, lv_textarea_get_max_length(obj)); TEST_ASSERT_EQUAL_INT(10, lv_obj_get_property(obj, LV_PROPERTY_TEXTAREA_MAX_LENGTH).num); - prop.id = LV_PROPERTY_TEXTAREA_INSERT_REPLACE; - prop.ptr = "abcdef"; - /*No getter function for this property*/ - TEST_ASSERT_TRUE(lv_obj_set_property(obj, &prop) == LV_RESULT_OK); - prop.id = LV_PROPERTY_TEXTAREA_TEXT_SELECTION; prop.num = true; TEST_ASSERT_TRUE(lv_obj_set_property(obj, &prop) == LV_RESULT_OK);