Mirrors_UI_SDK/lvgl
1
0
Fork 0
mirror of https://github.com/lvgl/lvgl.git synced 2026-06-01 16:58:33 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

fix(obj) in lv_obj_move_to_index() do not send LV_EVENT_CHILD_CHANGED on all changed child

Browse Source 
The events will see half-ready child list and might crash
fixes #2541
This commit is contained in:
Gabor Kiss-Vamosi
2021-09-09 12:42:22 +02:00
parent 5ced08001c
commit 32e8276db7
1 changed files with 6 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/lv_obj_tree.c
+6 -11
View File
@@ -210,26 +210,21 @@ void lv_obj_move_to_index(lv_obj_t * obj, int32_t index)
if(index == old_index) return; if(index == old_index) return;
int32_t i = old_index; int32_t i = old_index;
if(index < old_index) if(index < old_index) {
{ while (i > index) {
while (i > index)
{
parent->spec_attr->children[i] = parent->spec_attr->children[i - 1]; parent->spec_attr->children[i] = parent->spec_attr->children[i - 1];
lv_event_send(parent, LV_EVENT_CHILD_CHANGED, parent->spec_attr->children[i]);
i--; i--;
} }
} }
else else {
{ while (i < index) {
while (i < index)
{
parent->spec_attr->children[i] = parent->spec_attr->children[i + 1]; parent->spec_attr->children[i] = parent->spec_attr->children[i + 1];
lv_event_send(parent, LV_EVENT_CHILD_CHANGED, parent->spec_attr->children[i]);
i++; i++;
} }
} }
parent->spec_attr->children[index] = obj; parent->spec_attr->children[index] = obj;
lv_event_send(parent, LV_EVENT_CHILD_CHANGED, obj); lv_event_send(parent, LV_EVENT_CHILD_CHANGED, NULL);
lv_obj_invalidate(parent); lv_obj_invalidate(parent);
} }